Re: RPG Game using BitBlt
Quote:
Originally Posted by
Conroy Vanderbluff
I don't care for criticism but ways to improve are welcome
Criticism is the way to improve, what you think
Re: RPG Game using BitBlt
I meant like "WHY DID YOU USE A TIMER?!?!" or "You need to work on your art". Things like that I see randomly on here.
Re: RPG Game using BitBlt
Quote:
Originally Posted by
Conroy Vanderbluff
I meant like "WHY DID YOU USE A TIMER?!?!" or "You need to work on your art". Things like that I see randomly on here.
In that case...
Use graphical buttons. No VB controls should be visible when you've taken the time to use and create these beautiful models and environments.
Re: RPG Game using BitBlt
You should add "Option Explicit" at the top of your forms and modules, or better, turn on the option so that it is automatically added to your code to remind you when you forget to declare a variable.
You have a number of cases where you have variables that were never declared, so they default to variants, which are generally inefficient since the intrinsic type the variant is, is wrapped in the variant meta data so is a little slower to use than if you declared what type you want the variables to be.
You use the Val function a lot, but Val is used to convert a string whose characters represent a number into a numeric type.
A lot of the places you use Val, the parameter is already a number, examples:
Val(playerMusic.settings.volume)
ManaMover = Val(ManaMover) + 1
Both volume and ManaMover are Longs, so most likely when you pass a Long to the Val function, VB has to convert the Long into a string, store it someplace, the pass the String address to the Val function, and the Val function converts the string back into a number and returns it for you to use.
You should get rid of the Val function when dealing with numbers, i.e. incrementing of ManaMover should just be:
ManaMover = ManaMover + 1