Label.text won't change.

I have written a public sub to update a label on a different form by passing in an integer. If I pass in the -1 value it will update the label, but if I pass in any other value, it will run the code (verified by stepping line by line) but the label won't update, even when adding the doevents.

Code:

---

Public Sub mstidlbl(ByVal cnt As Integer)
        SyncLock Form_PG_Collect_Master_ID_Label
            If cnt = -1 Then
                Form_PG_Collect_Master_ID_Label.Label1.Text = "ID: Paused..."
            Else
                Form_PG_Collect_Master_ID_Label.Label1.Text = ""ID: " & cnt
            End If
        End SyncLock
    End Sub

---

1. What does SyncLock Form_PG_Collect_Master_ID_Label do?
2. Why do you have two " before ID

What is the synclock about? Are you running this on a different thread?

cnt should be cnt.ToString, though that is unlikely to have any impact. I would guess that something you are doing is throwing an exception, which is being caught and consumed without showing any message. Where that could be happening is anybodies guess. Perhaps you know of some likely error handler.

The extra " was just a copying error while posting. There is no error handling and yes this is working from threading... A thread is controlled from a checkbox on the main form (checked=running/start,unchecked=paused). Unchecking on the main form will launch this sub (located on a different form) and pass in -1 for the label to update with "paused". If the thread is running (it runs on a different form), it will call the sub and update what cnt is (the number of loops the thread has ran through).

changing to cnt.tostring has not made a difference. I also tried just another string without the variable and that failed to update as well (tried "hi").

My guess would be that your form is not refreshing. Try calling me.refresh to redraw the form, which will update the label. If you are in a tight loop, you may only want to do this at some interval or every 100 loops.

So a background thread is updating a control on the UI thread? That should raise a cross threading exception.