CommonDialog in VC++

I have this piece of code and Juz wandering why my OpenDialog won't show up?

Code:

---

                                        OPENFILENAME ofn;      // common dialog box structure
                                        char szFile[260];      // buffer for file name
       
                                        // Initialize OPENFILENAME
                                        ZeroMemory(&ofn, sizeof(OPENFILENAME));
                                        ofn.lStructSize = sizeof(OPENFILENAME);
                                        ofn.hwndOwner = hWnd;
                                        ofn.lpstrFile = szFile;
                                        ofn.nMaxFile = sizeof(szFile);
                                        ofn.lpstrFilter = "MiniGIS map (*.map)\0 *.map\0";
                                        ofn.nFilterIndex = 1;
                                        ofn.lpstrFileTitle = NULL;
                                        ofn.nMaxFileTitle = 0;
                                        ofn.lpstrInitialDir = NULL;
                                        ofn.Flags = OFN_PATHMUSTEXIST | OFN_FILEMUSTEXIST;

                                        // Display the Open dialog box.
                                        if (GetOpenFileName(&ofn)==TRUE)
                                        {
                                                MessageBox(hWnd,"User was click the cancel button","Test",MB_OK);
                                        }
                                        else
                                        {       
                                                MessageBox(hWnd,ofn.lpstrFile,ofn.lpstrFile,MB_OK);
                                        }

                                        break;

---

But same method in VB, it does work perfectly.

[code]

Your code worked for me. You might want to be sure your hWnd is actually there when you call this function and not 0x00000000. You also might want to set through your program and see if it has a problem with one of your calls in that function.

Also you want to add:

Code:

---

char szFile[260];
strcpy(szFile, "");

---

To clear out your file name buffer.

And Change:

Code:

---

// Display the Open dialog box.
                                        if (!GetOpenFileName(&ofn))
                                        {
                                                MessageBox(hWnd,"User was click the cancel button","Test",MB_OK);
                                        }
                                        else
                                        {       
                                                MessageBox(hWnd,ofn.lpstrFile,ofn.lpstrFile,MB_OK);
                                        }

---

Well I think you have to include commctrl.lib and commctrl.h ?
and use InnitCommonControlsEx api?

That's for the common controls, not the common dialogs [sic].

ahh sometimes I think I'm silly :D

maybe it's the beer.. I heard common, so my brain automaticly thought about common controls ;)

Hehe :)

I did included the commdlg.h in my cpp file and linked the commdlg32.lib in my settings as well.

What I encounter is the GetOpenFileName(&ofn)==TRUE always return a TRUE.

Also, I run this under Win2K Pro platform. Will this cause any error.

Mean while I also, load the color dialog box and it work greate. Juz wandering what the Open File Dialog.

Code:

---

        CHOOSECOLOR cc;                // common dialog box structure
        static COLORREF acrCustClr[16]; // array of custom colors
        HBRUSH hbrush;                  // brush handle

        // Initialize CHOOSECOLOR
        ZeroMemory(&cc, sizeof(CHOOSECOLOR));
        cc.lStructSize = sizeof(CHOOSECOLOR);
        cc.hwndOwner = hWnd;
        cc.lpCustColors = (LPDWORD) acrCustClr;
        cc.rgbResult = Color;
        cc.Flags = CC_FULLOPEN | CC_RGBINIT;

        if (ChooseColor(&cc)==TRUE)
        {
                hbrush = CreateSolidBrush(cc.rgbResult);
                Color = cc.rgbResult;
                /*
                char        colorcode[16];
                memset(colorcode,0,16);
                sprintf(colorcode,"%s%ld", "User have selected color code ", cc.rgbResult);
                MessageBox(hWnd,colorcode,"Choose Color", MB_OK);
                */
               
                //Refresh the Map
                RefreshMap();
        }
        else
        {
                //MessageBox(hWnd,"User cancel the selection","Choose Color", MB_OK);
        }                                       

        break;

---

Technocrat, thanks for your advice and I'll try it out and back to you later :)

It should always return TRUE unless cancel or the X is pressed. I got it to work fine with

Code:

---

if(GetOpenFileName(&ofn))    //True
if(!GetOpenFileName(&ofn))  //False

---

Technocrat, you mean your Open Dialog was show on the screen?

Quote:

---

Originally posted by Technocrat
Your code worked for me.

---

If you want you can zip your project and post it and I will take a look at it.

Technocrat, enclose is my sample project. Please click the File menu and look for the Open for Open File Dialog and Color for Open Color dialog.

Thanks fr your time to look into my code :))

No problem.

Ok all you need to do is add this line:

Code:

---

char szFile[260];      // buffer for file name
strcpy(szFile,"");

---

And I would change to

Code:

---

if (!GetOpenFileName(&ofn))
                                        {
                                                MessageBox(hWnd,"User was click the cancel button","Test",MB_OK);
                                        }
                                        else
                                        {       
                                                MessageBox(hWnd,ofn.lpstrFile,ofn.lpstrFile,MB_OK);
                                        }

---

Wow... thanks Technocrat, it work perfectly and that what I wish to do too.

Juz wanna to know why there must do the strcpy first?

Code:

---

    strcpy(szFile,"");

---

regasrds,
Chris.C

Clears out your buffer. With Win2000 for some reason, I dont know, if that is not cleared out it doesn't work. With Win98 it worked, it was just full of NULL chars, and was messy.

So, can I juz use the memset to fill it up will all NULL value?

Yet, it is not stated in MSDN too :(

Umm I guess you could if you wanted to. But I would think that strcpy would be overall a little bit faster. But either way will get you the same thing.

I noticed that with any of the MSDN examples I saw that it did not show NULL the buffer before hand. I dunno why.

Technocrat, but anyway, thanks a lot for your help that make my open file dialog work as what I wish :))

No problem, I know what its like when you can get stuff to work right. Always glad to help when I can