Printable View
I am using a fileuploader i found online, however if i pass a filename with an & in it, on my POST form, it will not work.
Any ideas on how to get this to passthrough?
So for example, if i had a file named "Joe & Mitch File.doc"
It will pass joesupload.asp?filename=Joe & Mitch File.doc
It thinks that after the & there is a new variable..
Thanks guys
it needs to be url encoded...
-tg
Or do you know a good asp classic file uploader? that allows for & in the file name to be uploaded.
how do i do that on my form?Quote:
Originally Posted by techgnome
HTML Code:<HTML>
<HEAD><TITLE></TITLE></HEAD>
<BODY>
<FORM METHOD="POST" ENCTYPE="multipart/form-data" ACTION="uploadexmple.asp">
<font size="1" face="Verdana"><b>Select a file to upload:</b></font><br><INPUT TYPE=FILE SIZE="15" NAME="FILE1"> <INPUT TYPE=SUBMIT VALUE="Upload">
</FORM>
</BODY>
</HTML>
I dont know if URLEncold will work, since when i get the form value of file1, it will think the & in the value is the string delimiter...right?Quote:
Originally Posted by joefox
here is my complete code
i dont know if its my form, or my upload script i found online, i think its the upload script since anything with a & in it dosent work
uploadform.htm
uploadexample.aspHTML Code:<HTML>
<HEAD><TITLE></TITLE></HEAD>
<BODY>
<FORM METHOD="POST" ENCTYPE="multipart/form-data" ACTION="uploadexmple.asp">
<font size="1" face="Verdana"><b>Select a file to upload:</b></font><br><INPUT TYPE=FILE SIZE="15" NAME="FILE1"> <INPUT TYPE=SUBMIT VALUE="Upload">
</FORM>
</BODY>
</HTML>
HTML Code:<%
Class FileUploader
Public Files
Private mcolFormElem
Private Sub Class_Initialize()
Set Files = Server.CreateObject("Scripting.Dictionary")
Set mcolFormElem = Server.CreateObject("Scripting.Dictionary")
End Sub
Private Sub Class_Terminate()
If IsObject(Files) Then
Files.RemoveAll()
Set Files = Nothing
End If
If IsObject(mcolFormElem) Then
mcolFormElem.RemoveAll()
Set mcolFormElem = Nothing
End If
End Sub
Public Property Get Form(sIndex)
Form = ""
If mcolFormElem.Exists(LCase(sIndex)) Then Form = mcolFormElem.Item(LCase(sIndex))
End Property
Public Default Sub Upload()
Dim biData, sInputName
Dim nPosBegin, nPosEnd, nPos, vDataBounds, nDataBoundPos
Dim nPosFile, nPosBound
biData = Request.BinaryRead(Request.TotalBytes)
nPosBegin = 1
nPosEnd = InstrB(nPosBegin, biData, CByteString(Chr(13)))
If (nPosEnd-nPosBegin) <= 0 Then Exit Sub
vDataBounds = MidB(biData, nPosBegin, nPosEnd-nPosBegin)
nDataBoundPos = InstrB(1, biData, vDataBounds)
Do Until nDataBoundPos = InstrB(biData, vDataBounds & CByteString("--"))
nPos = InstrB(nDataBoundPos, biData, CByteString("Content-Disposition"))
nPos = InstrB(nPos, biData, CByteString("name="))
nPosBegin = nPos + 6
nPosEnd = InstrB(nPosBegin, biData, CByteString(Chr(34)))
sInputName = CWideString(MidB(biData, nPosBegin, nPosEnd-nPosBegin))
nPosFile = InstrB(nDataBoundPos, biData, CByteString("filename="))
nPosBound = InstrB(nPosEnd, biData, vDataBounds)
If nPosFile <> 0 And nPosFile < nPosBound Then
Dim oUploadFile, sFileName
Set oUploadFile = New UploadedFile
nPosBegin = nPosFile + 10
nPosEnd = InstrB(nPosBegin, biData, CByteString(Chr(34)))
sFileName = CWideString(MidB(biData, nPosBegin, nPosEnd-nPosBegin))
oUploadFile.FileName = Right(sFileName, Len(sFileName)-InStrRev(sFileName, "\"))
nPos = InstrB(nPosEnd, biData, CByteString("Content-Type:"))
nPosBegin = nPos + 14
nPosEnd = InstrB(nPosBegin, biData, CByteString(Chr(13)))
oUploadFile.ContentType = CWideString(MidB(biData, nPosBegin, nPosEnd-nPosBegin))
nPosBegin = nPosEnd+4
nPosEnd = InstrB(nPosBegin, biData, vDataBounds) - 2
oUploadFile.FileData = MidB(biData, nPosBegin, nPosEnd-nPosBegin)
If oUploadFile.FileSize > 0 Then Files.Add LCase(sInputName), oUploadFile
Else
nPos = InstrB(nPos, biData, CByteString(Chr(13)))
nPosBegin = nPos + 4
nPosEnd = InstrB(nPosBegin, biData, vDataBounds) - 2
If Not mcolFormElem.Exists(LCase(sInputName)) Then mcolFormElem.Add LCase(sInputName), CWideString(MidB(biData, nPosBegin, nPosEnd-nPosBegin))
End If
nDataBoundPos = InstrB(nDataBoundPos + LenB(vDataBounds), biData, vDataBounds)
Loop
End Sub
'String to byte string conversion
Private Function CByteString(sString)
Dim nIndex
For nIndex = 1 to Len(sString)
CByteString = CByteString & ChrB(AscB(Mid(sString,nIndex,1)))
Next
End Function
'Byte string to string conversion
Private Function CWideString(bsString)
Dim nIndex
CWideString =""
For nIndex = 1 to LenB(bsString)
CWideString = CWideString & Chr(AscB(MidB(bsString,nIndex,1)))
Next
End Function
End Class
Class UploadedFile
Public ContentType
Public FileName
Public FileData
Public Property Get FileSize()
FileSize = LenB(FileData)
End Property
Public Sub SaveToDisk(sPath)
Dim oFS, oFile
Dim nIndex
If sPath = "" Or FileName = "" Then Exit Sub
If Mid(sPath, Len(sPath)) <> "\" Then sPath = sPath & "\"
Set oFS = Server.CreateObject("Scripting.FileSystemObject")
If Not oFS.FolderExists(sPath) Then Exit Sub
Set oFile = oFS.CreateTextFile(sPath & FileName, True)
For nIndex = 1 to LenB(FileData)
oFile.Write Chr(AscB(MidB(FileData,nIndex,1)))
Next
oFile.Close
End Sub
Public Sub SaveToDatabase(ByRef oField)
If LenB(FileData) = 0 Then Exit Sub
If IsObject(oField) Then
oField.AppendChunk FileData
End If
End Sub
End Class
%>
<head>
</head>
<body>
<%
Dim Uploader, File
Set Uploader = New FileUploader
' This starts the upload process
Uploader.Upload()
If Uploader.Files.Count = 0 Then
Response.Write "<b><font size=""1"" face=""Verdana"" color=""red""><b>Error</b> - File(s) not uploaded.</font>"
Else
' Loop through the uploaded files
For Each File In Uploader.Files.Items
'Save Data To Folder Path
File.SaveToDisk "D:\testarea
Response.write "<img src=""../../images/link.gif""> <a href=""uploadform.htm""><font size=""1"" face=""Verdana"">Upload Another File</font></a>"
Next
End If
%>
</body>
If you are using POST, it shouldn't matter... the only time it does matter is if you are using GET, and are manipulating the data in the URL directly... using a form and POSTing or GETing it, it should be able to handle that for your automatically. Since you are using POST for the file, I'm not sure why you think it isn't working.
-tg
Yes, if i use a file with & in it, for some reason it says my Uploader.Files.Count = 0 but there really is a file there...Quote:
Originally Posted by techgnome
techgnome, anyway you can test on your end? I would be willing to pay a few bucks... :thumb:
After correcting two errors in your sample code (post #5 of this thread), this upload script worked without error for me for files with "&" in the name. Presumably just typos, the errors were:
Should be "uploadexample.asp" - missing an "a."Code:<FORM METHOD="POST" ENCTYPE="multipart/form-data" ACTION="uploadexmple.asp">
Need to enclose the path string with a " at the end of the line.Code:File.SaveToDisk "D:\testarea
I wonder why it works for you, and not for me?
Quote:
Originally Posted by SambaNeko
Perhaps there's something about your file aside from just its name - have you tried other files with & in the name? Other file types? The one I tried was a .jpg. Large files can also cause issues on upload forms sometimes - how big is the file you're trying?
Yes its just a text file, that is 20k its named Joe & Mitch.txtQuote:
Originally Posted by SambaNeko
I dont think that is the problem, the problem seems to be when it checks if any files are avialble for upload, when i check the count it says 0 when i upload anything with a 0 in it.