_______________________________
Printable View
_______________________________
Why make a mysql class when PHP has built in mysql functions already?
The first improvement you can make is to indent your code.
The second improvement is to throw it away and use PDO.
Dclamp: Why make a MySQL class when PHP has built in MySQL functions already?
:-O
1- Fastness
2- Secure
3- Prefect
4- Exactitude
5- Arrangment and regularity
6- Using in anywhere for anytimes. No 1 time.
7- 1 line code
And...
More? ;)
On line code for any times:? lines codes for ? times:Code:YPY_MySQL::_Excute_Query('...');
Code:if(!is_string($Str_Query) || $this->_Is_Blank($Str_Query) || !$this->_Is_Ready())
{
$this->_Pub_Ary_Event= array('Type'=> 'Warning', 'Description'=> 'Invalid query/Is not ready.');
@exit('')
};
_Free_Result();
$_Bln_Free_Result= true;
$Str_Query= @strval($Str_Query);
$Str_Query= @$this->_Clean_Value($Str_Query);
if($Bln_RemoveTag): @$this->_Remove_Tag($Str_Query);
endif;
if($Bln_Unbuffered): $_Prv_Int_QueryIdentity= @mysql_unbuffered_query($Str_Query, $_Prv_Int_ConnectIdentity) or $this->_Pub_Ary_Event= array('Type'=> 'Error', 'Description'=> 'Could not excute unbuffered query(#' . @mysql_errno($_Prv_Int_ConnectIdentity) . ').');
else: $_Prv_Int_QueryIdentity= @mysql_query($Str_Query, $_Prv_Int_ConnectIdentity) or $this->_Pub_Ary_Event= array('Type'=> 'Error', 'Description'=> 'Could not excute query(#' . @mysql_errno($_Prv_Int_ConnectIdentity) . ').');
endif;
$_Prv_Int_QueryIdentity ? $_Pub_Bln_QueryExcuted= true : $_Pub_Bln_QueryExcuted= false;
$_Pub_Bln_QueryExcuted && $_Pub_Bln_RowsAffected ? (boolean)true : (boolean)false;
...
@mysql_query($Str_Query);
Those reasons are bogus. I think you've just come up with the attributes of good code and listed them out three times each, in descending order of sanity.
What, pray, is faster or more secure about this:
than this?PHP Code:YPY_MySQL::_Excute_Query('drop schema xyz');
I know exactly what the second line does. I can guess what the first does, but to be sure, I would have to waste time deciphering your unreadable code. (Your naming convention and lack of indentation has done a better job than some code obfuscation tools.)PHP Code:mysql_query('drop schema syz');
I agree with pena, unless your writing a single function to santise against injection etc, this is purely reinventing the wheel.
And again, before you go trying to take over the world, learn about good coding practices, such as code indentation and naming conventions. Here is a good example, http://www.vbforums.com/showpost.php...49&postcount=7, the author is a bit weird tho...
Well, it clearly isn't...Quote:
Originally Posted by Y.P.Y
php Code:
Penagate, i dont know PDO. :(.
I_Love_My_Vans, this class is not for small/simple projects. This is for long/heavy projects.
Regardless of the project, the question Dylan asked was what is the benefit of using your own class rather then the built in MySQL functions within PHP, and the answers you gave apply to the built in functions, at what point is it faster to use x times more code?Quote:
Originally Posted by Y.P.Y
I can understand building a function like this perhaps increase your knowledge of how classes are created, but so far there has been no real evidence of your class being any better than a batch of small pox. And the reason why I haven't bowed down to you is because I cannot read your code to find out for myself.
It's good that your attempting to increase the efficiency of a problem, but I can see no reason to when all of your points can be covered using the built in functions.
If you don't know PDO, then why not read up the documentation and learn it. Its not rocket science and would be much better suited to large projects that the cryptic tosh that you posted in your first post.Quote:
Originally Posted by Y.P.Y
There is not reason, at all, why you need to waste your time creating a MySql wrapper, when it has already been done for you. I created one in the PHP5 OOP tutorials you see in my signature to demonstrate the object orientated tools available in PHP 5; again though, it is only for demonstration purposes but if you follow a tutorial and learn some good coding practices then the time you spend reinventing the wheel will be a lot better used.
:) thanks for expanding on my question.
There really is no need to create your own MySQL class, instead of that use the built in MySQLi class. It has all the mysql functions built in as methods so is a good OOP approach.
You will probably say well it doesn't do custom functionality that I need to do, thats easy just extend the class yourself and add your own functions or override the function you want to modify.
Example:
PHP Code:$db= new mysqli("localhost", "my_user", "my_password", "my_db");
/* check connection */
if (mysqli_connect_errno()) {
printf("Connect failed: %s\n", mysqli_connect_error());
exit();
}
$res = $db->query("SELECT * FROM customers");
echo "found customers: " . $db->affected_rows;
while($customer = $res->fetch_array())
{
print_r($customer);
}
ROFLMFAO......hahaha..... PML :lol:Quote:
Originally Posted by penagate