[RESOLVED] [2005] Login form code (no errors, does nothing)

Hi all,

I decided to rewrite my login code because my last one would only find the first record and anything after that first record (additional records) werent even found but they were in the database (mssql express).

I have a function that returns the connection string as follows:

vb Code:

Public Function ConString() As String
        Return "Data Source=.\SQLExpress;Initial Catalog=CorpScore;User Id=MyUsername;Password=MyPassword;"
    End Function

I then have a public object for my connection and then I assign the connection string as follows:

vb Code:

Public m_objCon As New SqlClient.SqlConnection(ConString)

When I enter in values in the username and password textboxes and click on the login button, it should do many checks and then log in if those checks are met for being valid. However, when i click on the login button, I get no errors and nothing happens at all. I even went to do a breakpoint and that isnt even executed. nothing happens at all. Please see code in the following three posts and advise if you see anything out of place. i am pretty new to .net so bear with me. the code is pretty long.....

vb Code:

Private Sub cmdLogin_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cmdLogin.Click
        'declare some datasets, data adapters and boolean flags
        Dim objAdminUserDs As New DataSet, objRegularUserDs As New DataSet
        Dim objAdminUserDa As New SqlClient.SqlDataAdapter, objRegularUserDa As New SqlClient.SqlDataAdapter
        Dim blnAdminUser, blnRegularUser, blnAccountLocked As Boolean
 
        'set up new sql commands and assign the sql query
        Dim objAdminUserCmd As New SqlClient.SqlCommand("SELECT * " & _
                                                        "FROM Users " & _
                                                        "WHERE IsAdmin = 1", m_objCon)
 
        Dim objRegularUserCmd As New SqlClient.SqlCommand("SELECT * " & _
                                                          "FROM Users " & _
                                                          "WHERE IsAdmin = 0", m_objCon)
 
        Try
            'open the connection
            m_objCon.Open()
 
            'clear the data sets and then fill the data adapters with the data sets
            objAdminUserDs.Clear()
            objAdminUserDa.Fill(objAdminUserDs)
 
            objRegularUserDs.Clear()
            objRegularUserDa.Fill(objRegularUserDs)
 
            'if there are more than zero rows in the admin dataset then
            If objAdminUserDs.Tables(0).Rows.Count > 0 Then
                'set the boolean
                blnAdminUser = True
                blnRegularUser = False
 
                'get the information for the administrator user
                With objAdminUserDs.Tables(0).Rows(0)
                    m_strUsername = .Item("Username").ToString
                    m_strPassword = .Item("Password").ToString
                    blnAccountLocked = CType(.Item("AccountLocked"), Boolean)
                    m_dteLastPasswordChange = .Item("LastPasswordChange")
                End With
                'if there are more than zero rows in the regular users data set then
            ElseIf objRegularUserDs.Tables(0).Rows.Count > 0 Then
                'set the boolean flag
                blnAdminUser = False
                blnRegularUser = True
 
                'get the information for the regular user
                With objRegularUserDs.Tables(0).Rows(0)
                    m_strUsername = .Item("Username").ToString
                    m_strPassword = .Item("Password").ToString
                    blnAccountLocked = CType(.Item("AccountLocked"), Boolean)
                    m_dteLastPasswordChange = .Item("LastPasswordChange")
                End With
            Else 'no user found
                'set the boolean flags to false and then show the messagebox
                blnAdminUser = False
                blnRegularUser = False
 
                If MessageBox.Show("Username and / or password mismatch." & vbNewLine & _
                                   "Please try again or contact support." & vbNewLine, _
                                   "Logon Mismatch", _
                                   MessageBoxButtons.OK, _
                                   MessageBoxIcon.Exclamation, _
                                   MessageBoxDefaultButton.Button1, _
                                   MessageBoxOptions.ServiceNotification, _
                                   False) = Windows.Forms.DialogResult.OK Then
 
                    'when the ok button is clicked, reset the login form and
                    'reset the cursor focus
                    ResetScreen(Me)
 
                    'put the cursor back into the username field
                    txtUsername.Focus()
                End If
            End If

vb Code:

'do something with any returned records
            'first calculate how many days old the password is and then assign
            'it to TimeSpan to get the difference in days
            dteChangePassword = dteTodaysDate - m_dteLastPasswordChange
 
            'if the password is equal to more than 30 days old and the account isnt
            'in locked status then show the change password form.  this will happen
            'every 30 days to increase security
            If dteChangePassword.Days.ToString > 30 _
            And Not blnAccountLocked _
            And txtUsername.Text.Trim = m_strUsername _
            And txtPassword.Text.Trim = m_strPassword Then
                Dim fChangePassword As New frmChangePassword
 
                With fChangePassword
                    'set the MDI parent as frmMain
                    .MdiParent = Me.MdiParent
                    'center the form
                    .Location = New Point((.MdiParent.Width - .Width) / 2, (.MdiParent.Height - .Height) / 2)
                    'now show the form
                    .Show()
                End With
            Else 'password doesnt need to be changed, proceed....
                'lets check to see if the user is a regular user and that the account isnt locked
                If blnRegularUser _
                And Not blnAccountLocked _
                And txtUsername.Text.Trim = m_strUsername _
                And txtPassword.Text.Trim = m_strPassword Then
                    'let the user in
                    LetUserIn()
                    'lets now check to see if the user is a regular user and the account is locked
                    'if the account is locked, advise the end user
                ElseIf blnRegularUser _
                And blnAccountLocked _
                And txtUsername.Text.Trim = m_strUsername _
                And txtPassword.Text.Trim = m_strPassword Then
                    If MessageBox.Show("We cannot log you into " & AppName() & "." & vbNewLine & vbNewLine & _
                                       "Reason: Account is in locked status." & vbNewLine & _
                                       "Solution: Contact an administrator.", _
                                       "Account Locked", _
                                       MessageBoxButtons.OK, _
                                       MessageBoxIcon.Exclamation, _
                                       MessageBoxDefaultButton.Button1, _
                                       MessageBoxOptions.ServiceNotification, _
                                       False) = Windows.Forms.DialogResult.OK Then
 
                        'reset the form
                        ResetScreen(Me)
 
                        'reset the cursor focus
                        txtUsername.Focus()
                    End If
                    'if the account for the user isnt locked but the username doesnt match
                ElseIf blnRegularUser _
                And Not blnAccountLocked _
                And Not txtUsername.Text.Trim = m_strUsername _
                And txtPassword.Text.Trim = m_strPassword Then
                    If MessageBox.Show("We cannot log you into " & AppName() & "." & vbNewLine & vbNewLine & _
                                       "Reason: Username mismatch." & vbNewLine & _
                                       "Solution: Try again.", _
                                       "Username Mismatch", _
                                       MessageBoxButtons.OK, _
                                       MessageBoxIcon.Exclamation, _
                                       MessageBoxDefaultButton.Button1, _
                                       MessageBoxOptions.ServiceNotification, _
                                       False) = Windows.Forms.DialogResult.OK Then
 
                        'reset the form
                        ResetScreen(Me)
 
                        'reset the cursor focus
                        txtUsername.Focus()
                    End If
                    'if the account for the user isnt locked but the password doesnt match
                ElseIf blnRegularUser _
                And Not blnAccountLocked _
                And txtUsername.Text.Trim = m_strUsername _
                And Not txtUsername.Text.Trim = m_strPassword Then
                    If MessageBox.Show("We cannot log you into " & AppName() & "." & vbNewLine & vbNewLine & _
                                       "Reason: Password mismatch." & vbNewLine & _
                                       "Solution: Try again.", _
                                       "Password Mismatch", _
                                       MessageBoxButtons.OK, _
                                       MessageBoxIcon.Exclamation, _
                                       MessageBoxDefaultButton.Button1, _
                                       MessageBoxOptions.ServiceNotification, _
                                       False) = Windows.Forms.DialogResult.OK Then
 
                        'reset the form
                        ResetScreen(Me)
 
                        'reset the cursor focus
                        txtUsername.Focus()
                    End If
                    'now lets check to see if the user is an administrator and if the account isnt locked

last part :)

vb Code:

ElseIf blnAdminUser _
                And Not blnAccountLocked _
                And txtUsername.Text.Trim = m_strUsername _
                And txtPassword.Text.Trim = m_strPassword Then
                    'let the user in
                    LetUserIn()
 
                    'now lets check to see if the user is an administrator and if the account is locked
                    'then ask the administrator if they want to reset the accounts locked status.  this 
                    'is a bad thing if there is only one admin account and the account is locked because  
                    'only admins can reset the locked status
                ElseIf blnAdminUser _
                And blnAccountLocked _
                And txtUsername.Text.Trim = m_strUsername _
                And txtPassword.Text.Trim = m_strPassword Then
                    If MessageBox.Show("We cannot log you into " & AppName() & "." & vbNewLine & vbNewLine & _
                                       "Reason: Account is in locked status." & vbNewLine & _
                                       "Solution: Account reset." & vbNewLine & vbNewLine & _
                                       "Would you like to reset your account?", _
                                       "Account Locked", _
                                       MessageBoxButtons.YesNo, _
                                       MessageBoxIcon.Question, _
                                       MessageBoxDefaultButton.Button1, _
                                       MessageBoxOptions.ServiceNotification, _
                                       False) = Windows.Forms.DialogResult.Yes Then
 
                        'reset the administrators account
                        'first select the administrator
                        Dim objSelectAdminAccountCmd As New SqlClient.SqlCommand("SELECT Username, AccountLocked " & _
                                                                                 "FROM Users " & _
                                                                                 "WHERE Username = '" & m_strUsername & "' " & _
                                                                                 "AND IsAdmin = 1 " & _
                                                                                 "AND AccountLocked = 1", m_objCon)
 
                        'execute the command
                        objSelectAdminAccountCmd.ExecuteNonQuery()
 
                        'now reset the account locked status from 1 to 0
                        Dim objResetAdminAccountCmd As New SqlClient.SqlCommand("UPDATE Users " & _
                                                                                "SET AccountLocked = 0 " & _
                                                                                "WHERE Username = '" & m_strUsername & "' " & _
                                                                                "AND IsAdmin = 1", m_objCon)
 
                        'execute the command
                        objResetAdminAccountCmd.ExecuteNonQuery()
                    End If
                    'now check to see if the user is an admin, the account isnt locked but the username doesnt match
                ElseIf blnAdminUser _
                And Not blnAccountLocked _
                And Not txtUsername.Text.Trim = m_strUsername _
                And txtPassword.Text.Trim = m_strPassword Then
                    If MessageBox.Show("We cannot log you into " & AppName() & "." & vbNewLine & vbNewLine & _
                                       "Reason: Username mismatch." & vbNewLine & _
                                       "Solution: Try again.", _
                                       "Username Mismatch", _
                                       MessageBoxButtons.OK, _
                                       MessageBoxIcon.Exclamation, _
                                       MessageBoxDefaultButton.Button1, _
                                       MessageBoxOptions.ServiceNotification, _
                                       False) = Windows.Forms.DialogResult.OK Then
 
                        'reset the form
                        ResetScreen(Me)
 
                        'reset the cursor focus
                        txtUsername.Focus()
                    End If
                    'now lets finally check to see if the user is an admin, the account isnt locked but the
                    'password doesnt match
                ElseIf blnAdminUser _
                And Not blnAccountLocked _
                And txtUsername.Text.Trim = m_strUsername _
                And Not txtPassword.Text.Trim = m_strPassword Then
                    If MessageBox.Show("We cannot log you into " & AppName() & "." & vbNewLine & vbNewLine & _
                                       "Reason: Password mismatch." & vbNewLine & _
                                       "Solution: Try again.", _
                                       "Password Mismatch", _
                                       MessageBoxButtons.OK, _
                                       MessageBoxIcon.Exclamation, _
                                       MessageBoxDefaultButton.Button1, _
                                       MessageBoxOptions.ServiceNotification, _
                                       False) = Windows.Forms.DialogResult.OK Then
 
                        'reset the form
                        ResetScreen(Me)
 
                        'reset the cursor focus
                        txtUsername.Focus()
                    End If
                End If
            End If
        Catch ex As Exception
 
        Finally
            'now destroy all the data sets and data adapaters
            objAdminUserDs.Dispose()
            objRegularUserDs.Dispose()
            objAdminUserDa.Dispose()
            objRegularUserDa.Dispose()
 
            'if the connection to the database is open, close it
            If m_objCon.State = ConnectionState.Open Then
                m_objCon.Close()
            End If
        End Try
    End Sub

i took out the try/catch block because that wasnt showing me errors and i think ive figured it out. time for more testing and will be back.

ok, i am getting very frustrated with .net right about now. no matter how i code this damned thing, it never sees past the first record!!!!!!

almost to the point of quitting this altogether. please advise what i am doing wrong. both the data sets are being populated with the SAME record regardless!!!!

complete code in txt file attachment. thanks in advance for any help.

vb Code:

Private Sub cmdLogin_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cmdLogin.Click
        'declare some datasets, data adapters and boolean flags
        Dim objAdminUserDs As New DataSet, objRegularUserDs As New DataSet
        Dim blnAdminUser, blnRegularUser, blnAccountLocked As Boolean
 
        'set up new sql commands and assign the sql query
        Dim strAdminUserSQL As String = "SELECT * " & _
                                        "FROM Users " & _
                                        "WHERE IsAdmin = '1'"
 
        Dim strRegularUserSQL As String = "SELECT * " & _
                                          "FROM Users " & _
                                          "WHERE IsAdmin = '0'"
 
        Dim objAdminUserDa As New SqlClient.SqlDataAdapter(strAdminUserSQL, m_objCon)
        Dim objRegularUserDa As New SqlClient.SqlDataAdapter(strRegularUserSQL, m_objCon)
 
        'Try
 
        'open the connection if its closed
        If m_objCon.State = ConnectionState.Closed Then
            m_objCon.Open()
        End If
 
        'clear the data sets and then fill the data adapters with the data sets
        objAdminUserDs.Clear()
        objAdminUserDa.Fill(objAdminUserDs)
 
        objRegularUserDs.Clear()
        objRegularUserDa.Fill(objRegularUserDs)
 
        'if there are more than zero rows in the admin dataset then
        If objAdminUserDs.Tables(0).Rows.Count > 0 Then
            'set the boolean
            blnAdminUser = True
            blnRegularUser = False
 
            'get the information for the administrator user
            With objAdminUserDs.Tables(0).Rows(0)
                m_strUsername = .Item("Username").ToString
                m_strPassword = .Item("Password").ToString
                blnAccountLocked = CType(.Item("AccountLocked"), Boolean)
                m_dteLastPasswordChange = .Item("LastPasswordChange")
            End With
            'if there are more than zero rows in the regular users data set then
        ElseIf objRegularUserDs.Tables(0).Rows.Count > 0 Then
            'set the boolean flag
            blnAdminUser = False
            blnRegularUser = True
 
            'get the information for the regular user
            With objRegularUserDs.Tables(0).Rows(0)
                m_strUsername = .Item("Username").ToString
                m_strPassword = .Item("Password").ToString
                blnAccountLocked = CType(.Item("AccountLocked"), Boolean)
                m_dteLastPasswordChange = .Item("LastPasswordChange")
            End With
        End If

Quote:

---

Originally Posted by BrailleSchool

i took out the try/catch block because that wasnt showing me errors and i think ive figured it out. time for more testing and will be back.

---

In fact, that is the first thing that catches my eye in the last bit of code. The Try...Catch block is there so if you do experience an error in your code, you can respond to it somehow. Even it is only to show a MessageBox with the error message, you should really put some code in your Catch block. Otherwise, as you've discovered, you won't get any information at all.

Don't remove the Try...Catch block. Just do something with the error when you catch it.

Quote:

---

Originally Posted by nmadd

In fact, that is the first thing that catches my eye in the last bit of code. The Try...Catch block is there so if you do experience an error in your code, you can respond to it somehow. Even it is only to show a MessageBox with the error message, you should really put some code in your Catch block. Otherwise, as you've discovered, you won't get any information at all.

Don't remove the Try...Catch block. Just do something with the error when you catch it.

---

i have totally rewritten this code from scratch 3 times now and doesnt matter how i do it, it only sees the first record and no other records. i currently have two users in the db. the first one can login without issue and the second one "cant be found" when in fact everything is typed in right. argh! (post #6 has additional info)

1) So you said you removed the Try...Catch block so you could see the errors. What where they?
2) Is your IsAdmin field a number field? There should not be single quotes around the 1 and 0 if that is so.

i even changed it to the following an no change. can only see the first user and the dataset isnt updated with any other records. ugh. i am totally lost with .net

vb Code:

'declare some datasets, data adapters and boolean flags
        Dim objUsersDs As New DataSet
        Dim blnAdminUser, blnRegularUser, blnCheckForAdmin, blnAccountLocked As Boolean
 
        'set up new sql commands and assign the sql query
        Dim strUsersSQL As String = "SELECT * " & _
                                    "FROM Users"
 
        Dim objUsersDa As New SqlClient.SqlDataAdapter(strUsersSQL, m_objCon)
 
        'Try
 
        'open the connection if its closed
        If m_objCon.State = ConnectionState.Closed Then
            m_objCon.Open()
        End If
 
        'clear the data set and then fill the data adapter with the data set
        objUsersDs.Clear()
        objUsersDa.Fill(objUsersDs)
 
        'if there are more than zero rows in the admin dataset then
        If objUsersDs.Tables(0).Rows.Count > 0 Then
            'get the information for the administrator user
            With objUsersDs.Tables(0).Rows(0)
                m_strUsername = .Item("Username").ToString
                m_strPassword = .Item("Password").ToString
                blnAccountLocked = CType(.Item("AccountLocked"), Boolean)
                m_dteLastPasswordChange = .Item("LastPasswordChange")
                blnCheckForAdmin = CType(.Item("IsAdmin"), Boolean)
            End With
 
            'set the boolean flag
            If blnCheckForAdmin Then
                blnAdminUser = True
                blnRegularUser = False
            Else
                blnAdminUser = False
                blnRegularUser = True
            End If
        End If

Quote:

---

Originally Posted by nmadd

1) So you said you removed the Try...Catch block so you could see the errors. What where they?
2) Is your IsAdmin field a number field? There should not be single quotes around the 1 and 0 if that is so.

---

IsAdmin is actually a varchar(5)

So you only get one record back when you are certain there is more than one record in your database table?

How many rows does this return?

Code:

---

        Dim strUsersSQL As String = "SELECT * " & _
                                    "FROM Users"
        Dim objUsersDa As New SqlClient.SqlDataAdapter(strUsersSQL, m_objCon)
        Dim dt As New DataTable()

        objUsersDa.Fill(dt)
        MessageBox.Show(dt.Rows.Count.ToString())

---

when the messagebox comes up, it has the number 2 in it.
i have gotten rid of the dataset and gone to datatable instead. whats the difference between the dataset and datatable?

still no change. first user has no issues. 2nd one cant be found. ugh

Quote:

---

Originally Posted by nmadd

So you only get one record back when you are certain there is more than one record in your database table?

How many rows does this return?

Code:

---

        Dim strUsersSQL As String = "SELECT * " & _
                                    "FROM Users"
        Dim objUsersDa As New SqlClient.SqlDataAdapter(strUsersSQL, m_objCon)
        Dim dt As New DataTable()

        objUsersDa.Fill(dt)
        MessageBox.Show(dt.Rows.Count.ToString())

---

---

now i changed my code and it gets the 2nd user but not the first. jeez!!!!!!!!!!

vb Code:

For Each objRows As DataRow In objUsersDt.Rows
                'get the information for the user
                With objRows
                    m_strUsername = .Item("Username").ToString
                    m_strPassword = .Item("Password").ToString
                    blnAccountLocked = CType(.Item("AccountLocked"), Boolean)
                    m_dteLastPasswordChange = .Item("LastPasswordChange")
                    blnCheckForAdmin = CType(.Item("IsAdmin"), Boolean)
                End With
            Next objRows

Quote:

---

Originally Posted by BrailleSchool

when the messagebox comes up, it has the number 2 in it.

---

That means there are two records there. That's what you want correct?

A DataSet is just a collection of DataTables. Check them both out on MSDN.

I imagine that you are getting the second one because you are overwriting the first when you loop through all of the rows in that table.

You need to step through this code and see what is going on. Slap a breakpoint on the first line in your block of code and actually walk through it and watch all of your variables and actually see how and when they change.

Ok. So, there is probably a better way to do this, but using something like your code, this works for me using the NorthWind database:

Code:

---

Public Class Form1

    Private _productName As String
    Private _productID As Integer

    Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click

        Dim conn As New OleDbConnection("Provider=Microsoft.Jet.OLEDB.4.0;Data Source=C:\Nwind.mdb;")
        Dim SQLString1 As String = _
            "SELECT ProductID, ProductName " & _
            "FROM Products " & _
            "WHERE ProductID = -1"
        Dim SQLString2 As String = _
            "SELECT ProductID, ProductName " & _
            "FROM Products " & _
            "WHERE ProductID = 2"
        Dim da1 As New OleDbDataAdapter(SQLString1, conn)
        Dim da2 As New OleDbDataAdapter(SQLString2, conn)

        Dim dt1 As New DataTable()
        Dim dt2 As New DataTable()
        da1.Fill(dt1)
        da2.Fill(dt2)

        If dt1.Rows.Count > dt2.Rows.Count Then
            _productID = CInt(dt1.Rows(0).Item("ProductID"))
            _productName = dt1.Rows(0).Item("ProductName").ToString()
        Else
            _productID = CInt(dt2.Rows(0).Item("ProductID"))
            _productName = dt2.Rows(0).Item("ProductName").ToString()
        End If

        MessageBox.Show( _
            _productID & _
            Environment.NewLine & _
            _productName)

    End Sub

End Class

---

thanks for that. i think i am making some headway here but gonna test further to make sure.

when an admin user logs into the system, they have complete access to everything. on form load, so far I have three menus that are disabled but when the admin user logs in, they need to be enabled. so in my frmLogin form, I have used DirectCast() but when I go to login as an admin, i get the following error in the screen shot.

i am not sure how to access controls on another form and had asked this question in the forum last week (didnt get a response though) but is this the way you access controls on another form or is there another way?

Thanks in advance and for your patience so far.

seemed to have fixed the problem by doing"

vb Code:

'enable the menus because admins have access to those
                With DirectCast(Me.MdiParent, frmMain)
                    .mnuUsers.Enabled = True
                    .mnuPrint.Enabled = True
                    .mnuSettings.Enabled = True
                End With
 
                'let the user in
                LetUserIn()