Printable View
Any Ideas why i getPHP Code:echo ' <a href="#" onclick="window.open(\[url]http://wahteversite.com/wahtever.php,\start\,\left=200,top=150,height=510,width=595,status\);[/url] return false;"><img src="/image.jpg" border="0"></a>
</ul>';
http://wahteversite.com/wahtever.php#
instead of http://wahteversite.com/wahtever.php
Thanks in advance
Excluding the [url] bbc tags
because you put a hash sign in the href attribute. why else?
Eww. Just eww.
echo()ing HTML code; using an event handler attribute; using window.open... I can't see anything good in that code, to be honest, and it's only one line. I shudder to think what the rest of it looks like.
HUH? Ok nowQuote:
Originally Posted by kows
LOL atleast your honest PenagateQuote:
Eww. Just eww.
Is this better?
PHP Code:echo "<a href=\"#\" onclick=\"javascript: window.open('http:mysite.com','start','left=200,top=150,height=510,width=595,status'); return false;\"><img src=\"/virus.jpg\" border=\"0\"></a></ul>";
If anything, it looks worse.
Here is a post by visualAd that explains the basics of code formatting in PHP. Outputting HTML using echo() is inefficient, less readable, and error-prone, as you need to escape various characters.
Don't open pop-up windows: it's grossly 90s, and will be blocked by just about all modern browsers, leading to a messy, interrupted user experience. In general, don't tamper with browsing models in any way; just use plain links to navigate between pages. If you want to show a pop-up on the page, use Javascript; but be sure to provide a vanilla HTML solution for those without Javascript enabled/supported.
Edit: Here's a post by yours truly with some more points about why outputting using echo() is bad.
Thanks for the reads. I see what your saying.
you asked why you were getting your URL with a hash at the end of it. "#" is the hash character. you made the href attribute a hash, thus why you're getting the hash character at the end of your URL.
Nevermind :sick:Quote:
Originally Posted by kows
you are acting like you have absolutly no idea what he is talking about!!Quote:
Originally Posted by Jazza
listen.
When you put a '#' in the 'href', then it reloads your page with the '#' at the end.
if you dont want that to happen, then put the javascript in place of the #HTML Code:<a href='#'>Link</a>
Like i did in post #4 :sick:
no..Quote:
Originally Posted by Jazza
I'm lost then. Its working just fine like this.
Keep in mind I'm new to all of this as seen aboveCode:echo "<a href=\"#\" onclick=\"javascript: window.open('http:mysite.com','start','left=200,top=150,height=510,width=595,status'); return false;\"><img src=\"/virus.jpg\" border=\"0\"></a></ul>";
http://www.vbforums.com/showthread.php?t=449182
See i also created the newb thread.
i can see that you new, you cant even spell n00b!Quote:
Originally Posted by Jazza
See my entire point!!!
n00b!
There's no need for that, either of you.
Jazza: Get rid of all the Javascript. Triggering script from links isn't a great idea at the best of times. Buttons (<button>) are more logical.
Assign event handlers from your script, which should be in an external .js file. Don't put them inline in the HTML, it's messy.
Also, href="#" is meaningless. href should always point to a page. If you must trigger script from a link, override the link action from your event handler by using e.preventDefault() (and whatever the IE equivalent is, I forget).
dclamp: Stop stirring.
Thanks for the info Penagate.
I learn something new everytime I come to this board.
dont forget! give rep to all who helped, and even thoes who didnt that much ;)Quote:
Originally Posted by Jazza
EDIT:
also, mark thread as "Resolved"
Sure thing boss.
I'll make the thread read "resolved"