QuoteSplit challenge

Make a Split function that skips quotes that contain the delimiter. Any opening quote will prevent delimeter from splitting the string.

Syntax:

VB Code:

Public Function QuoteSplit(ByRef Expression As String, Optional ByRef Delimiter As String = " ", _
    Optional ByVal Limit As Long, Optional ByVal Compare As VbCompareMethod = vbBinaryCompare) As String()
 
End Sub

This is a friendly challenge! This means that you can come up with entirely new suggestions, improve code posted earlier on and give suggestions to other participating in to the challenge.

Purpose is free: you can aim for shortness, you can aim for speed, you can aim for balancing code length and speed. Do what you like most :)


Edit!
You may drop Limit and Compare if you don't want to do them.

Also fixed Delimiter code (default = " ").

Edit #2
And now fixed the Delimiter spelling in the code.

I'll give it a go when I get some free time today. :cool:

[pedant]
can I suggest that Delimiter be spelt correctly?
[/pedant]

and I shall also have a go at knocking something up

here's my not-much-code-but-slow version (i didn't bother with Limit):

VB Code:

Public Function QuoteSplit(ByRef Expression As String, Optional ByRef Delimiter As String = " ", Optional ByVal Compare As VbCompareMethod = vbBinaryCompare) As String()
    Dim sParts() As String, N As Long
    sParts = Split(Expression, """")
    For N = 0 To UBound(sParts) Step 2
        sParts(N) = Replace(sParts(N), Delimiter, Delimiter & vbNullChar, , , Compare)
    Next N
    QuoteSplit = Split(Join(sParts, """"), Delimiter & vbNullChar)
End Function

you should provide some sort of example string Merri - this is the one i used:

sText = "1 2 3 4 ""5 5a"" 6 ""8 8a"" 7"

I'm tired so this code probably has bugs but I tested it a little. You'll probably find some if you test it.

I'll get back to it later after I get some sleep.

I provided a Start argument so you can choose where to start splitting from and also (hopefully) have the limit part working.

It's probably buggy as hell but here it is:

VB Code:

Option Explicit
 
'Count the number of instances a string appears within another string.
Private Function InStrCount(ByVal Start As Long, ByRef Expression As String, ByRef SearchFor As String, _
    Optional ByRef CompareMethod As VbCompareMethod = vbBinaryCompare) As Long
    
    If Start = 0 Then Exit Function
    If Start > Len(Expression) Then Exit Function
    
    Dim lonPos As Long, lonCount As Long
    
    lonPos = InStr(Start, Expression, SearchFor, CompareMethod)
    
    Do While lonPos > 0
        lonCount = lonCount + 1
        
        lonPos = InStr(lonPos + 1, Expression, SearchFor, CompareMethod)
    Loop
    
    InStrCount = lonCount
    
End Function
 
Public Function QuoteSplit(ByVal Start As Long, ByRef Expression As String, Optional ByRef Delimiter As String = " ", _
    Optional ByVal Limit As Long = -1, Optional ByVal CompareMethod As VbCompareMethod = vbBinaryCompare) As String()
    
    Dim lonLenEXP As Long
    
    lonLenEXP = Len(Expression)
    
    'Quick input checks...
    If lonLenEXP = 0 Then Exit Function     'Expression is empty.
    If Start = 0 Then Exit Function         'Start position is 0.
    If Start > lonLenEXP Then Exit Function 'Start position is greater than length of expression.
    
    Dim strRet() As String 'Return value.
    Dim lonPos As Long 'Position of delimiter.
    Dim lonPrevPos As Long 'Previous position of delimiter.
    Dim lon3Pos As Long 'Previous position of previous delimiter.
    Dim bytInQuote As Byte 'Currently in quotations?
    Dim lonQuoteCount As Long 'Number of quotes found.
    Dim lonCount As Long 'Number of delimiters found (used for Limit argument).
    Dim strTemp As String 'Temp string.
    Dim lonStart As Long 'Temp start position.
    Dim lonEnd As Long 'Temp long position.
    Dim lonLenDelim As Long 'Length of delimiter.
    Dim lonBnd As Long 'UBound of return value.
    Dim strTmpCheck As String
    
    lonLenDelim = Len(Delimiter)
    
    'Find first delimiter.
    lonPos = InStr(Start, Expression, Delimiter, CompareMethod)
    
    'Quick check.
    If lonPos = 0 Then GoTo NoDelimiter
    
    'Keep looping while we can still find the delimiter.
    Do While lonPos > 0
        
        'this,is,"a,test",abc
        
        '  "this,is",a,test
        If lonPrevPos = 0 Then 'This is the first delimiter.
            'Check if we're within quotes.
            strTemp = Mid$(Expression, 1, lonPos - 1)
            
            lonQuoteCount = InStrCount(1, strTemp, Chr$(34), vbBinaryCompare)
            
            If lonQuoteCount Mod 2 = 0 Then
                bytInQuote = 0
            Else
                bytInQuote = 1
            End If
            
            If bytInQuote = 0 Then
                'Not in quotes.
                ReDim strRet(0) As String
                
                strRet(0) = strTemp
                lonPrevPos = lonPos
                
                lonCount = lonCount + 1
                
                'Check if we're done.
                If lonCount = Limit Then
                    QuoteSplit = strRet()
                    
                    Erase strRet()
                    Exit Function
                End If
                
            Else
                lonPos = lonPos + 1
            End If
            
        Else 'This is NOT the first delimiter.
        
            'this,is,"a,test",abc
        
            '  "this,is",a,test
            
            'Get text from previous delimiter to this one.
            lonStart = lonPrevPos + lonLenDelim
            lonEnd = lonPos
            
            
            strTemp = Mid$(Expression, lonStart, lonEnd - lonStart)
            
            'Check if we're inside quotes.
            lonQuoteCount = InStrCount(1, strTemp, Chr$(34), vbBinaryCompare) + CLng(bytInQuote)
            
            If lonQuoteCount Mod 2 = 0 Then
                bytInQuote = 0
            Else
                bytInQuote = 1
            End If
            
            If bytInQuote = 0 Then
                'Not in quotes.
                lonBnd = UBound(strRet()) + 1
                
                ReDim Preserve strRet(0 To lonBnd) As String
                
                strRet(lonBnd) = strTemp
                
                lonCount = lonCount + 1
                lonPrevPos = lonPos
                
                'Check if we're done.
                If lonCount = Limit Then
                    QuoteSplit = strRet()
                    
                    Erase strRet()
                    Exit Function
                End If
                
            Else
                lonPrevPos = lonPrevPos + 1
            End If
        
        End If
        
        lonPos = InStr(lonPos + lonLenDelim, Expression, Delimiter, CompareMethod)
    Loop
    
    'Check for text at end of string.
    If lonPrevPos < lonLenEXP Then
        lonBnd = UBound(strRet()) + 1
        
        ReDim Preserve strRet(0 To lonBnd) As String
        
        strRet(lonBnd) = Mid$(Expression, lonPrevPos + lonLenDelim)
    End If
    
    QuoteSplit = strRet()
    
    Erase strRet()
    
    Exit Function
    
NoDelimiter:
    'Just return the text like the Split() function does.
    ReDim strRet(0) As String
    
    strRet(0) = Expression
    QuoteSplit = strRet()
    
    Erase strRet()
End Function
 
'Test the function.
Private Sub Command1_Click()
    Dim strBuffer() As String
    
    strBuffer() = QuoteSplit(1, Text1.Text, "**")
    
    Dim intLoop As Integer
    
    On Error Resume Next 'For UBound error.
    
    List1.Clear
    
    For intLoop = 0 To UBound(strBuffer())
        List1.AddItem strBuffer(intLoop)
    Next intLoop
    
End Sub

Here's mine:

Though I'm not the type to write fast code, so I can't say it's optimized for speed.... this is just how I would write this function if I would need it...

VB Code:

Option Explicit
 
Private Sub Form_Load()
    Dim sText As String
    sText = "1 2 3 4 ""5 5a"" 6 ""8 8a"" 7"
    
    Debug.Print Join(QuoteSplit(sText), vbNewLine)
    Debug.Print
    Debug.Print Join(QuoteSplit(sText, , 6), vbNewLine)
End Sub
 
Public Function QuoteSplit(ByRef Expression As String, Optional ByRef Delimeter As String = " ", _
    Optional ByVal Limit As Long, Optional ByVal Compare As VbCompareMethod = vbBinaryCompare) As String()
    
    Dim K As Long, InString As Boolean, LNDel As Long
    Dim RetStr() As String, Count As Long, ArrSize As Long
    Dim PrevPos As Long, Index As Long
    
    If Limit < 0 Then Limit = 0
    
    ' Count how many splits are neccessary
    LNDel = Len(Delimeter)
    K = 1
    Do Until K > Len(Expression)
        If InString Then
            If Mid$(Expression, K, 1) = """" Then InString = False
        Else
            If Mid$(Expression, K, 1) = """" Then
                InString = True
            ElseIf StrComp(Mid$(Expression, K, LNDel), Delimeter, Compare) = 0 Then
                Count = Count + 1
                K = K + LNDel - 1
            End If
        End If
        
        K = K + 1
    Loop
    
    ' Resize the array
    If Limit < Count And Limit > 0 Then
        ArrSize = Limit - 1
    Else
        ArrSize = Count
    End If
    
    ReDim RetStr(ArrSize)
    
    ' Fill in the parts/array
    PrevPos = 1
    K = 1
    Do Until K > Len(Expression)
        If InString Then
            If Mid$(Expression, K, 1) = """" Then InString = False
        Else
            If Mid$(Expression, K, 1) = """" Then
                InString = True
            ElseIf StrComp(Mid$(Expression, K, LNDel), Delimeter, Compare) = 0 Then
                If Index = ArrSize And Limit > 0 Then GoTo ReturnResult
                
                RetStr(Index) = Mid$(Expression, PrevPos, K - PrevPos)
                Index = Index + 1
                
                PrevPos = K + LNDel
                K = K + LNDel - 1
            End If
        End If
        
        K = K + 1
    Loop
    
ReturnResult:
    RetStr(ArrSize) = Mid$(Expression, PrevPos)
    
    QuoteSplit = RetStr
End Function

Did you write one Merri?

WHY THIS CODE ?

Private Sub Command1_click()
Dim sText As String
Dim sDelimiter as string
sText = text1.text ' ie What you typing in the TextBox1
sDelimiter = Text2.Text ' may be TWO ASTERICKS ** IN TEXTBOX2

Arr = Split(sText, sDelimiter , , vbBinaryCompare)
For i = 0 To UBound(Arr)
Debug.Print Arr(i)
Next i


End Sub

Quote:

---

Originally Posted by pearlxp

WHY THIS CODE ?

Private Sub Command1_click()
Dim sText As String
Dim sDelimiter as string
sText = text1.text ' ie What you typing in the TextBox1
sDelimiter = Text2.Text ' may be TWO ASTERICKS ** IN TEXTBOX2

Arr = Split(sText, sDelimiter , , vbBinaryCompare)
For i = 0 To UBound(Arr)
Debug.Print Arr(i)
Next i


End Sub

---

The point of this is to split a string, except for parts that are in quotes.

I also figured we were supposed to do it without using the Split() function...if not then I just made it a lot harder than it needs to be. :sick:

Quote:

---

Originally Posted by DigiRev

I also figured we were supposed to do it without using the Split() function...if not then I just made it a lot harder than it needs to be. :sick:

---

you can use the Split function if you want - that's what it's there for ;) - however, you'll be able to get faster results by not using it

are any timings comparisons going to be run on these, Merri?

Just woke up from 40000 seconds of sleep, but I'll do one. I guess I could go for the "absolute insane optimization" line, which I don't normally do because it isn't practical at all :) I first thought about doing the very simple and minimal one, but bushmobile did it already.

Anyways, I'll setup the timings first once I'm fully awake and have eat something.

Also fixed the Delimiter/Delimeter typo in the first post.

Quote:

---

Originally Posted by Merri

I guess I could go for the "absolute insane optimization" line, which I don't normally do because it isn't practical at all :)

---

what would be the point of the challenge if you're not going to open a can of whoop-ass on us? ;)

I try to do a maximum number of lines I can do for this simple task so you can laugh at how long it is :D It'll also take a few full work days to get it nice and good, a complete waste of time. The problem is that I'm unemployed at the moment as I'm waiting for getting an apartment in southern Finland to begin with a new job, so I have too much spare time... :)


We could do an efficiency rating, ie. number of characters of required code vs. final speed. For character counting all comments should be ignored as well as indenting spaces and line changes. If someone wants to code it, you're welcome to do it.

The current results are rather equal in compiled code, surprisingly the shortest code by bushmobile is also the fastest. Under IDE bushmobile's code wipes the floor. Attached is the test project I made.

DigiRev: you have an error in your function, you'll see the results when you download the speed comparison project attached below.


The test string I used:

VB Code:

TESTSTRING = " """ & Space$(20) & """ """ & Space$(20) & """ "

Edit!
Attachment removed, see newer post for the benchmarker.

Quote:

---

Originally Posted by Merri

DigiRev: you have an error in your function, you'll see the results when you download the speed comparison project attached below.


The test string I used:

VB Code:

TESTSTRING = " """ & Space$(20) & """ """ & Space$(20) & """ "

---

Yea I'm not surprised. :o

I'll have to take a look at it tomorrow when I have time.

Looking forward to seeing your version. :)

Warning! More related dangerous coding ideas coming!

I guess we should talk about how the function should work in error situatations. I'd recommend working like the Split function: just return a string array with one element containing the expression string.

However, there are troublesome cases when the delimiter contains quotes. My personal opinion is that if quotes are included in the delimiter, then delimiter is more important than quotes. So if a delimiter begins before a quote, then delimiter is more important and the quotes are ignored.

Sample:

• String: A "B" C (" A ""B"" C" on code)
• QuoteSplit by " (" """ in code)
• Result: QuoteSplit(0) = " A", QuoteSplit(1) = "B"" C"

Does this sound ok behavior? I guess we should look for more troublesome cases so we can make an extensive validation so someone who needs this kind of function can see if it does work for what he needs; although I believe these functions do work for the most common need: split by space, ignore spaces quotes. Should we instead of allowing any delimiter only go for space delimiter?

Then, should we add StripQuotes as an optional functionality? Meaning that quotes are removed from the final strings. I guess that is what is often wanted.

And then: QuoteJoin! Do the opposite, add quotes for strings that contain the delimiter in the passed string array.

Ok, I now did my own function, however it is not aiming for superior speed. Instead it is more of the common "this is how I'd have done it if someone requested it". I wanted to get something ready sooner than later. Will see if I feel like starting to code the extreme speed version today or not.

Attached is an upgraded project. Difference to what was before is that I put a generic code that swiches the testable function, one code to run all tests for all compatible functions. The downside is that all the testable functions must have identical syntax, so I could only make it work for bushmobile's and my own function for now. This means there is no support for Limit. These functions get additional validation test when ran.

vb Code:

Public Function Merri_QuoteSplit1(ByRef Expression As String, Optional ByRef Delimiter As String = " ", Optional ByVal Compare As VbCompareMethod = vbBinaryCompare) As String()
    Const QUOTE As String = """"
    Static lngEnd() As Long, lngEndUB As Long
    Dim strOut() As String
    Dim lngPosQ As Long, lngPosQE As Long, lngPos As Long, lngCount As Long
    Dim blnInQuote As Boolean, lngLen As Long
    ' remember delimiter length
    lngLen = Len(Delimiter)
    ' error detection
    If (lngLen = 0) Or (LenB(Expression) < LenB(Delimiter)) Then
        ReDim strOut(0)
        strOut(0) = Expression
        Merri_QuoteSplit1 = strOut
        Exit Function
    End If
    ' see if any quotes
    lngPosQ = InStr(Expression, QUOTE)
    ' no quotes? use Split!
    If lngPosQ < 1 Then
        Merri_QuoteSplit1 = Split(Expression, Delimiter, , Compare)
        Exit Function
    Else
        ' ending quote
        lngPosQE = InStr(lngPosQ + 1, Expression, QUOTE)
    End If
    ' see if any delimeters
    lngPos = InStr(1, Expression, Delimiter, Compare)
    If lngPosQE > 0 And lngPos > lngPosQ Then
        lngPos = InStr(lngPosQE + 1, Expression, Delimiter, Compare)
    End If
    ' no delimeter or all quoted? get out!
    If lngPos < 1 Or (lngPosQE <= 0 And lngPosQ < lngPos) Then
        ReDim strOut(0)
        strOut(0) = Expression
        Merri_QuoteSplit1 = strOut
        Exit Function
    End If
    ' reserve space if first time run
    If lngEndUB = 0 Then lngEndUB = 40: ReDim lngEnd(lngEndUB)
    ' then start off collecting indexes
    Do Until lngPos < 1
        ' need more space?
        If lngEndUB < lngCount Then
            lngEndUB = lngEndUB * 2
            ReDim Preserve lngEnd(lngEndUB)
        End If
        ' check if found within a quote
        blnInQuote = (lngPosQ < lngPos)
        If blnInQuote And (lngPos < lngPosQE) Then
            ' find next quote
            lngPosQ = InStr(lngPosQE + 1, Expression, QUOTE)
            ' found a next quote?
            If lngPosQ > 0 Then
                lngPosQE = InStr(lngPosQ + 1, Expression, QUOTE)
                If lngPosQE <= 0 Then
                    ' all remaining are belong to us
                    Exit Do
                Else
                    lngPos = InStr(lngPosQE + 1, Expression, Delimiter, Compare)
                End If
            Else
                ' nope, there are no more quotes to worry about
                lngPos = InStr(lngPosQE + 1, Expression, Delimiter, Compare)
                lngPosQE = lngPosQ
                Exit Do
            End If
        Else
            ' remember
            lngEnd(lngCount) = lngPos + lngLen - 1
            ' jump to next
            lngCount = lngCount + 1
            ' find next quote
            lngPosQ = InStr(lngPos + lngLen, Expression, QUOTE)
            ' look for next ending quote
            If lngPosQ > 0 Then
                lngPosQE = InStr(lngPosQ + 1, Expression, QUOTE)
                If lngPosQE > 0 Then
                    ' find next delimiter
                    lngPos = InStr(lngPosQE + 1, Expression, Delimiter, Compare)
                Else
                    ' all remaining are belong to us
                    Exit Do
                End If
            Else
                ' find next delimiter
                lngPos = InStr(lngPos + lngLen, Expression, Delimiter, Compare)
                ' huh, no quote found? we go out!
                Exit Do
            End If
        End If
    Loop
    ' see if we do unquoted work
    If (lngPosQ < 1) And (lngPos > 0) Then
        ' no quotes remaining, so we can work like this
        Do Until lngPos < 1
            ' need more space?
            If lngEndUB < lngCount Then
                lngEndUB = lngEndUB * 2
                ReDim Preserve lngEnd(lngEndUB)
            End If
            ' remember
            lngEnd(lngCount) = lngPos + lngLen - 1
            ' jump to next
            lngCount = lngCount + 1
            ' find next
            lngPos = InStr(lngPos + lngLen, Expression, Delimiter, Compare)
        Loop
    End If
    ' need more space?
    If lngEndUB < lngCount Then
        lngEndUB = lngEndUB * 2
        ReDim Preserve lngEnd(lngEndUB)
    End If
    ' add end of string
    lngEnd(lngCount) = Len(Expression) + lngLen
    ' reserve space for strings
    ReDim Preserve strOut(lngCount)
    ' get first item
    strOut(0) = Left$(Expression, lngEnd(0) - lngLen)
    ' get remaining items
    For lngPos = 1 To lngCount
        ' clip the one we need
        strOut(lngPos) = Mid$(Expression, lngEnd(lngPos - 1) + 1, lngEnd(lngPos) - lngEnd(lngPos - 1) - lngLen)
    Next lngPos
    ' oh my god, we are done!
    Merri_QuoteSplit1 = strOut
End Function

As you can see, bushmobile's code remains the best solution to give as a help despite this being the fastest :)

Quote:

---

Originally Posted by Merri

Make a Split function that skips quotes that contain the delimiter. Any opening quote will prevent delimeter from splitting the string.

Syntax:

VB Code:

Public Function QuoteSplit(ByRef Expression As String, Optional ByRef Delimiter As String = " ", _
    Optional ByVal Limit As Long, Optional ByVal Compare As VbCompareMethod = vbBinaryCompare) As String()
 
End Sub

This is a friendly challenge! This means that you can come up with entirely new suggestions, improve code posted earlier on and give suggestions to other participating in to the challenge.

Purpose is free: you can aim for shortness, you can aim for speed, you can aim for balancing code length and speed. Do what you like most :)


Edit!
You may drop Limit and Compare if you don't want to do them.

Also fixed Delimiter code (default = " ").

Edit #2
And now fixed the Delimiter spelling in the code.

---

The extreme version would need to be done in C++ with asm =P

If VB had bitwise operators, you could make a very fast one. This is very similar to what I'm doing in C, which is making a function that parses CGI input from a submit form or apache api. name=value&name=value2

Here is a little slip of that code. It's actually pretty cool in that this algorithm can test 4 bytes at a time and only have 1 branch for each value I'm testing for. The example in this code is the amp & sign.

Quote:

---

// A very simple Key=Value parser =P
int equal = 0x3d3d3d3d; // Mask for =
int amp = 0x26262626; // Mask for &
int teststr = 0;
int maskstr = 0;
unsigned int mask = 0;
int y, m, n;
int result = 4;

char * key = str;
char * value = 0;
char * buf = 0;

---

Code:

---


This is an example of what asm can do that C++ cannot do:
assign a int = char[3]. Note: always make sure you do this on a 4 byte boundry.


magic:          buf = &str[i];
                __asm push eax
                __asm push edx
                __asm mov eax, dword ptr buf
                __asm mov edx, [eax]    ; Get 4 charecters out of char *buf
                __asm mov teststr, edx  ;Assign to int teststr.
                __asm pop edx
                __asm pop eax

---

Code:

---

                maskstr = teststr ^ amp;
                mask = (maskstr & 0x7f7f7f7f) + 0x7f7f7f7f;
                mask = ~(mask | maskstr | 0x7f7f7f7f);
               
                y = -(mask >> 16);   
                m = (y >> 16) & 16;
                n = 16 - m;     
                mask = mask >> m;   
                     
                y = mask - 0x100;   
                m = (y >> 16) & 8;
                n = n + m;
                mask = mask << m;
 
                y = mask - 0x1000;   
                m = (y >> 16) & 4; 
                n = n + m;
                mask = mask << m;
 
                y = mask - 0x4000;   
                m = (y >> 16) & 2; 
                n = n + m;
                mask = mask << m;
 
                y = mask >> 14;       
                m = y & ~(y >> 1); 
               
                result = (n + 2 - m) >> 3;


                if(result != 4)
                {
                        // str[location of amp] = 0
                        str[(i + 3) - result] = 0;
                        m_data[key] = value;  // STL MAP

                        key = &str[((i+3) - result)+1];               
              }

---

You could do a variation of this code in c++ and call it from vb I guess. Maybe do 2 charecters at a time from vb.net

Yea with an algorithm that worked like this from visual basic.net, about 2 bytes at a time is all you could do. but that is still 1/2 the work =P

just make sure your not testing for a NULL charecter, it'll work for everything but that. If it's null then you can't xor it with a mask. which is the first line.

Basically what this algorithm does is read 4 bytes a time and load it into a integer. This integer is masked with a 4 byte mask of the character I'm testing for and then xored. That way if the value I'm testing for is located in the string, it'll be turned to a 00 NULL.

Thats what this line does:
int amp = 0x26262626; // Mask for &
maskstr = teststr ^ amp;

The next two lines just test to see if any of the 4 bytes have a null charecter.

mask = (maskstr & 0x7f7f7f7f) + 0x7f7f7f7f;
mask = ~(mask | maskstr | 0x7f7f7f7f);

The rest of the lines just find out exactly where that null byte is in the word. The only reason u do this, is to avoid all branching (any kind of compares). At the end of the day, I ended up with just 1 branch per character I'm testing for in every 4 byte read, in the case of a CGI, that would be 2... the amp and the equal. Which means my algorithm is doing 1/4 the amount of branching that a obvious algorithm would do: aka a if string[i]== '=' then.

I must point out to all those ASM bashes out there. When it comes to bit twiddling code, ASM is the clear winner! I couldn't get around using asm for this algorithm. To do so would have required me to load up the int 1 charecter at a time and shift 4 bytes each time, damn that.

I'll probably end up rewriting the entire algorithm in ASM just because C compliers are very mysterious when it comes to inserting inline asm. At the end of the day, if its important enough for asm to be inserted, it's important enough to do in asm.

Who says that? I say that! The useless programmer who spreads disinformation and demoralization wherever he goes.

peace

Nobody is up to challenge bushmobile's short code with something relatively short, yet a bit faster? Or can someone figure out even a shorter code?

Ummmm I think I did something similar before, under the name of ParseCSV (Not released tho), hangon - Ill dig out my code.
EDIT: Yes I did, Ill need to make the interface compatible - because ','s are hardcoded in.

Do you want to have another kind of challenge already? Atleast it seems nobody is interested in finding other solutions to the current one (besides Raedwulf).

I'll have to pass on this for a while, busy with exams. Since it is an open/not-too-serious challenge, i guess there shouldn't be any time limit. I'll post my solution when I get my exams over with, cheers :).

Have fun!

Not shorter but this is my version.

VB Code:

Public Function QuoteSplit(ByRef Expression As String, Optional ByRef Delimiter As String = " ", _
         Optional ByVal Compare As VbCompareMethod = vbBinaryCompare) As String()
    Dim lStr        As String, lAuxExp As String
    Dim lPos        As Long, lLastPos As Long
    Dim Process     As Boolean
        
    lPos = InStr(lPos + 1, Expression, """", Compare)
 
    If lPos = 0 Then
        QuoteSplit = Split(Expression, Delimiter, , Compare)
        Exit Function
    Else
        If (UBound(Split(Expression, """", , Compare)) + 1) Mod 2 = 0 Then
            MsgBox "Quote not closed", vbOKOnly + vbExclamation, "QuoteSplit"
            Exit Function
        End If
    End If
 
    lLastPos = 1
    Process = True
    lAuxExp = Expression
    While lPos
        If Process Then 'Like step 2 but using this boolean
            lStr = Mid$(Expression, lLastPos, lPos - lLastPos)
            Mid$(lAuxExp, lLastPos, lPos - lLastPos) = Replace(lStr, Delimiter, """") 'Replace single space with "
        End If
        lPos = lPos + 1
        lLastPos = lPos
        Process = Not Process
        lPos = InStr(lPos, Expression, """", Compare)
        
        If lPos = 0 And Process Then
            lPos = Len(Expression) + 1
            Process = True
        End If
    Wend
    QuoteSplit = Split(lAuxExp, """", , Compare)
End Function

Edit: Made some changes

Quote:

---

Originally Posted by jcis

It might still need some changes.

---

It does, because it doesn't pass any of the test strings in the validation and benchmark. Runs into an error. Too tired to think more than this.

Quote:

---

Originally Posted by Merri

Do you want to have another kind of challenge already? Atleast it seems nobody is interested in finding other solutions to the current one (besides Raedwulf).

---

I was thinking about an smart Replace, a Replace function that allows a Pattern in the Find parameter using a wildcard character, i think it could be useful.
Same Syntax than Replace:

VB Code:

Public Function SmartReplace(pExpression As String, _
                             pFind As String, _
                             pReplace As String, _
                             Optional pStart As Long = 1, _
                             Optional pCount As Long = -1, _
                             Optional pCompare As VbCompareMethod = vbBinaryCompare) As String

The character * could be used as wildcard, some examples:

pExpression = "abc abcd abcde AAA"
pFind = "abc*"
pReplace = "1"

String Returned: "1 1 1 AAA"
Blank spaces " " delimit replacing zones, even the wildcards can't go beyond them.

Another example:
pExpression = " abc cabc abzt"
pFind = " ab*"
pReplace = "P"

String Returned: "P cabcP".

Another..
pExpression = "Hi, how are you?"
pFind = "y*u"
pReplace = "they"

String Returned: "Hi, how are they?"

One more with numbers:
pExpression = "123 - 627 = 0"
pFind = "*2*"
pReplace = "5"

String Returned: "5 - 5 = 0"

This kind of smart Replace is native in Java but I never saw it in other programming languages, maybe Regex in .Net.
I know this doesn't seem very easy to do, but i think it would be useful, what do you people think?

I don't care as much about SmartReplace (and I don't see major trouble in it, unless one targets for speed), but how about MultiReplace? Many people seem to have problems with doing several replaces at once, so how about making it possible to pass string arrays as Find and Replace?

The difficulty is that it should always look for the next match in the string and replace that, ie. just doing multiple replaces in a row does not work.


So now we have SmartReplace and MultiReplace as a new challenge.

I like the SmartReplace idea.

How about functions so simulate the commands in Unix/Linux (for strings) ?

When I learned unix at school, I found the functions quite usefull.

You could find data by pattern, modify, replace... it was so long ago that I don't even remember the functions names, I just remember that they were quite usefull for manipulating strings...

So, we'll code SmartReplace as it already interests two persons :) At the moment I don't have the time though, but I'll see what is the situatation tomorrow or later on in this week. Finally opened a development site, it took less time to get it somewhat running than I expected, but getting it to final polished shape will take some time... and creating all the content will surely take my time. I thought about collecting a function library and putting results of these available there if people are willing to contribute :)

I'd be willing to give that a shot - maybe the thread should be put in the Contests forum this time - might get a bit more notice *shrug*

the SmartReplace might be a bit more of a challenge if it allowed other wildcards, ? and # for instance (and any other ones that people can think of)

what say you?

Also, we might want to add escape character, like \, to allow searching for the wildcards characters. So \\ would represent single \ character, \* would represent * character (and not a wildcard for any characters).

But I guess we could go for "optional", so a basic function could only support the wildcard * and function creator could tell which wildcards his function supports when he contributes his own solution. Of course, the more it supports, the better :)

* = none, or any number of characters
? = any one character
# = any one number
\ = escape character


Edit!
I now wrote a page about the last challenge to Devve: QuoteSplit Challenge. I chose bushmobile's and CVMichael's code there besides mine as these were the ones that worked as expected :)

Why not Regular Expression, search and replace?
Would be along the lines of your SmartReplace, but more practical?

As far as I know, a fast version of a regular expression is easily readily available via some object. Never used it, but seen a few threads about it. So that takes value out of doing it.

AFAIK, the regexp object is quite slow. I mean a trimmed down version - less bells and whistles, more speed.

If so, define what you mean. From what I know, regexp is always defined to function the same way, ie. regexps in Linux work the same as regexp in Windows. Maybe I should bother reading Wikipedia, but I guess I feel a bit lazy now.

Lets see how this code does!

I didn't get your "Merri" code to split correct don't know why; bushmobile's code is fantastic in a lot of aspects but:

I have chosen slightly different approach, lets make a piece of code that is serializable; in this way we can parse very large data; we don't use any extra memory.... We can tell how far we are - maybe even skip data...

my code is a bit shorter than other code; would normally wrap it in a class - for now i have some static variables; not so good but it shows how I believe is the best way to parse data.

I will not claim that I have verified it; but it works on my test-strings; performs OK in the IDE and really good compiled. TQ1 is returning an array, TQ2 is streaming the data....

Use:

Code:

---

  Dim i as long, a as string
  Do
    a = QuoteSplitStream(i,......)
    ' i tells you how far we are in the string
  loop until i=0

---

Code:

Code:

---

Public Function TOQ_QuoteSplitStream(ByRef i As Long, ByRef Expression As String, Optional ByRef Delimiter As String = " ", Optional ByVal Compare As VbCompareMethod = vbBinaryCompare) As String

  Dim j As Long
  Static k As Long, lE As Long, lD As Long
  If i = 0 Then k = 0: lE = Len(Expression): lD = Len(Delimiter)
  If k = 0 Then k = InStr(i + 1, Expression, """"): If k = 0 Then k = lE + 1
  If i + 1 = k Then
    j = InStr(i + 2, Expression, """")
    If j = 0 Then Err.Raise "Unclosed quote"
    TOQ_QuoteSplitStream = Mid$(Expression, i + 1, j - i) ' Including quotes, don't know it it makes sense to return the quotes
    j = j + lD ' Because we assume that a quote is followed by a delimiter
    k = 0
  Else
    j = InStr(i + 1, Expression, Delimiter, Compare)
    If j = i + 1 Then
      j = i + lD
      TOQ_QuoteSplitStream = ""
    Else
      If j = 0 Then j = lE + 1
      If k < j Then
        j = k + lD
        TOQ_QuoteSplitStream = Mid$(Expression, i + 1, j - i)
        k = 0
      Else
        TOQ_QuoteSplitStream = Mid$(Expression, i + 1, j - i - 1)
        j = j + lD - 1
      End If
    End If
  End If
  i = j
  If i >= lE Then i = 0
 
End Function

Public Function TOQ_QuoteSplit(ByRef Expression As String, Optional ByRef Delimiter As String = " ", Optional ByVal Compare As VbCompareMethod = vbBinaryCompare) As String()
 
  Const cGuess = 16
 
  Dim i As Long, j As Long, s() As String
  ReDim Preserve s(cGuess - 1)
  Do
    If j Mod cGuess = cGuess - 1 Then
      ReDim Preserve s(j + cGuess)
    End If
    s(j) = TOQ_QuoteSplitStream(i, Expression, Delimiter, Compare)
    j = j + 1
  Loop Until i = 0
  ReDim Preserve s(j - 1)
  TOQ_QuoteSplit = s
 
End Function

---

Benchmark IDE:

Expression:"1 2 3 4 "5 5a" 6 "8 8a" 7"
Delimiter:" "
Iterations:5000

Bushmobile = 125ms 8:|1|2||3|4|"5 5a"|6|"8 8a"|7|
Merri = 26ms 3:|1|2 3 4 "5 5a"|6 "8 8a"|7|
TOQ1 = 63ms 8:|1|2||3|4|"5 5a"|6|"8 8a"|7|
TOQ2 = 41ms

Expression:"1 2 3 4 "5 5a" 6 "8 8a" 71 2 3 4 "5 5a" 6 "8 8a" 71 2 3 4 "5 5a" 6 "8 8a" 71 2 3 4 "5 5a" 6 "8 8a" 71 2 3 4 "5 5a" 6 "8 8a" 7"
Delimiter:" "
Iterations:1000
Bushmobile = 92ms 35:|1|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|7|
Merri = 47ms 11:|1|2 3 4 "5 5a"|6 "8 8a"|71 2 3 4 "5 5a"|6 "8 8a"|71 2 3 4 "5 5a"|6 "8 8a"|71 2 3 4 "5 5a"|6 "8 8a"|71 2 3 4 "5 5a"|6 "8 8a"|7|
TOQ1 = 47ms 35:|1|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|7|
TOQ2 = 33ms

Expression:"1 2 3 4 "5 5a" 6 "8 8a" 7"
Delimiter:" "
Iterations:5000
Bushmobile = 116ms 7:|1|2|3|4|"5 5a"|6|"8 8a"|7|
Merri = 27ms 3:|1|2 3 4 "5 5a"|6 "8 8a"|7|
TOQ1 = 56ms 7:|1|2|3|4|"5 5a"|6|"8 8a"|7|
TOQ2 = 37ms

Benchmark Compiled:

Expression:"1 2 3 4 "5 5a" 6 "8 8a" 7"
Delimiter:" "
Iterations:5000
Bushmobile = 174ms 8:|1|2||3|4|"5 5a"|6|"8 8a"|7|
Merri = 14ms 3:|1|2 3 4 "5 5a"|6 "8 8a"|7|
TOQ1 = 33ms 8:|1|2||3|4|"5 5a"|6|"8 8a"|7|
TOQ2 = 15ms

Expression:"1 2 3 4 "5 5a" 6 "8 8a" 71 2 3 4 "5 5a" 6 "8 8a" 71 2 3 4 "5 5a" 6 "8 8a" 71 2 3 4 "5 5a" 6 "8 8a" 71 2 3 4 "5 5a" 6 "8 8a" 7"
Delimiter:" "
Iterations:1000
Bushmobile = 88ms 35:|1|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|7|
Merri = 9ms 11:|1|2 3 4 "5 5a"|6 "8 8a"|71 2 3 4 "5 5a"|6 "8 8a"|71 2 3 4 "5 5a"|6 "8 8a"|71 2 3 4 "5 5a"|6 "8 8a"|71 2 3 4 "5 5a"|6 "8 8a"|7|
TOQ1 = 25ms 35:|1|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|71|2|3|4|"5 5a"|6|"8 8a"|7|
TOQ2 = 13ms

Expression:"1 2 3 4 "5 5a" 6 "8 8a" 7"
Delimiter:" "
Iterations:5000
Bushmobile = 119ms 7:|1|2|3|4|"5 5a"|6|"8 8a"|7|
Merri = 14ms 3:|1|2 3 4 "5 5a"|6 "8 8a"|7|
TOQ1 = 29ms 7:|1|2|3|4|"5 5a"|6|"8 8a"|7|
TOQ2 = 14ms

TOQ4: your code works incorrectly, however your test string also triggered a bug in my code, which I've now fixed in the post where I originally submitted it.

Did someone mention C++?

This

Code:

---

template <typename C>
void csv_split(
        std::vector< std::basic_string<C> > &out,
        std::basic_string<C> const &in,
        std::basic_string<C> const &delimiter = ",",
        std::size_t limit = -1,
        std::basic_string<C> const &quoter = "\"'",
        std::basic_string<C> const &escaper = "\\")
{
        typedef boost::escaped_list_separator<C> sepfunc_t;
        typedef boost::tokenizer<sepfunc_t> tokenizer_t;
        tokenizer_t tok(in, sepfunc_t(escaper, delimiter, quoter));
        tokenizer_t from = tok.begin(), to = tok.end();
        while(from != to && limit > 0) {
                out.push_back(*from++);
        }
        while(from != to) {
                out.back().append(*from++);
        }
}

---

I've left out the casing parameter, as it doesn't make much sense: case-insensitive with respect to what? It could only be the separator, and how often do you use an alphabetic character as separator?

And if you really need to, this version accepts multiple separators (and quoters and escapers), so if you really need to split on 'a', regardless of case, you can simply do this:

Code:

---

std::vector<std::string> result;
csv_split(result, "ThisastringamustAbeAsplitaonAstuff", "Aa");

---

ok well i didn't test it at all, however, should be speedy:

Code:

---

Function ParseExceptQuotes(ByRef sText$, ByRef sParse$) As Variant

    Dim tba() As Byte, pba() As Byte, oba() As Byte, i&, j&, bq As Boolean, s$, u&, c&, uu&, opa
    tba = StrConv(sText, vbFromUnicode): pba = StrConv(sParse, vbFromUnicode)
    ReDim opa(1000) As String: c = -1
    u = UBound(tba): uu = UBound(pba)
   
    For i = 0 To u
        If tba(i) = 34 Then bq = Not bq
        If bq Then
            s = s & Chr$(tba(i))
        Else
            If tba(i) = pba(0) Then
                If uu > 1 Then
                    For j = 1 To uu
                        If tba(i + j) <> pba(j) Then Exit For
                    Next j
                End If
                If j = uu Then
                    ' found delimiter
                    c = c + 1
                    opa(c) = s
                    s = ""
                End If
                i = i + j
            Else
                s = s & Chr$(tba(i))
            End If
        End If
       
        If i = u Then
            opa(c + 1) = s
            ReDim Preserve opa(c + 1) As String
            ParseExceptQuotes = opa
        End If
    Next i
End Function

---

usage:

Code:

---

Private Sub Command1_Click()
Dim s$, a, i&
s = "1 2 3 4 ""5 5a"" 6 ""8 8a"" 7"
a = ParseExceptQuotes(s, " ")
For i = 0 To UBound(a)
    Debug.Print a(i)
Next i
End Sub

---

If you're in the "Don't bark if you have a dog to do it for you" school of thought, here's an example of this function using VS2005 VB.NET's built-in Text Parsing engine.

vb Code:

Public Function QuoteSplit(ByVal parseString As String, ByVal ParamArray Delimiters() As String) As String()
        Dim Results() As String
        Dim StringEncoding As New ASCIIEncoding()
        Using MemStream As New MemoryStream(StringEncoding.GetBytes(parseString))
            Using Parser As New FileIO.TextFieldParser(MemStream)
                Parser.Delimiters = Delimiters
                Parser.HasFieldsEnclosedInQuotes = True
                Results = Parser.ReadFields()
            End Using
        End Using
        Return Results
End Function