[Resolved]Comparing

VB Code:

Private Sub Command3_Click()
Dim pass1 As String
Dim pass2 As String
 
pass1 = Jorn
pass2 = Jorn
 
If pass1.Text = pass1 & pass2.Text = pass2 Then
MsgBox "Correct"
Else
MsgBox "Hahah"
 
End If
 
 
End Sub

This is basicly checking if the same text has been entered into two different boxes and when I press a button and they are the same I want a message to be shown
Why do I get the error invalid qualifier? vb highlights this bit
Private Sub Command3_Click()
help please

change this

VB Code:

If pass1.Text = pass1 & pass2.Text = pass2 Then

to

VB Code:

If pass1.Text = pass1 & pass2.Text  Then

Still says invalid qualifier

change this

VB Code:

pass1 = Jorn
pass2 = Jorn

to

VB Code:

pass1 = "Jorn"
pass2 = "Jorn"

Weird it still highlights the private sub and says invalid qualifier. Btw did you (write it for only 1 box before? because the same information needs to be in both boxes. probaly not but just checking)

Dim pass1 As String
pass1.Text???

I don't get what you're trying to do here... but:

VB Code:

If StrComp(pass1.Text, pass2.Text, vbTextCompare) = 0 Then
    MsgBox "Correct!"
Else
    MsgBox "Haha!"
End If

Quote:

---

Originally Posted by LeeMcCurry

Still says invalid qualifier

---

You need to use the form name to qualify the text box, i.e. formname.textboxname.text instead of textboxname.text

Also dim pass1 and pass2 as variants.

Ok Ill try explain it abit better. Also your code gavio still gives me invalid qualifier
I made 2 variables that both contain the information Jorn(I only really need one avriable actually). If I type jorn in both boxes and then I click a command button I want it to display correcy if they are the same and haha if they are not.

Quote:

---

Originally Posted by LeeMcCurry

Ok Ill try explain it abit better. Also your code gavio still gives me invalid qualifier
I made 2 variables that both contain the information Jorn(I only really need one avriable actually). If I type jorn in both boxes and then I click a command button I want it to display correcy if they are the same and haha if they are not.

---

Lee, this works for me in VB6:

VB Code:

Private Sub Command3_Click()
Dim pass1 As Variant
Dim pass2 As Variant
 
pass1 = "Jorn"
pass2 = "Jorn"
 
If frmTestForm.pass1.Text = pass1 & frmTestForm.pass2.Text = pass2 Then
MsgBox "Correct"
Else
MsgBox "Hahah"
 
End If
End Sub

My guess is that you have controls named pass1 and pass2. You should never declare variables with the same names as global objects. Also, there is really no need to set these to variables at all as the values are constant. Just use the constant values in your If expression. Finally, & is the concat operator not the bitwise And. Try something like this:

VB Code:

Private Sub Command3_Click()
    
    If (pass1.Text = "Jorn") And (pass2.Text = "Jorn") Then
        MsgBox "Correct"
    Else
        MsgBox "Hahah"
    End If
 
End Sub

Doing variants got rid of invalid qualifier thanks. However this bit
If cmdloops.pass1.Text = pass1 & frmcmdloops.pass2.Text = pass2 Then
From your previous code gets object required.

The above code gives not errors but for for some reason only shows the hahah box even though the information in both fields are the same

Quote:

---

Originally Posted by LeeMcCurry

Doing variants got rid of invalid qualifier thanks. However this bit
If cmdloops.pass1.Text = pass1 & frmcmdloops.pass2.Text = pass2 Then
From your previous code gets object required.

---

You're not using the same name; you're qualifying one with cmdloops.pass1.text and the other with frmcmdloops.pass2.text. Please copy and paste the entire code block from VB6.

Disruptive yours works too but its the same problem as with comintherns code.

Quote:

---

Originally Posted by LeeMcCurry

The above code gives not errors but for for some reason only shows the hahah box even though the information in both fields are the same

---

Is the text in the Textboxes trimmed? Also, this will be case sensitive.

Quote:

---

Originally Posted by LeeMcCurry

Disruptive yours works too but its the same problem as with comintherns code.

---

This also works for me with the added benefit of not having to deal with the hard-coded "Jorn" thing:

VB Code:

Private Sub Command3_Click()
 
 
If CriteriaSelection.pass1.Text = CriteriaSelection.pass2.Text Then
MsgBox "Correct"
Else
MsgBox "Hahah"
 
End If
 
 
End Sub

If this doesn't work then I dunno what else to suggest, especially without seeing the code. Be sure to change 'CriteriaSelection' to the name of the form you're using.

Trimmed? and yes I have been doing it case sensitive.

Quote:

---

Originally Posted by LeeMcCurry

Trimmed? and yes I have been doing it case sensitive.

---

VB Code:

If (Trim$(pass1.Text) = "Jorn") And (Trim$(pass2.Text) = "Jorn") Then

@disruptivehair: Based on the original code, it looks like there are 2 password Textboxes that have to match a single constant, not match each other.

Quote:

---

Originally Posted by disruptivehair

This also works for me with the added benefit of not having to deal with the hard-coded "Jorn" thing:

VB Code:

Private Sub Command3_Click()
 
 
If CriteriaSelection.pass1.Text = CriteriaSelection.pass2.Text Then
MsgBox "Correct"
Else
MsgBox "Hahah"
 
End If
 
 
End Sub

If this doesn't work then I dunno what else to suggest, especially without seeing the code. Be sure to change 'CriteriaSelection' to the name of the form you're using.

---

Worked brilliantly and less code too thanks.

Quote:

---

Originally Posted by Comintern

VB Code:

If (Trim$(pass1.Text) = "Jorn") And (Trim$(pass2.Text) = "Jorn") Then

@disruptivehair: Based on the original code, it looks like there are 2 password Textboxes that have to match a single constant, not match each other.

---

Alrighty then.

Quote:

---

Originally Posted by LeeMcCurry

Worked brilliantly and less code too thanks.

---

Goody! If you're happy with that then can you use the thread tools to mark the thread as resolved? Thanks!

yours works too comn, what does trim do though? onyl take abit of the code entered? and daniel why did I have to define the form like when I had to write cmdloops.pass2text or at least I think it was.

Quote:

---

Originally Posted by LeeMcCurry

yours works too comn, what does trim do though? onyl take abit of the code entered?

---

Trim removes all of the spaces from the right and left of the string.

Q:

Quote:

---

Originally Posted by LeeMcCurry

and daniel why did I have to define the form like when I had to write cmdloops.pass2text or at least I think it was.

---

A:

Quote:

---

Originally Posted by Comintern

My guess is that you have controls named pass1 and pass2. You should never declare variables with the same names as global objects.

---

When you have different variables with the same name, you have to find some way to explicitly let the compiler know which one is which. You can avoid this by keeping your variable names distinct.

So I have to avoid naming variables the same as objects? got it, I just cames up with the names pass1 and 2 because they were the same as the text boxes.

Quote:

---

Originally Posted by LeeMcCurry

So I have to avoid naming variables the same as objects? got it, I just cames up with the names pass1 and 2 because they were the same as the text boxes.

---

VB treats a form object like an object variable, it is just implicitly declared for you. Same thing for forms and modules. So, you should treat the controls on your form as if they were object instances (which they are). What VB6 does let you do is have variables with the same name and different scope. The controls on a form are all treated as form level variables, so it allows you to re-use names in more restrictive scopes. It's just a really bad idea because it makes it hard to tell what is going on in the code, and as you found out can lead to strange compiler errors. Check out the example below to see what I mean:

VB Code:

Option Explicit
 
Dim Command3 As String          'Will give a "Member already exists" error.
 
Private Sub Command3_Click()
 
    Dim Command3 As String      'Will not throw an error, but
                                'supercedes the object in this scope.
End Sub

Ah I see what you mean. Thanks alot for your help. I forgot these things easily so I have wrote them all down lol.