Building Classes

Printable View

Aug 28th, 2006, 05:45 PM
Jenova

1 Attachment(s)

Building Classes

At the moment i'm building a class for the System API's. It's not finished but i would like to know if i am doing it correctly, this is my first attempt at making a class, so can some one take a look at it and see if there is anything i could do to it to make it better or check for any mistakes. Just requesting feedback from it really.

Regards,

Jenova
Aug 28th, 2006, 05:55 PM
jcis

Re: Building Classes

There are many Types and APIs declared that you dont use.
Aug 28th, 2006, 06:01 PM
Jenova

Re: Building Classes

It's not finished yet, i just get the feeling that there is something wrong with it.

Jenova
Aug 28th, 2006, 06:28 PM
jeroen79

Re: Building Classes

Is there anything specific that you worry about?
Aug 28th, 2006, 06:31 PM
bushmobile

Re: Building Classes
in the GetOSVersionName function, udtVersionInfo.dwPlatformId is VER_PLATFORM_WIN32_WINDOWS for pre-NT systems, yet in IsWin95/98/ME you're checking it against VER_PLATFORM_WIN32_NT

also you should specify the clauses - just in case the computer decides to interpret it differently:
VB Code:
```
IsWin98 = [B]([/B]udtVersionInfo.dwPlatformId = [B]VER_PLATFORM_WIN32_WINDOWS)[/B] And _
                    [B]([/B]udtVersionInfo.dwMajorVersion = 4[b])[/b] And [B]([/B]udtVersionInfo.dwMinorVersion = 10[b])[/b]
```
use the typed version of the string manip functions, otherwise they return variants: Left$ Space$
Aug 29th, 2006, 05:59 AM
Jenova

Re: Building Classes

Great! Thanks alot, i was just worried about the class being useless or full of errors.