[RESOLVED] commondialog help

VB Code:

Private Sub cmdUpload_Click()
    With CommonDialog1
        .FileName = "*.xls"
        .Filter = "*.xls"
        .ShowOpen
        uploadfile = .FileName
    End With
    Save_BillingStatus
End Sub

how do i code if i try to open the dialogbox then i cancel the button?? it must not go to the Save_billingstatus function.. anyhelp?

Add error handling and set the .CancelError = True.

VB Code:

Private Sub cmdUpload_Click()
    With CommonDialog1
        .CancelError = True
        .FileName = "*.xls"
        .Filter = "Excel Files Only (*.xls)|*.xls"
        .ShowOpen
        uploadfile = .FileName
    End With
    Save_BillingStatus
    Exit Sub
MyError:
    If Err.Number <> cdlCancel Then
        MsgBox Err.Number & " - " & Err.Description
    End If
End Sub

Something Like this:

VB Code:

Private Sub cmdUpload_Click()
 
    On Error GoTo errHandler
    With CommonDialog1
 
       .Flags = cdlOFNHideReadOnly + cdlOFNOverwritePrompt + cdlOFNPathMustExist + cdlOFNNoReadOnlyReturn + cdlOFNLongNames + cdlOFNExplorer
       .CancelError = True
       .InitDir = DirName
       .Filename = "*.xls"
       .Filter = "Excel |*.xls"
       .ShowOpen
       uploadfile = .FileName
 
    End With
 
    Save_BillingStatus
 
    Exit Sub
    
errHandler:
 
    Select Case Err
    Case 32755 '  Dialog Cancelled
       DoEvents
    Case Else
       MsgBox "Unexpected error. Err " & Err & " : " & Error
    End Select
     
    End Sub

Since .Showopen is a Modal call you do not need to move the Save_BillingStatus function call. If the user clicks cancel it wil bypass that line and go straight to the error handler. ;)

Also, you have the logic backwards for the cancel as the poster wants it so it doesnt get executed if cancel is clicked. :)