Error handling/trapping.

I've set up some error handling, and I have a few questions
about the process I've used.

One of my questions is how do I kill the application after
logging the error?

The second question is more an issue of "the right way to
do things". Can the process I've used be improved upon?

And finally, is there ANY documentation out there for error
handling? I've looked around quite a bit and haven't found
anything greatly useful or enlightening.

Here's a sample of how I've set it up.

Code:

Public Function IshiFishi() On Error Goto Error Misc code here... Exit Function Error: WriteError Err.Number, Err.Description, "Additional info." End Function Sub WriteError(ErrNum As Integer, Desc As String, Message As String) If Message = "" Then Message = "An unknown error has occured." & vbCrLf Else Message = Message & vbCrLf Dim F As Integer F = FreeFile MsgBox ErrNum & vbCrLf & Message & Desc & vbCrLf & "Please contact your technical support group.", vbOKOnly, "ERROR!" UsageLog "User received error: " & Message Open "error.log" For Append As #F Print #F, ErrNum & " - " & Date$ & " - " & Time$ & " - " Print #F, Message Print #F, Desc Print #F, String$(60, "-") Close #F End Sub

1) Put the word end where you want to terminate the program. UNLESS it isn't your program you want to terminate.

2) I can't see how your code could be improved.

3) I'm sure if you look hard enough, or post another thread about errors, you'll get it.

Q1:

Unload Me

Q2:

It probably could be improved, but that is a good way. It is kind of hard to capture all errors.

Q3:

Hit F1 when the error comes up (the real error, not your generated one) and VB will tell you what it is.
If that don't help, search the MSDN site for the error.

Quote:

Originally posted by Dreamlax
1) Put the word end where you want to terminate the program. UNLESS it isn't your program you want to terminate.

Never use the END statement by itself. From the VB Help File (MSDN Library):

End Terminates execution. Never required by itself but may be placed anywhere in a procedure to close files opened with the Open statement and to clear variables.

I never knew about that. I thought End just ENDed your program. Oh well, I'll keep that in mind next time I write something.

Error Handling

This is how we implemented Error Handling. We also had EventLogger and TimeLogger Functions.

[code]
Public Sub ErrorLogger(ByVal Application As String, _
ByVal ModuleName As String, _
ByVal FunctionName As String, _
Optional ByVal UserID As String = "Unknown", _
Optional ByVal Parameters As String = "None", _
Optional ByVal ErrorMessage As String = "", _
Optional ByVal LogFilePath As String = "")

WriteToFile "Error", Application & vbTab & _
ModuleName & vbTab & _
FunctionName & vbTab & _
UserID & vbTab & _
Now & vbTab & _
Parameters & vbTab & _
ErrorMessage, LogFilePath
End Sub

Private Sub WriteToFile(ByVal sFileType As String, _
ByVal sInformation As String, _
Optional ByVal sLogFilePath As String = "")
On Error Resume Next
Dim fsoFobj As New FileSystemObject
Dim fsoFile
Dim sFileName As String
Dim sHeader As String
Dim bFileExist As Boolean
If Len(sLogFilePath) <= 0 Then sLogFilePath = App.Path & "\LogFiles"
If Not fsoFobj.FolderExists(sLogFilePath) Then fsoFobj.CreateFolder sLogFilePath
sFileName = sLogFilePath & "\" & sFileType & "Log" & Format(Now, "yyyy-mm-dd") & ".xls"
bFileExist = fsoFobj.FileExists(sFileName)
Set fsoFile = fsoFobj.OpenTextFile(sFileName, ForAppending, True, TristateFalse)
If Not bFileExist Then
Select Case sFileType
Case "Error": sHeader = "Application" & vbTab & "Module" & vbTab & "Function" & vbTab & "User" & vbTab & "Time" & vbTab & "Parameters" & vbTab & "ErrorMessage"
Case "Event": sHeader = "Application" & vbTab & "Module" & vbTab & "Function" & vbTab & "User" & vbTab & "Time" & vbTab & "Parameters"
Case "Time": sHeader = "Application" & vbTab & "ConnString" & vbTab & "SQL" & vbTab & "User" & vbTab & "Time" & vbTab & "ElapsedTime"
End Select
fsoFile.Write sHeader & vbCrLf
End If
fsoFile.Write sInformation & vbCrLf
fsoFile.Close
Set fsoFobj = Nothing
Set fsoFile = Nothing
End Sub

[code]

Error Handling

This is how we implemented Error Handling. We also had EventLogger and TimeLogger Functions.

[code]
Public Sub ErrorLogger(ByVal Application As String, _
ByVal ModuleName As String, _
ByVal FunctionName As String, _
Optional ByVal UserID As String = "Unknown", _
Optional ByVal Parameters As String = "None", _
Optional ByVal ErrorMessage As String = "", _
Optional ByVal LogFilePath As String = "")

WriteToFile "Error", Application & vbTab & _
ModuleName & vbTab & _
FunctionName & vbTab & _
UserID & vbTab & _
Now & vbTab & _
Parameters & vbTab & _
ErrorMessage, LogFilePath
End Sub

Private Sub WriteToFile(ByVal sFileType As String, _
ByVal sInformation As String, _
Optional ByVal sLogFilePath As String = "")
On Error Resume Next
Dim fsoFobj As New FileSystemObject
Dim fsoFile
Dim sFileName As String
Dim sHeader As String
Dim bFileExist As Boolean
If Len(sLogFilePath) <= 0 Then sLogFilePath = App.Path & "\LogFiles"
If Not fsoFobj.FolderExists(sLogFilePath) Then fsoFobj.CreateFolder sLogFilePath
sFileName = sLogFilePath & "\" & sFileType & "Log" & Format(Now, "yyyy-mm-dd") & ".xls"
bFileExist = fsoFobj.FileExists(sFileName)
Set fsoFile = fsoFobj.OpenTextFile(sFileName, ForAppending, True, TristateFalse)
If Not bFileExist Then
Select Case sFileType
Case "Error": sHeader = "Application" & vbTab & "Module" & vbTab & "Function" & vbTab & "User" & vbTab & "Time" & vbTab & "Parameters" & vbTab & "ErrorMessage"
Case "Event": sHeader = "Application" & vbTab & "Module" & vbTab & "Function" & vbTab & "User" & vbTab & "Time" & vbTab & "Parameters"
Case "Time": sHeader = "Application" & vbTab & "ConnString" & vbTab & "SQL" & vbTab & "User" & vbTab & "Time" & vbTab & "ElapsedTime"
End Select
fsoFile.Write sHeader & vbCrLf
End If
fsoFile.Write sInformation & vbCrLf
fsoFile.Close
Set fsoFobj = Nothing
Set fsoFile = Nothing
End Sub

[code]