[RESOLVED] Using exit method...

VB Code:

if condition then
     ...
end if

VB Code:

if not condition then
     exit sub
end if
 
...

Which of these 2 should we generally use? I don't know if it's just a matter of taste of using exit or not, but I like using it, although the code looks kind of messy if someone else reads it. Is there anything wrong about this?

I hardly use "Exit Sub" in my coding. Usually only when I have large structured subs that require to exit multiple times. Generally if my program is going to have a single if statement I go like:

VB Code:

Private Sub Test()
    If condition Then
        ...
    End If
End Sub

Then if the condition is false nothing would have happened in the first place.

Yes, but I don't like to have in my code too many imbricated if's, but I agree that too many exit's look confusing when someone else read the code. In my case noone will read the code I write now, but I will be a programmer soon, so I'd like to know how things should be done... :)
Thank you.

First off, typing Return is probably faster than typing exit sub.

Some people STRONGLY dislike having more than one exit point for a sub or function, but I am not in that camp. I think testing for a condition at the beginning of a sub and bailing out if the condition is not met is entirely understandable. If people would have a difficult time with what amounts to an assertion, then comment the heck out of it.

Quote:

---

Originally Posted by Shaggy Hiker

First off, typing Return is probably faster than typing exit sub.

---

You do have a point :)