[RESOLVED] Code is not working properly - please help

Hi

I have the following code which for some reason does not do what it should be doing. What it should do is, on the first button click it should upload to a database a selected file.

The second button should download the file again.

But for some reason when I upload a file which is 23,040 bytes, when i clikc the download button it will only return a file which is 15 bytes !!!

Can anyone see why this is happening?

THE CODE

VB Code:

Private Sub btnSave_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnSave.Click
        WriteDocumentToDB2("c:\test.doc")
    End Sub
 
    Private Sub WriteDocumentToDB2(ByVal sInDoc As String)
        Dim objDataSet As DataSet
        Dim objSQLCommand As SqlCommand
        Dim objSQLConnection As New SqlConnection("connection string")
        Dim strInsertCommand As String = "insert into table (name, phone, docs) values (@name, @phone, @docs)"
 
        Dim objFileStream As New FileStream(sInDoc, FileMode.OpenOrCreate, FileAccess.Read)
        Dim objDocBytes(objFileStream.Length) As Byte
 
        objFileStream.Read(objDocBytes, 0, objFileStream.Length)
        objFileStream.Close()
 
        objSQLCommand = New SqlCommand(strInsertCommand, objSQLConnection)
 
        objSQLCommand.Parameters.Add(New SqlParameter("@name", SqlDbType.NVarChar, 50))
        objSQLCommand.Parameters("@name").Value = "Some Value Here"
 
        objSQLCommand.Parameters.Add(New SqlParameter("@phone", SqlDbType.NVarChar, 50))
        objSQLCommand.Parameters("@phone").Value = "Some Value Here"
 
        objSQLCommand.Parameters.Add(New SqlParameter("@docs", SqlDbType.Image, 16))
        objSQLCommand.Parameters("@docs").Value = objDocBytes
 
        objSQLCommand.Connection.Open()
        objSQLCommand.ExecuteNonQuery()
        objSQLCommand.Connection.Close()
    End Sub
 
    Private Sub btnRestore_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnRestore.Click
        ReadDocumentFromDB2("c:\a\test.doc")
    End Sub
 
 
    Public Sub ReadDocumentFromDB2(ByVal sOutDoc As String)
        Dim objDataSet As DataSet
        Dim objSQLConnection As New SqlConnection("connection string")
        Dim objSQLDataAdapter As SqlDataAdapter
 
        Dim objSelectCommand As String = "select docs from table1 where id = @id"
 
        objSQLDataAdapter = New SqlDataAdapter(objSelectCommand, objSQLConnection)
 
        objSQLDataAdapter.SelectCommand.Parameters.Add(New SqlParameter("@id", SqlDbType.Int, 4))
        objSQLDataAdapter.SelectCommand.Parameters("@id").Value = "0"
 
        objDataSet = New DataSet
        objSQLDataAdapter.Fill(objDataSet)
 
        Dim objDataRow As DataRow
        objDataRow = objDataSet.Tables(0).Rows(0)
 
        Dim objDocBytes() As Byte
        objDocBytes = objDataRow("docs")
 
        Dim K As Long
        K = UBound(objDocBytes)
 
        Dim objFileStream As New FileStream(sOutDoc, FileMode.OpenOrCreate, FileAccess.Write)
        objFileStream.Write(objDocBytes, 0, K)
        objFileStream.Close()
        objFileStream = Nothing
    End Sub

I think you're telling it to limit the size. Here is the overload you are using to create a new SqlParameter object:

http://msdn.microsoft.com/library/de...ctortopic4.asp

And here is your code:

objSQLCommand.Parameters.Add(New SqlParameter("@docs", SqlDbType.Image, 16))

Perhaps you should eliminate the 16 there, as it may cause your file to truncate, and the other overload of the constructor takes only the parameter name and the data type, and leaves size undefined..

Bill

I have it set to 16 in the database also!

I have done something similar to this before but with images. But the images were not stored directly in the database! there got stored somewhere else on the server and only interested a reference in the database.

That was using the blob datatype.

16 what though, bytes? That number is pretty close to 15...

Bill

Yes that is what I was thinking, but when I did a similar program with images, i used the same 16 and it allowed me to upload and download huge image files because it did not store them directly in the database. it only stored a reference in the database using blob.

How do I do a similar thing here?

conipto - thanks, it was as simple as removing 16 from the code...