[resolved] Test Colour

hey me again ...


I got this code... All mine

VB Code:

Public Function TestColor(Colortest As Long) As String
Dim X As Long, Y As Long, test As Long, wndrect As RECT
GetWindowRect selWnd, wndrect
test = GetDC(selWnd)
TestColor = false
For Y = 0 To (wndrect.Bottom - wndrect.Top)
  For X = 0 To (wndrect.Right - wndrect.Left)
   If GetPixel(test, X, Y) = Colortest Then
      TestColor = true
      Exit Function
      Exit Function
    End If
  Next X
Next Y
End Function

but when i type in

if testcolor(255)=true then msgbox "Found it"


if doesnt find it... but if i put in false it does find it....

I know there is a color 255 on my screen but it all screws up....

ive tried reversin the true and false statements but it still works in reverse....

any help?

You should return a boolean, and you don't need 2 exit function

VB Code:

Public Function TestColor(Colortest As Long) As Boolean
Dim X As Long, Y As Long, test As Long, wndrect As RECT
GetWindowRect selWnd, wndrect
test = GetDC(selWnd)
TestColor = false
For Y = 0 To (wndrect.Bottom - wndrect.Top)
  For X = 0 To (wndrect.Right - wndrect.Left)
   If GetPixel(test, X, Y) = Colortest Then
      TestColor = true
      Exit Function
    End If
  Next X
Next Y
End Function

ok let me rephrase that... When i say to find something it wont find it .. eg returen false
even if it is true it just wont find it ... ?!?!

maybe this revision of mine could help

VB Code:

Public Function TestColor(Colortest As Long) As Boolean
    Dim X As Long, Y As Long, test As Long, wndrect As RECT
    GetWindowRect selWnd, wndrect
    test = GetDC(selWnd)
    For Y = 0 To (wndrect.Bottom - wndrect.Top)
        For X = 0 To (wndrect.Right - wndrect.Left)
            If GetPixel(test, X, Y) = Colortest Then
                TestColor = true
                Exit Function
            End If
        Next
    Next
    TestColor = false
End Function

i think a pixel is in form of RGB like this &HFFFFFF, which the middle byte is Green, and the left byte is either Red or Blue (sorry forget the sequence)
if you want to compare 255 (i consider you want to compare a white pixel) you should compare with &HFFFFFF rather than 255 decimal.

LOL i found out what the problem was...
i feel so ashamed


when i selected the current window it would find it fine... but when i said find colour then clicked on play it would only do it in the selected window... so i just made it go on a hotkey.. and it worked..


thanks to you all for your help ;)