[RESOLVED] improve my code

Hello:D
Ive only been learning VB for a half year now so my knowledge is very ...basic :bigyello: ..., and I wrote this code to color all html tags (all words within < and >) within a rich text box in red...but I know its quite bad and I knew it wouldnt work when having ALOT of code...so can some of you pro's please improve it? :D

Thanks

VB Code:

Dim start_p As Long
    Dim end_p As Long
    For a = 1 To Len(RT.Text)
        If Mid(RT.Text, a, 1) = "<" Then
            start_p = a
        End If
        If Mid(RT.Text, a, 1) = ">" Then
            end_p = a
            RT.SelStart = start_p - 1
            RT.SelLength = (end_p - start_p)
            RT.SelColor = RGB(255, 0, 0)
        End If
    Next a

its a bit faster using FIND (Built into rtb).. but also.. using the LockWindowUpdate API
will keep it from flickering or scrolling like crazy

VB Code:

Private Declare Function LockWindowUpdate Lib "user32" (ByVal hwndLock As Long) As Long
 
 
Private Sub Command1_Click()
LockWindowUpdate RTB1.hWnd
Dim Loc As Long
Loc = 0
Loc = RTB1.Find("<", Loc) + 1
Do
    RTB1.SelStart = Loc
    RTB1.SelLength = InStr(Loc, RTB1.Text, ">") - Loc - 1
    RTB1.SelColor = vbRed
    Loc = RTB1.Find("<", Loc) + 1
Loop While Loc > 0
RTB1.SelStart = 0
LockWindowUpdate 0&
End Sub

make a bool called "DoRed"

Then in your keypress event for your rich text box do this;

VB Code:

Private Sub RT_KeyPress(KeyAscii As Integer)
    If Chr(KeyAscii) = "<" Then DoRed = True
    If DoRed Then
        RT.SelColor = RGB(255, 0, 0)
    Else
        RT.SelColor = RGB(0, 0, 0)
    End If
    
    If Chr(KeyAscii) = ">" Then DoRed = False
    
End Sub

Thanks static, works like a charm..expect the LockWindowUpdate API...it says "object required" each time i try to run...any idea why?

Moved to code it better...

Quote:

---

Originally Posted by Atheist

Thanks static, works like a charm..expect the LockWindowUpdate API...it says "object required" each time i try to run...any idea why?

---

Did you change this line "RTB1.hWnd" to the name of your rich text box? Maybe you forgot to add the .hWnd after?