To be modified to best & easy code:

Printable View

1 Attachment(s)

Hi friends,

Could somebody make this code best & easy to understand. Do we really need the module for this project?

VB Code:

Public db As New ADODB.Connection
Public rs As New ADODB.Recordset
Public key As String
Public deptID As Integer
 
Public Sub data_connect()
Dim path As String
path = App.path & "\db40.mdb"
db.CursorLocation = adUseClient
db.Open "Provider=microsoft.jet.oledb.4.0;persist security info=false;data source=" & path & ";"
End Sub
 
Private Sub cmdadd_Click()
If cmdadd.Caption = "&Add" Then
    data_disable
    txt_unlock
    clear_txt
    cmdsave.Enabled = True
    cmdadd.Caption = "&Cancel"
    cmdedit.Enabled = False
    rs.MoveLast
    deptID = rs(0)
    deptID = deptID + 1
    cmddel.Enabled = False
Else
    data_enable
    txt_unlock
    clear_txt
    cmdsave.Enabled = False
    cmdadd.Caption = "&Add"
    cmdedit.Enabled = True
    cmddel.Enabled = True
    rs.Requery
    show_rec
End If
End Sub
 
Private Sub data_disable()
cmdprev.Enabled = False
cmdfirst.Enabled = False
cmdnext.Enabled = False
cmdlast.Enabled = False
End Sub
Private Sub data_disable()
cmdprev.Enabled = False
cmdfirst.Enabled = False
cmdnext.Enabled = False
cmdlast.Enabled = False
End Sub
 
Private Sub data_enable()
cmdprev.Enabled = True
cmdfirst.Enabled = True
cmdnext.Enabled = True
cmdlast.Enabled = True
End Sub
 
Private Sub cmddel_Click()
Dim ano As String
ano = MsgBox("Do you really want to delete this record?", vbYesNo, "Comfirm Delete?")
If ano = vbYes Then
    db.Execute "Delete from dept where cusnum like " & rs(0)
    rs.Requery
    show_rec
End If
End Sub
 
Private Sub cmdedit_Click()
data_disable
txt_unlock
key = Text1
cmdsave.Enabled = True
cmdedit.Enabled = False
cmdadd.Enabled = False
cmddel.Enabled = False
End Sub
 
Private Sub cmdexit_Click()
Unload Me
End Sub
 
Private Sub cmdfirst_Click()
On Error GoTo k
rs.MoveFirst
show_rec
Exit Sub 'you need this or the error trapping code
         'will ALWAYS execute
k:
If Err.Number = 3021 Then
End If
End Sub
 
Private Sub cmdlast_Click()
On Error GoTo last
rs.MoveLast
show_rec
Exit Sub 'you need this or the error trapping code
         'will ALWAYS execute
last:
If Err.Number = 3021 Then
End If
End Sub
 
Private Sub cmdnext_Click()
On Error GoTo cANTmOVEnEXT
rs.MoveNext
If rs.EOF Then
    rs.MoveLast
End If
show_rec
Exit Sub 'you need this or the error trapping code
         'will ALWAYS execute
cANTmOVEnEXT:
If Err.Number = 3021 Then
End If
End Sub
 
Private Sub cmdprev_Click()
On Error GoTo p
rs.MovePrevious
If rs.BOF Then
    rs.MoveFirst
End If
show_rec
Exit Sub 'you need this or the error trapping code
         'will ALWAYS execute
p:
If Err.Number = 3021 Then
End If
End Sub
 
Private Sub cmdsave_Click()
If cmdadd.Caption <> "&Cancel" Then
    txt_lock
    db.Execute "Update dept set Fname = '" & Text2 & "', Lname = '" & Text3 & "', Address = '" & Text4 & "', phonenum = '" & Text6 _
    & "', credlimit = '" & Text8 & "', emaddress = '" & text5 & "', deptname = '" & Text7 & "' where cusnum = " & key
    rs.Requery (1)
    cmdsave.Enabled = False
    cmdedit.Enabled = True
    cmdadd.Enabled = True
Else
    txt_lock
    db.Execute "Insert Into dept values (" & deptID & ",'" & Text2 & "','" & Text3 & "','" & Text4 & "','" & text5 & "','" & Text6 & "','" & Text7 & "','" & Text8 & "',0 ,0 )"
    rs.Requery (1)
    cmdsave.Enabled = False
    cmdedit.Enabled = True
    cmdadd.Enabled = True
    cmdadd.Caption = "Add"
End If
data_enable
 
DataGrid1.Refresh
cmddel.Enabled = True
End Sub
 
Private Sub DataGrid1_RowColChange(LastRow As Variant, ByVal LastCol As Integer)
On Error GoTo k
show_rec
Exit Sub 'you need this or the error trapping code
         'will ALWAYS execute
k:
If Err.Number = 6160 Then Exit Sub
End Sub
 
Private Sub fname_Click()
Call Text9_Change
Text9.SetFocus
End Sub
 
Private Sub Form_Load()
Call data_connect
rs.Open "Select * from dept", db
Set DataGrid1.DataSource = rs
show_rec
End Sub
Public Sub txt_lock()
Text1.Locked = True
Text2.Locked = True
Text3.Locked = True
Text4.Locked = True
text5.Locked = True
Text6.Locked = True
Text7.Locked = True
Text8.Locked = True
End Sub
 
Public Sub txt_unlock()
Text1.Locked = False
Text2.Locked = False
Text3.Locked = False
Text4.Locked = False
text5.Locked = False
Text6.Locked = False
Text7.Locked = False
Text8.Locked = False
End Sub
 
Public Sub show_rec()
Text1 = rs(0)
Text2 = rs(1)
Text3 = rs(2)
Text4 = rs(3)
text5 = rs(4)
Text6 = rs(5)
Text7 = rs(7)
Text8 = rs(6)
End Sub
 
Public Sub clear_txt()
Text1 = ""
Text2 = ""
Text3 = ""
Text4 = ""
text5 = ""
Text6 = ""
Text7 = ""
Text8 = ""
End Sub
 
Private Sub Form_Unload(Cancel As Integer)
Cancel = 1
End Sub
 
Private Sub lname_Click()
Call Text9_Change
Text9.SetFocus
End Sub
 
Private Sub text5_Change()
If rs.RecordCount <> 0 Then
    ctrl_unlock
Else
    ctrl_lock
End If
End Sub
Public Sub ctrl_lock()
data_disable
cmdadd.Enabled = False
cmdedit.Enabled = False
cmddel.Enabled = False
cmdexit.Enabled = False
End Sub
 
Public Sub ctrl_unlock()
data_enable
cmdadd.Enabled = True
cmdedit.Enabled = True
cmddel.Enabled = True
cmdexit.Enabled = True
End Sub
 
Private Sub Text9_Change()
rs.Close
If fname.Value = True Then
    rs.Open "Select * from dept where fname like '" & Text9 & "%'", db
    rs.Requery
Else
    rs.Open "Select * from dept where lname like '" & Text9 & "%'", db
    rs.Requery
End If
 
 
If rs.RecordCount <> 0 Then
    show_rec
Else
    clear_txt
End If
End Sub

Please clarify some doubts regarding the above project code:

1. do we really need to put the connection in a module?
2. why we need this txt5_change event?
3. why do we need the ID field in this project? If we want to remove it what changes we have to do in the code?
4.what is rs.query & rs.query(1)
5. how it can be easily understable for the beginners?

Could somebody modify this project code plz.

Edit: Added [vbcode][/vbcode] tags and indenting for clarity. - Hack

Oct 19th, 2005, 06:23 AM
Hack

Re: To be modified to best & easy code:

Quote:

Originally Posted by sweetie_2005

1. do we really need to put the connection in a module?

Modules and public variables are used when you need to access sub routines and functions throughout the entire project. If no such need exists, then you do not need a module. If such a need does exist, then you do need a module. Whether you use a module or not depends on the project.

Quote:

Originally Posted by sweetie_2005

2. why we need this txt5_change event?

I have no idea. It is your project. If you don't need it, why did you code it?

Quote:

Originally Posted by sweetie_2005

3. why do we need the ID field in this project? If we want to remove it what changes we have to do in the code?

Same answer as number 2.

Quote:

Originally Posted by sweetie_2005

4.what is rs.query & rs.query(1)

Looks like a recordset query.

Quote:

Originally Posted by sweetie_2005

5. how it can be easily understable for the beginners?

Document your code. For each line, put in a comment that tells us why are you doing what you are doing.
Oct 19th, 2005, 07:10 AM
penagate

Re: To be modified to best & easy code:

Never use "Public As New". It slows down your object access dramatically. Always use Set xxx = New yyy to instantiate an object and then Set xxx = Nothing once you no longer need it.
Oct 19th, 2005, 07:16 AM
sweetie_2005

Re: To be modified to best & easy code:

Quote:

Originally Posted by penagate

Never use "Public As New". It slows down your object access dramatically. Always use Set xxx = New yyy to instantiate an object and then Set xxx = Nothing once you no longer need it.

Thanks friend,

Since I am new to VB I need more easy examples to easily understand. The code was just copied from a program downloaded.

Regards,

sweetie_2005
Oct 19th, 2005, 07:40 AM
Static

Re: To be modified to best & easy code:

sweetie - I have a question for u..

Why did u post the entire code here when you already posted your project zipped in another thread? ;)

anyway.. is this your project? or are you taking it over?
if you are taking it over.. my suggestion would be to START OVER :). this project is not that far along and could be re-written easily. Then if you do the work u will know what is going on.. and as Hack said.. add comments to your code so you remember later whats going on.
also.. I left a few other suggestions in your other post..

[EDIT] This is a project u downloaded?? [/EDIT]
Oct 19th, 2005, 07:47 AM
sweetie_2005

Re: To be modified to best & easy code:

Quote:

Originally Posted by [A51g]Static

sweetie - I have a question for u..

[EDIT] This is a project u downloaded?? [/EDIT]

No, it is not my project. Just I want to get idea on coding. Some guys does not like to see an attachment so that I have copied the code.

Thanks for your comments.

Regards,

Sweetie_2005
Oct 19th, 2005, 07:49 AM
Hack

Re: To be modified to best & easy code:

Quote:

Originally Posted by sweetie_2005

No, it is not my project. Just I want to get idea on coding. Some guys does not like to see an attachment so that I have copied the code.

Thanks for your comments.

Regards,

Sweetie_2005

I would rather have the code. That way I don't clutter up my hard drive with zip files I've never ever use again. :thumb:
Oct 19th, 2005, 07:53 AM
Static

Re: To be modified to best & easy code:

good point.. of course.. its not THAT hard to highlight and delete :P lol (just pokin)