Elseif<Easy>

Just wondering why this consistently picks the same values, and how i can fix it:

VB Code:

cjb = Val(Left(ListView1.ListItems(pppp).ListSubItems(2).Text, Len(ListView1.ListItems(pppp).ListSubItems(2).Text) - 3))
            
            If cjb > 400 Then 
ListView1.ListItems(pppp).ListSubItems(4).Text = "Bad"
            
            Elseif cjb > 300 < 400 Then ListView1.ListItems(pppp).ListSubItems(4).Text = "Laggy"                    '< 400
            
            Elseif cjb > 200 < 300 Then ListView1.ListItems(pppp).ListSubItems(4).Text = "Decent" '< 300
            
            Elseif cjb > 100 < 200 Then ListView1.ListItems(pppp).ListSubItems(4).text = "Good"
            
           Elseif cjb < 100 Then ListView1.ListItems(pppp).ListSubItems(4).Text = "Great"

Try

Code:

---

Elseif cjb > 300 and cjb < 400 Then ListView1.ListItems(pppp).ListSubItems(4).Text = "Laggy"

---

Do the same for all the ElseIf

You need to evaluate the conditions completely, so to speak.

VB Code:

Elseif cjb > 300 And cjb < 400 Then 'blah, blah, blah...

Try a Select Case. Easier to read:

VB Code:

Option Explicit
 
Private Sub Form_Load()
  Select Case cjb
    Case Is > 399
      ListView1.ListItems(pppp).ListSubItems(4).Text = "Bad"
    Case 300 To 399
      ListView1.ListItems(pppp).ListSubItems(4).Text = "Laggy"                    '< 400
    Case 200 To 299
      ListView1.ListItems(pppp).ListSubItems(4).Text = "Decent" '< 300
    Case 100 To 199
      ListView1.ListItems(pppp).ListSubItems(4).Text = "Good"
    Case Else
      ListView1.ListItems(pppp).ListSubItems(4).Text = "Great"
  End Select
End Sub

Even though I agree with dg about using a Select Case statement I would just like to add that in the If statement you're using you don't need to check if a value is lower then another.

VB Code:

If cjb > 400 Then
    ListView1.ListItems(pppp).ListSubItems(4).Text = "Bad"
ElseIf cjb > 300 Then
    ListView1.ListItems(pppp).ListSubItems(4).Text = "Laggy"                    '
Elseif cjb > 200 Then
    ListView1.ListItems(pppp).ListSubItems(4).Text = "Decent" '< 300
Elseif cjb > 100 Then 
    ListView1.ListItems(pppp).ListSubItems(4).text = "Good"
Else
    ListView1.ListItems(pppp).ListSubItems(4).Text = "Great"
End If

Since the first if checks if cbj is over 400, if it's not then it will traverse into the first elseif statement and check if cbj is greater then 300 in which case you already know that it isn't greater then 400 because if it was the first If would have been true.

thanks dude :D