VB6 and ini file (RESOLVED)

heres what i have

in ini file

[email protected];
[email protected];
[email protected];

my program opens and counts the number of entrys ive got

<VBCODE>Private Sub cmdEmail_Click()
'************* open emails from file***********
Dim strEmailfile As String
Dim intFreeFile As Integer
Dim strEmails As String ' Read in

strEmailfile = App.Path & "\emails.ini"
'S:\Disaster Recovery\VB Program Backup\SBO Comm V1.7
'MsgBox (strEmailfile)
intFreeFile = FreeFile

On Error GoTo FinishCheck
Open strEmailfile For Input As #intFreeFile
Do While Not EOF(intFreeFile)
Line Input #intFreeFile, strEmails
intEmailCount = intEmailCount + 1
Loop
Close #intFreeFile

MsgBox ("Email Count = " & intEmailCount)

FinishCheck:
End Sub</VBCODE>

i want to modify this so it checks the entrys and only allows one, (so no dupicates), unsure of the best way to do this, but please keep this simple, dont want to be adding components and references, or any databases

ok thanks for your help in advance

check out the getprivateprofilestring and writeprivateprofilestring API's

I agree with the thought 'keep it simple'
But you should also have the thought 'keep it clean'
Don't handle messes, avoid them.
I don't think you posted the code that writes to the file ?
That is where we should prevent duplicates being written.

I reckon you should only be writing (and reading) INI files if you absolutely ABSOLUTELY have to.

The registry is probably a better bet and my preference is to use XML.

the program at present only reads the file

dont want to use API or XML, just need to simply read the address and count, just dont want duplicates like im getting at the min, any ideas?

or code i could test even if it just says what line the double is at or, misses counting them, not sure what is best

Just make a reference to the microsoft scripting runtime and use that instead of the DOS based openfile etc that you are using at present. The scripting runtime is much more feature rich.

This won't be fast.
As you read in each line, add it to a string.
But before adding each line, do a test to see if already in the string.

VB Code:

If InStr(1,sBuilding,sCandidate)=0 then
  Add to your count
  Concatenate sCandidate onto end of sBuilding
End If

Quote:

---

Originally Posted by RobCrombie

This won't be fast.
As you read in each line, add it to a string.
But before adding each line, do a test to see if already in the string.

VB Code:

If InStr(1,sBuilding,sCandidate)=0 then
  Add to your count
  Concatenate sCandidate onto end of sBuilding
End If

---

cool that seem to work, on neex thing i need to do then is just flag up which ones are doubles, can i put a message box in there?

have this

VB Code:

Open strEmailfile For Input As #intFreeFile
  Do While Not EOF(intFreeFile)
    Line Input #intFreeFile, strEmails
    
    If InStr(1, strTotalEmails, strEmails) = 0 Then
    'Add to your count
    'Concatenate sCandidate onto end of sBuilding
        intEmailCount = intEmailCount + 1
        strTotalEmails = strTotalEmails + strEmails
    End If
 
  Loop
Close #intFreeFile
 
MsgBox ("Email Count = " & intEmailCount)

VB Code:

Option Explicit
 
Private Sub cmdEmail_Click()
'************* open emails from file***********
 Dim strEmailfile As String
 Dim intFreeFile As Integer
 Dim strEmails As String ' Read in
 Dim strTotalEmails As String
 Dim strDuplicates As String
 Dim intEmailCount As Integer
 
  strEmailfile = App.Path & "\emails.ini"
  'S:\Disaster Recovery\VB Program Backup\SBO Comm V1.7
  'MsgBox (strEmailfile)
  intFreeFile = FreeFile
  
  On Error GoTo FinishCheck
  Open strEmailfile For Input As #intFreeFile
  Do While Not EOF(intFreeFile)
    Line Input #intFreeFile, strEmails
    
    If InStr(1, strTotalEmails, strEmails) = 0 Then
    'Add to your count
    'Concatenate sCandidate onto end of sBuilding
        intEmailCount = intEmailCount + 1
        strTotalEmails = strTotalEmails & strEmails
    Else
      strDuplicates = strDuplicates & vbCrLf & strEmails
    End If
 
  Loop
  Close #intFreeFile
 
  MsgBox ("Email Count = " & intEmailCount)
  If Len(strDuplicates) > 0 Then
    MsgBox strDuplicates, , " THESE WERE DUPLICATED"
  End If
FinishCheck:
End Sub

Hope that does the job.
I'm off to bed now (it's 4:08 AM)

ok thats works ok with a bit of jiging thats just what i want cheers