Else Without If

i know this is a really easy thing to fix, but i cant figure it out

I keep getting the method Else Without If, how can i fix it

VB Code:

If showf.Text = "" Then MsgBox ("You Cannot Leave The Show Command Empty")
ElseIf Hidef.Text = "" Then MsgBox ("You Cannot Leave The Hide Command Empty")
ElseIf Endf.Text = "" Then MsgBox ("You Cannot Leave The End Program Command Empty")
ElseIf Hidef.Text = "" Then MsgBox ("You Cannot Leave The Open Command Empty")
Else: Big Mess of Code
End If

Thanks

ParadoX

VB Code:

If showf.Text = "" Then
  MsgBox ("You Cannot Leave The Show Command Empty")
ElseIf Hidef.Text = "" Then
  MsgBox ("You Cannot Leave The Hide Command Empty")
ElseIf Endf.Text = "" Then
  MsgBox ("You Cannot Leave The End Program Command Empty")
ElseIf Hidef.Text = "" Then
  MsgBox ("You Cannot Leave The Open Command Empty")
Else
  'Big Mess of Code
End If

When there's a statement on the same line as the Then, that means something different to VB.

Also, the colon character ':' when used that way is designating a carraige return, or such.

VB Code:

For i = 1 to 10 : MsgBox i : Next

But its bad coding to use that style.

Better is:

VB Code:

Select Case True
    Case showf.Text = "" 
        MsgBox ("You Cannot Leave The Show Command Empty")
    Case Hidef.Text = "" 
        MsgBox ("You Cannot Leave The Hide Command Empty")
    Case Endf.Text = ""
       MsgBox ("You Cannot Leave The End Program Command Empty")
    Case Hidef.Text = "" 'BTW do you realize this is the same as the one above
       MsgBox ("You Cannot Leave The Open Command Empty")
    Case Else
      'Big Mess of Code
End Select

Also a user of your program could type a couple of spaces in one of your textboxes and that would pass your edit so you might want to change all of them like this one

VB Code:

Case Trim(showf.Text) = ""

There is one very interesting thing I noticed recently:

this sort of coding style (single line with colon) appears on our forum very frequently - I wonder if people that ask are all having the same instructor ???

Just curious ...

teacher being slick, so he can find copycats, prolly. could be he doesn't know the difference, but in this day and age, I would hope that isn't the case. (it was almost 30 years ago when I was in school)

iParadox


Try changing

Else: Big Mess of Code

to


Else
Big Mess of Code

or better yet

Else
Call Big Mess of Code


But for better coding I would suggest MartinLiss's Case Statement.