Invalid Cast Exception when Working with Inherited Classes

I know the title isn't exactly perfect, but the problem is hard to put it into words.

Basically what I have is two classes, they are almost perfectly the same, however the derrived class contains some extra elements such as in this example.

VB Code:

'Base Class
Public Class CarBase
 
    Protected _Colour As String
    Protected _Model As String
    Protected _Make As String
 
    Public Property Colour() As String
        Get
            Return _Colour
        End Get
        Set(ByVal Value As String)
            _Colour = Value
            Call ValueChanged()
        End Set
    End Property
    '
    'Property Repeated for the Model and the Make
 
    Protected Overridable Sub ValueChanged()
        'To be utilised in derrived classes
    End Sub
 
End Class
 
'Derrived Class
Public Class Car
    Inherits CarBase
 
    Private _ChangesMade As Boolean = False
 
    Protected Overrides Sub ValueChanged()
        _ChangesMade = True
    End Sub
 
    Public ReadOnly Property ChangesMade() As Boolean
        Get
            Return _ChangesMade
        End Get
    End Property
 
End Class

Now, the problem is that i have other functions and stuff to manipulate the classes, they all work from the base class (CarBase) because that stores just the data items, nothing to manipulate them etc. The derrived class really only adds the ChangesMade and some other properties that don't really affect the stored data.
I need both classes to be able to access the functions, but I don't really want to have to rewrite them to accomodate the two types of classes, some of which only return values so I can't overload them.

When I try to assign a CarBase to a variable of type Car, I get an Invalid Cast Exception. Is there anyway I can allow it to do this type of action w/o raising an exception? The IDE doesn't detect an error and neither does the compiler, so there must not be anything wrong with the syntax.

Hi

Why don't your manipulating function use the base class, why aren't you using your inherited class for all operations, you have the visibility set correctly so, Car.Colour should be fine in a Car Variable?

I maybe being dumb, but sometimes when someone puts up a wrong response other will help ;)

Maybe you could post your other functions so that we can see what you actually trying to do. Tis a little confusing!

Cheers

Danny

I used the base class because it's generic and can be used throughout the program as common code, it is used more often than the more specific derrived code.

I didn't quite understand what you ment by

Quote:

---

Why don't your manipulating function use the base class, why aren't you using your inherited class for all operations

---

but I do use the base class as the object for the functions.

After a bit more research, I found out that I can implicitly convert from a derrived class to the base class fine, but not the other way round which is annoying. The only way to go the other way is to specifically create a function that converts the base class into the derrived class.

There's gotta be a better way of doing it than that. Any ideas anyone?

Source=http://www.informit.com/articles/art...69107&seqNum=2

What i ment to type was:

Why do your manipulating function use the base class, why aren't you using your inherited class for all operations?

Sorry was typing fast as lunch was approaching!

Danny

It uses the base class, because it is this that is common, the derrived class isn't common, so making the functions based around it wouldn't be logical would it?

Hi

I am a little confused now, i thought you were using the car class and then wanting to access the CarBase class, in which case Car.(Some base class method) would be fine!

Can you paste some code?

Danny

Try copying the example in the first post and attempt todo this:

VB Code:

Dim CarB As New CarBase 'Creates a new instance of the Base Class
Dim CarD As Car 'Creates an object of the derrived class
 
CarD = CarB 'Tries to assign the instance of the base class to the derrived class object

If you do that, you should get an invalid cast exception, but if you reverse it, you will not get an exception and it will work fine.

I want it to do the former because as I stated, the derrived class contains some other methods to modify the data, so I want to give the derrived class, all the data from the base class so it can use it and work on it, because all the functions associated with the classes, use the base class i.e. loading, saving etc. I need to use the base class because it is used as a common object, and all the other features of the derrived class aren't needed to be common to all aspects of the solution.

Hi

Ok so here goes a stab in the dark not maybe the right way but here is how would understand it!

Your Base Class really isn't a base Class, it is the overall Car Class, having the changes made flag in the SubClass really doesn't have any benefit to your code!!

The example code you have given doesn't really warrant having a structure like you have, which maybe why your trying to do something that your not supposed to, (ie assiging a Base class to a derrived class).

Maybe its not the code that is the problem its your structure. I am assuming you have more code in the two classes, if so could i see it, it may make it easier to understand.

Will get to the bottom of this soon.

Danny

Posting more of the code won't help, because it's just more of the same that's there, all I really need is to do what i said previously. It's beginning to look more and more like it can't be done (after reading that article). If you havn't read that yet, have a read and you'll see where i'm getting at.

I gotta go, it's 2 in the morning here and i'm flat tired.

You can't cast a base class to a derived class because it is not the derived class. Inheritance is only one way and always goes from less to more. Think about the term 'Inheritance' can you inherit something back to someone who is dead?

The real issue here is that you should be creating an instance of the Car object then casting it to CarBase, send it through the functions and then convert it back to Car.

VB Code:

Dim c As New Car
Dim bc As CarBase = c 'This may have to be cast to CarBase via the CType function
Utilities.MyFunction(bc)
Utilities.MyOtherFunction(bc)
'now back to c
Msgbox(c.ChangesMade.ToString())

Actually after thinking some more about this I bet the IDE will not even force you to convert Car to CarBase when passing to the function, but I could be wrong (maybe I didn't have OptionStrict on but I usually do).

Ok Curiosity got the better of me and I tested it and there is no need to down cast even with Option Strict on. So this will work:

VB Code:

Dim c As New Car
        MsgBox(c.ChangesMade.ToString())
 
        Utilities.MyFunction(c)
        Utilities.MyOtherFunction(c)
        MsgBox(c.ChangesMade.ToString())

Also just for reference this is the rest of the code I used to test:

VB Code:

'Base Class
Public Class CarBase
 
    Protected _Colour As String
    Protected _Model As String
    Protected _Make As String
 
    Public Property Colour() As String
        Get
            Return _Colour
        End Get
        Set(ByVal Value As String)
            _Colour = Value
            Call ValueChanged()
        End Set
    End Property
    '
    'Property Repeated for the Model and the Make
 
    Protected Overridable Sub ValueChanged()
        'To be utilised in derrived classes
    End Sub
 
End Class
 
'Derrived Class
Public Class Car
    Inherits CarBase
 
    Private _ChangesMade As Boolean = False
 
    Protected Overrides Sub ValueChanged()
        _ChangesMade = True
    End Sub
 
    Public ReadOnly Property ChangesMade() As Boolean
        Get
            Return _ChangesMade
        End Get
    End Property
 
End Class
 
Public Class Utilities
 
    Public Shared Sub MyFunction(ByVal base As CarBase)
        base.Colour = "Red"
    End Sub
 
    Public Shared Function MyOtherFunction(ByVal base As CarBase) As String
        base.Colour &= "2"
        Return base.Colour
    End Function
 
End Class

Thanks Edneeis for you reply. I guess I have to understand now that there is no way to go up the tree, only down. I was also aware of the down casting which you pointed out (I think i mentioned that).

Anyway, I solved it by making a converter function in the derrived class, maybe not the best solution but cause all it has todo is transfer the properties values from one object to another, it was easy todo.

VB Code:

'Example
Public Class Car
 
'... All the other stuff
 
Public Shared Function Convert(SourceObject as CarBase) As Car
    Dim NewCar As New Car
 
    With NewCar
        .Colour = SourceObject.Colour
        'Etc with the other properties
    EndWith
 
    Return NewCar
End Sub