save open command

need help with the save & open command
have the following code

Private Sub Command1_Click()

CommonDialog1.Filter = "*.dat"
CommonDialog1.FilterIndex = 0
CommonDialog1.FileName = CommonDialog1.Filter
CommonDialog1.ShowSave

If CommonDialog1.FileName = "" Then Exit Sub
If InStr(CommonDialog1.FileName, "*") <> 0 Then Exit Sub

z$ = CommonDialog1.FileName
If InStrRev(z$, ".") = 0 Then z$ = z$ + ".dat"

If Dir(z$, vbArchive) <> "" Then
r = MsgBox("This file existe. Erase old data???", vbCritical Or vbYesNo, "File Existe")
If r <> 6 Then Exit Sub
End If

Close
Open z$ For Output As #1
For a = 1 To 6
Print #1, lblanswer(a)
Next
For a = 1 To 12
Print #1, txtdata(a)
Next
Close


please help

Where is the problem? What error occures?

I can't find any obvious errors. You don't need to check if the file exists if you use. And you don't need to check the file extension either:

VB Code:

CommonDialog1.Flags = cdlOFNOverwritePrompt + _
cdlOFNPathMustExist
CommonDialog1.DefaultExt = "dat"

nothing happens when i try to save
i am very knew to this have probably missed somthing dead simple

thanks for the replys

Why is the segment "Open Z$ for output..." enclosed in "Close?"

When happens when you print z$ to the immedaite window? Does it match whichever file you wanted it to?

What results do you expect to get?

How are the variable array's declared and do they contain data?

Looks like you just want to save info to a text file using the cdl and
basic file I/O Output statement. Something like this should suffice.

You filter was not setup correct and I'm not sure how you need
your text file, but...

VB Code:

Option Explicit
 
Private Sub Command1_Click()
 
    On Error GoTo No_Bugs
    
    Dim sStr As String
    
    CommonDialog1.CancelError = True
    CommonDialog1.Filter = "Data Files (*.dat)|*.dat"
    CommonDialog1.FilterIndex = 0
    CommonDialog1.Flags = cdlOFNOverwritePrompt Or cdlOFNPathMustExist Or cdlOFNHideReadOnly
    CommonDialog1.DefaultExt = "dat"
    CommonDialog1.ShowSave
    sStr = CommonDialog1.FileName
    
    Open sStr For Output As #1
        For a = 1 To 6
            Print #1, lblAnswer(a).Caption
        Next
        For a = 1 To 12
            Print #1, txtData(a).Text
        Next
    Close #1
    Exit Sub
    
No_Bugs:
    If Err.Number = 32755 Then
        'Canceled
    Else
        MsgBox Err.Number & " - " & Err.Description, vbOKOnly + vbExclamation
    End If
End Sub

Note: the flages need to be Or'ed together and not +'ed.

:)