Help with application.. Please [resolved]

Could someone please have a look at my code.
It may look a mess, tried to remark everything for ease of use.

What this does is opens a config file, reads data and acts upon what is in the config file.

If you have a look at the code then you will see what happens.

The problem:
The main problem that I'm having is where the application will hang when been waiting or running for more then 5 - 10 hours.

Many thanx in advance...

I didn't have a really close look at your code but one thing stood out:

In your sub LoadConfigFiles() try changing this line:

VB Code:

Do Until (strFinishTime = Time)
to
    Do Until (strFinishTime [color=red]>=[/color] Time)

The reason I suggest that, is because the finish time may pass while that loop statement is being executed so when the test is made again, ie (strFinishTime = Time) it will never be true.

Just a thought.

Thanks for that.

The problem is when it runs for more that 7-10 hours.

It maybe my wait routine but all looks ok.

If anyone has any ideas on how I can make this more efficient, ideas and help are much appreciated.

Thanx

hmmm ok...

VB Code:

Do Until (strFinishTime >= Time)

That should actually be:

VB Code:

Do Until (strFinishTime <= Time)

However, this is a bad way to do it.
What I would do is place all that code in a timer.
Then when you start the process, just enable the timer. Place the timer on say a 100ms interval.
This means that it won't scoff CPU time by looping constantly.
When ytou want the process to stop, just disable the time.

Does that help?

Ouch...just had another look at your code. You have a

VB Code:

Do 
   'shed loads of code
Loop

This puts you in an infinite loop, unless an error is raised :(
In fact, when an error is raised, you come out of the loop, then it sends you back into the loop with a Goto :confused:

I'd put this in a timer.

Woof

Thanx for that Wonka.. :wave:


For the wait routine, would something like

VB Code:

If strFinishTime = Time then
   Timer1.Enabled = False
Else
   Timer1.Enabled = True
End If

Can you also point out the other problem out for me?

Thanx

I'm still not having any joy!! My application is still hanging after 5 - 10 hours of waiting?


As anyone else got a wait routine that I could have a look at?

Please help... :confused:

Your coding is 110% wrong.

VB is not Basic or Pascal...you don't need infinate loops.

I'd have 2 timers.
One fires every 10 seconds to see what the time is and to see if it should start doing stuff.
If it does then it enables the other timer
if the time has run out then it should disable the other timer

You are using Goto's...BAD BAD BAD...do you realise how hard it is for us to debug an app like that :( Almost impossible.

I am almost sure that it's hanging coz of your infinate loops.

Post your current code that you have now.

Woka

Thanks for that Woka!!

I'm glad that I can take constructive critisim!! :eek:

Here is my latest app.

As you will see, it will be 10000000% wrong! But with the aid of coders like yourself, I may become better! Well you can hope eh?

Many thanks for your help with this.

ok...hmmm...just downloaded your project.

Just a few pointers:

VB Code:

Dim Woof As String, Moose As Long, Growl As Integer _
   , Sausage As Boolean blah blah blah

Can be VERY confusing for a number of reasons. 1st you are spanning multiple lines. It makes it hard to find where varibles are declared. Also you need to use naming conventions. Woof is a bad name for a varible :( A developer, like me, who is looking at your project has trouble debugging as they don't know what varibles types are...
What you should do is:

VB Code:

Dim strWoof     As String
Dim lngMoose    As Long
Dim intGrowl    As Integer
Dim blnSausage  As Boolean

As you can see this is MUCH easier to read, and also you cans ee what var type it is just by it's name.

Another point. Don't use the END command.
I'd remove this from your app. Do a search on VBF for why not to use it.

Also...I think I may have found what's causing it to hang.
All over your app you are doing stuff like:

VB Code:

Open strLogDir & "\" & strAppFile For Append As #3
'blah blah
Close #3

It works...but it is prone to problems.
What you should do is:

VB Code:

Dim intFile As Integer
   intFile = FreeFile
   Open strLogDir & "\" & strAppFile For Append As #intFile
   'blah blah
   Close #intFile

This could be the cause of your problems.

Hope this helps.

Woka

Thanks for the tips Woka, I've done what you've said and tidy'd up my coding. Renamed things like CSOURCE to strCSOURCE and so on.

Quote:

---

Your coding is 110% wrong.

VB is not Basic or Pascal...you don't need infinate loops.

I'd have 2 timers.
One fires every 10 seconds to see what the time is and to see if it should start doing stuff.
If it does then it enables the other timer
if the time has run out then it should disable the other timer

You are using Goto's...BAD BAD BAD...do you realise how hard it is for us to debug an app like that Almost impossible.

I am almost sure that it's hanging coz of your infinate loops.

Post your current code that you have now.

Woka

---

Could you show me what you mean. I may sound thick but until someone points out I feel it will stay the same.

Thanks

Place 2 timers on your form. tmrCheck and tmrDoStuff, then add the following:

VB Code:

Option Explicit
 
Private Sub Form_Load()
    With tmrDoStuff
        .Interval = 200
        .Enabled = False
    End With
    With tmrCheck
        .Interval = 1000
        .Enabled = True
    End With
End Sub
 
Private Sub tmrCheck_Timer()
Dim lngSec As Long
    lngSec = Format(Time, "s")
    If lngSec > 10 And lngSec < 50 Then
        If Not tmrDoStuff.Enabled Then
            tmrDoStuff.Enabled = True
        End If
    Else
        If tmrDoStuff.Enabled Then
            tmrDoStuff.Enabled = False
        End If
    End If
End Sub
 
Private Sub tmrDoStuff_Timer()
    Me.Caption = Time
End Sub

The tmrCheck checks to see if the seconds of the current time are between 10 and 50. If so then it enables the other timer, otherwise it disables the other timer.

Does that make sense?

Woka

This has now been resolved.

In the end, by frienfd who is a Delphi programmer told me what a timer is and does. I now fully understand timers. Phew!

I've put the entire loop and stuck it into a timer.
I got rid of the main

VB Code:

Do
    ....Lots and lots of other loops and stuff
Loop

When the user starts the application. The timer is enabled.
After all files are processed then timer is disabled.

The timer is on a interval of around 30seconds.

Many thanks for everyone that's helped me on this.

Chris