File.delete() not working [RESOLVED]

I have the following Java code for FTPing files. When the file errors out (happens if there is no source file to pull) I get a zero-byte file in the destination. I want to kill that zero-byte file, but this code does not do it.

Any ideas?

Code:

---

        public void doFTPGet() throws Exception
        {
                FtpClient fcMyFtp = new FtpClient();
                fcMyFtp.openServer(this.getHOST());
                fcMyFtp.login(this.getUID(), this.getPW());
               
//                reading a file:
                if(this.IS_BINARY)
                {
                        System.out.println("Getting Binary");
                        fcMyFtp.binary();       
                }
                else
                {
                        System.out.println("Getting ASCII");
                        fcMyFtp.ascii();
                }
                try
                {       
                        byte buffer[] = new byte[1000];
                        int len;
                        FileOutputStream fos = new
                        FileOutputStream( this.getLOCAL_FILE() );
                        TelnetInputStream  tis =        fcMyFtp.get(this.getREMOTE_FILE());
                        while( (len = tis.read(buffer)) != -1 )
                        {
                                fos.write(buffer,0,len);
                                //System.out.println("Reading");
                        }
                        tis.close();
                        fos.close();
                }
                catch( IOException e )
                {
                        e.printStackTrace();
                        //Delete the file
                        File filepath = new File(this.getLOCAL_FILE());
                        filepath.delete();
                        throw new Exception(e.toString());
                }

                System.out.println("Done!");
        }//End doFTPGet

---

Also, my file to delete is fully qualified with the path & filename...

If a FileNotFoundException is being thrown then i can't see how you would be able to delete the file since it fails to exist.

The file not found is from the source.

The file I want to delete is the zero-byte file that is created at the destination.

That's the problem with garbage collection. The FileOutputStream is still open, when the exception is thrown, and the explicit closing is skipped. Thus the file is still open and locked when you try to delete it.

Solution: declare fos outside the try block and explicitly close it in the catch block.

Won't compile that way because the compiler says that fos in the Catch may not have been initialized...

Code:

---

public void doFTPGet() throws Exception
{
        FtpClient fcMyFtp = new FtpClient();
        fcMyFtp.openServer(this.getHOST());
        fcMyFtp.login(this.getUID(), this.getPW());

        //reading a file:
        if(this.IS_BINARY)
        {
                System.out.println("Getting Binary");
                fcMyFtp.binary();       
        }
        else
        {
                System.out.println("Getting ASCII");
                fcMyFtp.ascii();
        }
        FileOutputStream fos;
        TelnetInputStream tis;
        try
        {       
                byte buffer[] = new byte[1000];
                int len;
                fos = new FileOutputStream( this.getLOCAL_FILE() );
                tis = fcMyFtp.get(this.getREMOTE_FILE());
                while( (len = tis.read(buffer)) != -1 )
                {
                        fos.write(buffer,0,len);
                        //System.out.println("Reading");
                }
                tis.close();
                fos.close();
        }
        catch( IOException e )
        {
                e.printStackTrace();
                //Delete the file
                fos.close();
                File filepath = new File(this.getLOCAL_FILE());
                filepath.delete();
                throw new Exception(e.toString());
        }

        System.out.println("Done!");
 }//End doFTPGet

---

Duh...

I changed

Code:

---

FileOutputStream fos;

---

to

Code:

---

FileOutputStream fos = new FileOutputStream( this.getLOCAL_FILE() );

---

and it works now.

Thanks!