sql query syntax in .net

i have the following query but it doesnt produe any results:

Me.OleDbCommand1.CommandText = "Select * From Emp Where Week='WeekString'"

is this valid syntax when using the WHERE part of a sql query

WeekString is just a string that takes its value from a txtbox on a form

Try this:

Me.OleDbCommand1.CommandText = "Select * From Emp Where Week='" & WeekString & "'"


BTW, this is the VB6 forum. We're old timers. :)

The frog's got the right idea, not that his code is easy to read or anything. You have to enclose a string argument in quotes, which he has done, but you have to look kind of close to count those hash marks. I prefer to surround it with the character code, just for readability, though it is slower to type:

"SELECT * FROM Emp WHERE Week = " & chr(34) & WeekString & chr(34)

instead of

"Select * From Emp Where Week='" & WeekString & "'"

I do not think so. According to him WeekString itself is a string and not a variable containing string. So what he is doing is correct.

"Select * from Blah Where Blah = 'WeekString' " is perfectly fine.

Quote:

---

Originally posted by techyspecy
I do not think so. According to him WeekString itself is a string and not a variable containing string. So what he is doing is correct.

"Select * from Blah Where Blah = 'WeekString' " is perfectly fine.

---

Quote:

---

WeekString is just a string that takes its value from a txtbox on a form

---

OK, so the principle is that if it is a string variable, then it must be enclosed in quotes with a technique like froggies (faster and easier) or mine (slower, but more legible). If it is not a variable, then you don't have to do that, as techyspecy stated.

That ought to answer the question with due thoroughness.

Good.

Now let's all live happily ever after.

Not quite EVER after, thanks. I'll get pretty wrinkly eventually.:D

thanks guys, both of what u have said makes interessting reading and gives me some stuff to think about.

FWIW, IMHO using parameters makes for cleaner and easier to read/maintain code. e.g.:

VB Code:

cmd.CommandText = "INSERT INTO RadioMessages (Unit, Code, Message, Call, [User]) VALUES (@Unit, @Code, @Message, @Call, @User)"
        cmd.Parameters.Clear()
        cmd.Parameters.Add("@Unit", unitGUID)
        cmd.Parameters.Add("@Code", code)
        cmd.Parameters.Add("@Message", message)
        cmd.Parameters.Add("@Call", callGUID)
        cmd.Parameters.Add("@User", user)
        cmd.ExecuteNonQuery()