Destructors

It's me again. :)

Having had trouble with converting an implimentation of a Linked List that stored integers to one that stored dynamic types, i decided to rewrite it from scratch.
I think i've layed out my code a lot better this time, but i'm not quite sure what i should put in the destructors.
I'd greatly appreciate it if someone could give me some pointers.

I've attached the cpp file, as it's a bit big to copy & paste (and the formatting's horrible).

P.s. at the moment it's a stack, but i'm probably gonna change it so it's a base class, and have stacks, queues and ordered lists inheriting from it (thanks again Cornedbee).

Much better :)

Head and Tail should be private or protected. protected if you want to derive classes.

If you derive publicly, make the destructor virtual.

The destructor's purpose is to make sure that no nodes remain. It should go through the list and delete every node.

The data parameters should be const references if you've learned about them. Both Pop and Poke have control paths that don't return values (if Head == NULL), they should do something. Return a default object or, better, throw an exception.

Ok, thanks for the comments/help. I'll make the changes and look up how to raise an exception.

Ok, i've tried to get inheritance to work and i think i'm almost there, except that i can't get the base class public methods (pop, poke and PrintList) to get recognized in the derived classes.

I've attached the .h file and i'd greatly appreciate it if someone could take a look.

Filename changed for portability (and Cornedbee :))

Would you mind using a filename that doesn't contain whitespace? Not only is whitespace bad for portability, it also screws my direct download-and-view system up.

Quote:

---

Originally posted by CornedBee
Would you mind using a filename that doesn't contain whitespace? Not only is whitespace bad for portability, it also screws my direct download-and-view system up.

---

It's the least i could do (see above post). :)

You don't need to redeclare the functions.

Do you meen i write the functions in the base class, then don't mention them in the derived classes?

If so i already tried that, but it didn't work i still get this error message (for each method):

error C2662: 'cLL<TData>::Pop' : cannot convert 'this' pointer from 'cStack<TData>' to 'cLL<TData> &' with [TData=int]

I don't think it should make a difference, but here's how i'm calling the functons:

Code:

---

#include "Linked List.h"

void main()
{
        cStack <int> aStack;
        aStack.Push(1);
        aStack.Push(2);
        aStack.Push(3);
        aStack.Pop();
        aStack.Push(aStack.Poke());
        aStack.PrintList();
}

---

Thanks for your help. :)

Try changing the subclass start lines from
template <class TData> class cQueue : public cLL
to
template <class TData> class cQueue : public cLL<TData>
.

I'm not sure if that changes anything, but it's worth a try.

Thanks for the reply. I made the change, but this time it gives the following errors:

When i call the stack's pop procedure, like this:

Code:

---

aStack.Pop();

---

It gives this error message:

error C2027: use of undefined type 'TData'

and when i call the push procedure (with the poke procedure) like this:

Code:

---

aStack.Push(aStack.Poke());

---

It gives this error message:

error C2664: 'cStack<TData>::Push' : cannot convert parameter 1 from 'TData' to 'const long' with [TData=long]


I think it's not replacing the <TData> with the appropriate data type in the inherited functions for some reason, but i'm not sure how to resolve this.

Bump!

This is somewhat absurd...

Can you upload the file with all recent changes? Then I can try compiling it myself.

And no spaces ;)

Sure, here's the linked list h file.

and here's the cpp with the calls in it.

I use MS Visual Studio .Net 2003 to try and compile it btw.

You have various minor errors and problems, but the prominent thing is that you misinterpreted my last advice.

Quote:

---

Try changing the subclass start lines from
template <class TData> class cQueue : public cLL
to
template <class TData> class cQueue : public cLL<TData>

---

Compare my final line to your result:

Code:

---

template <class TData> class cQueue : public cLL<class TData>

---

This is your main problem.

Others are that you catch the exceptions too early (doesn't make sense - why raise them in the first place if you do it that way?) and that your catches are not followed by blocks.

Cheers for your continued help!
I've been able to fix the my code as per your help, but i'm not sure what you meen about the exceptions. I had a look for a 'block' command but couldn't find anything.
I also had a look at MS' try...catch examples, but they all have examples where the carch directly follows the try, so i'm not sure where a good place for it to go would be.

Thanks for any reply. :)

Read up on the use of exceptions, how and especially why they get used and you'll see what I mean.

As for the block thing, all I'm saying is that VC++ gives me an error for

Code:

---

try {
  ...
} catch(type)
  cerr << "Error";

---

but not for

Code:

---

try {
  ...
} catch(type) {
  cerr << "Error";
}

---

Ok, i'll have a look for the use of exceptions and why they're used.
I misunderstood what you ment about a 'block' statement, but managed to figure the errors out anyway. Thanks for the clarification though.

Your help is much appreciated.