Could someone tell me what's Wrong With This Code?

Code:

---

Friend Sub Read_Script_Template()
    Dim Handle As Integer
   
    If Len(Dir$(mvarSCRIPT_TEMPLATE_NAME)) = 0 Then
        Err.Raise 53  ' File not found
    End If
   
    ' open in binary mode
    Handle = FreeFile
    Open mvarSCRIPT_TEMPLATE_NAME$ For Binary As #Handle
    ' read the string and close the file
    SCRIPT_TEMPLATE = Space$(LOF(Handle))
    Get #Handle, , SCRIPT_TEMPLATE
    Close #Handle
   
    MsgBox SCRIPT_TEMPLATE

End Sub

---

Well, without knowing what you are expecting, or what you got that you didn't expect, its hard to say.

nothing comes up in the message box...

but I don't get any errors or anything....so it finds the file....but it doesn't seem to read it at all...

You need to loop through it... I believe......

VB Code:

Do While Not EOF
   'Your Code here
Loop

shouldnt it be

VB Code:

Get #Handle, 1 , SCRIPT_TEMPLATE

No, his File I/O code is just fine.
I would imagine that perhaps an error is happening, and it is being passed up to the called procedure which has On Error Resume Next in place, or the error is just being ignored.

Try

Dim SCRIPT_TEMPLATE As String

in your Sub

Quote:

---

Originally posted by Bregalad
Try

Dim SCRIPT_TEMPLATE As String

in your Sub

---

It, along with the other variables, could be declared as module level variables - or Option Explicit may not be turned on.

Yes, but
Dim SCRIPT_TEMPLATE
or
Dim SCRIPT_TEMPLATE As Variant ' or something else
would cause an error

Ahhh very true. I didn't know the Get keyword wouldn't work with variants. Good call :)

It is a module level declaration, declared Private as a string...and I am PRETTY sure the option explicit is there (I am at work now, so i can't check)....but i'll look when i get home!