What's wrong with this code? [Resolved]

Dim intPress As Integer, strPass As String, x As Boolean

Private Sub Command1_Click()
strPass = Text1.Text
If PassCheck() = True Then
intPress = MsgBox("Correct Password!", vbExclamation, "The result is:")
Else
intPress = MsgBox("Incorrect Password", vbCritical, "The result is:")
End If
End Sub

Private Function PassCheck(strPass As String) As Boolean
PassCheck = False
If strPass = "loser" Then
PassCheck = True
End Function

Why dont you tell us what happens?

You're not passing anything (namely a string) to SUB PassCheck().

I get a compile error when the code gets to the PassCheck() function, it says "Argument not optional". I am practicing with functions, still learning of course, and I can't figure out why its not working.

CyberJar got it. But you will have another error too unless you close that If block with an End If in PassCheck

strPass is being passed to PassCheck as an argument, the the value of PassCheck is returned in the form of a boolean to be used in the click procedure.

At least thats what I thought I coded, what do you think?

no, its not what you coded

Code:

---


If PassCheck() = True Then

---

you didnt put in the arguement

So I have to have it like this :

PassCheck(strPass as string)

in both the calling and called procedures?

You are getting that error because you are not filling the required vailables. note that you have declared this..

VB Code:

Private Function PassCheck(strPass As String) As Boolean
PassCheck = False
If strPass = "loser" Then
PassCheck = True
End Function

But only pass this..

VB Code:

if pass check() = true then

You need to either change you function to this

VB Code:

Private Function PassCheck(optional strPass As String) As Boolean

to allow for not using a variable when you call it or you need to supply a value to strPass then you call the function..

VB Code:

if PassCheck(X) = true then

Rudy

No. just strPass

Thanks guys, I believe I have it now.

I fixed the code as per your instructions, but for learning sake, is this the best way to code this? I just want to be sure I am coding the right way.
---------------------------------------------------------------------------------
Dim intPress As Integer, strPass As String, x As Boolean

Private Sub Command1_Click()
strPass = Text1.Text
If PassCheck(strPass) = True Then
intPress = MsgBox("Correct Password!", vbExclamation, "The result is:")
Else
intPress = MsgBox("Incorrect Password", vbCritical, "The result is:")
End If
End Sub

Private Function PassCheck(strPass As String) As Boolean
PassCheck = False
If strPass = "loser" Then
PassCheck = True
End If
End Function
--------------------------------------------------------------------------------

It looks ok from here. I would make one suggestion though..

If you are not going to do anything with the response from the message box I would change this:

VB Code:

Private Sub Command1_Click()
strPass = Text1.Text
If PassCheck(strPass) = True Then
intPress = MsgBox("Correct Password!", vbExclamation, "The result is:")
Else
intPress = MsgBox("Incorrect Password", vbCritical, "The result is:")
End If
End Sub

to this:

VB Code:

Private Sub Command1_Click()
strPass = Text1.Text
If PassCheck(strPass) = True Then
call MsgBox("Correct Password!", vbExclamation, "The result is:")
Else
call MsgBox("Incorrect Password", vbCritical, "The result is:")
End If
End Sub

No need to handle a variable if not necesary.. Understand?

Rudy

u were forgetting to pass the pw argument, and u forgot an 'end if' in ur passcheck func.

Got it guys, special thanks to RudyL and Cander for your help and advice. I guess now I can finally move to hour 14 lol :)