Printable View
This function call to a custom class returns a SqlDataReader but why do I get an error saying that MyReader is closed? I have verified that the reader contains data before I exit the function call. Am I doing something wrong in terms of creating a reader object to accept the return?
Code:Dim MyReader As SqlClient.SqlDataReader = GroupManager.GetAnnouncementTypesForGroupName(strGroupName)
Whats the code in GroupManager.GetAnnouncementTypesForGroupName(strGroupName)?
I just figured it out. I am closing the connection in the Function so all I had to do was close the connection after I use the Reader!
lol
Code:Namespace GroupManager
Public Class Groups
Dim conn As New SqlConnection(ConfigurationSettings.AppSettings("SQLConn"))
Dim reader As SqlDataReader
Public Sub CloseConnection()
conn.Close()
End Sub
Public Function GetAnnouncementTypesForGroupName(ByVal strCookieValue As String) As SqlDataReader
Try
Dim cmd As New SqlCommand("GetAnnouncementTypesForGroupName", conn)
'add parameter
cmd.Parameters.Add("@GroupName", SqlDbType.VarChar, 50)
cmd.CommandType = CommandType.StoredProcedure
conn.Open()
'set the parameter
cmd.Parameters("@GroupName").Value = strCookieValue.ToLower
'execute the reader
reader = cmd.ExecuteReader
Return reader
Finally
End Try
End Function
etc.......
As a note , this would have saved you time creating close sub !
It closes the connection right after command execution .
VB Code:
Just a thought ...:D
Never knew you could do that but in my case I need to leave it open while the reader is being used by the caller then the caller calls the close ub.Quote:
Originally posted by Pirate
As a note , this would have saved you time creating close sub !
It closes the connection right after command execution .
VB Code:
Just a thought ...:D