Helped wanted with counter [Resolved, thanks]

As a novice, I have been playing about with this code for ages and still can't get it to do wat I want.

Could anyone point out to me where I am going wrong?

What I would like to do is each time the picture moves from the cupboard to the bigcupboard for the cupboardcount to decrement by 1 automatically and bigcupboardcount to increment by1 . The values are shown in labels on forms shown via cmdCupboard and cmdBigCupboard.

Any help would be appreciated, thanks

what ?

Sorry about that, I meant to post project but was interupted

Hi again mbonfyre :)

I have downloaded the app.
First of all, ALWAYS use Option Explicit !

Then you will know when you have misspelled a variable name.
This is the case in your app.

Dim bigcupboard As Integer

should be

VB Code:

Dim bigcupboardcount As Integer

VB Code:

Option Explicit
 
Dim Counter As Integer
Dim Counter2 As Integer
Dim cupboardcount As Integer
Dim bigcupboardcount As Integer
 
Private Sub cmdBigCupboard_Click()
    frmBigCupboard.Show
    frmBigCupboard.lblBigCupboard = bigcupboardcount
End Sub
 
Private Sub cmdCupboard_Click()
    frmCupboard.Show
    frmCupboard.lblCupboard = cupboardcount
End Sub
 
Private Sub Form_Load()
    Counter = 5000
    Counter2 = 5000
    cupboardcount = 500
    bigcupboardcount = 50
End Sub
 
Private Sub Timer1_Timer()
    Static lLeftPos As Long
    lLeftPos = Picture1.Left + 100 ' move from left postion @ 50 speed
            
    If (lLeftPos + Picture1.Width) > 7000 Then
        lLeftPos = 0 ' when picture1 gets to 3960 it returns to 0
        cupboardcount = cupboardcount - 1 ' decrement store1count by 1
        bigcupboardcount = bigcupboardcount + 1
        frmBigCupboard.lblBigCupboard = bigcupboardcount
        frmCupboard.lblCupboard = cupboardcount
    End If
 
    Picture1.Left = lLeftPos ' position picture1
    If cupboardcount = 0 Then MsgBox ("There are no more toys to go in the big cupboard")
    If bigcupboardcount = 700 Then MsgBox ("The cupboard is full, stuff 'em under the bed!")
End Sub

I think that is what you are looking for :)

Dear Peet :)

many thanks for your help, Instructing me to use Option Explicit was a good reminder.
I have so much to learn still, and I couldn't think of a freindlier place to do just that.

Happy New Year to you

Sarah

did you try the suggested code ? :)

No sherry there then Peet ;)

*New Years resolution - Slow down when answering posts at vbforum

Yes, the code that you supplied worked perfectly.

thanks again

Quote:

---

Originally posted by TheBionicOrange
No sherry there then Peet ;)

---

hehe TBO Sherry is the only sherry I drink :D

mbonfyre : you should check the "Require Variable Declaration" setting in the option window in vb. This way you don't have to think about adding Option Explicit to all your modules....

http://www.pvp.no/vbw/options.jpg


oh, and Happy New Year to you to. :)