Creat a file (RESOLVED}

Why doesn't this code work?
I have a form on it are a txtBox (for input) three cmdButtons (Save ,Open ,Exit) i am trying to create and save a file using what i typed into the txtBox as the name.

What i eventualy want to do is create a folder using the input from one txtBox and then create files to put in that folder using another txtBox input sequentually numbered 1 to 3.

I just made this Form up as a test to see what i need to do .

VB Code:

Private Sub cmdExit_Click()
'End the program
    End
    
End Sub
 
 
Private Sub cmdOpen_Click()
    Dim fs As New FileSystemObject
    Dim ts As TextStream
     Set ts = fs.OpenTextFile("C:\", txtName.Text, ".Txt")
     MsgBox ts.ReadLine
     ts.Close
     
End Sub
 
Private Sub cmdSave_Click()
    Dim fs As New FileSystemObject
    Dim ts As TextStream
        Set ts = fs.CreateTextFile("C:/", txtName.Text, ".txt")
        ts.WriteLine "Did this save me"
        ts.Close
        
End Sub

Without trying it the only thing I see is this line

VB Code:

Set ts = fs.OpenTextFile("C:\", txtName.Text, ".Txt") 
 
'Should be 
 
Set ts = fs.OpenTextFile("C:\" & txtName.Text & ".Txt")

Same goes for the cmdSave_Click

JO

Thank you

I at first thought that was the character that was needed but didn't try it thought i would ask first.

I tried it and it worked .

Now i tried this code an got an error ( type mismatch)

VB Code:

Private Sub cmdExit_Click()
'End the program
    End
    
End Sub
Private Sub cmdOpen_Click()
    Dim fs As New FileSystemObject
    Dim ts As TextStream
     Set ts = fs.OpenTextFile("C:\My Documents\"  & txtSSNum.Text & "\" & txtName.Text & ".Txt")
     MsgBox ts.ReadLine
     ts.Close
     
End Sub
Private Sub cmdSave_Click()
    Dim fs As New FileSystemObject
    Dim ts As TextStream
        Set ts = fs.CreateFolder("C:/My Documents/" & txtSSNum.Text)  ' Here where it points to (type MisMatch)
        MsgBox "Created folder"
        ts.Close
        Set ts = fs.CreateTextFile("C:/My Documents/" & txtSSNum.Text & "/" & txtName.Text & ".txt")
        MsgBox "created the file" & txtName.Text
        ts.WriteLine "Did this save me"
        MsgBox "Wrote to file"
        ts.Close
End Sub

hi there mikrow :)

when posting code, use te vbcode tags.


[vbcode]
MsgBox "u'r code goes here"
[/vbcode]

will look Like this

VB Code:

MsgBox "u'r code goes here"

makes it a lot clearer :)

Thank you i didn't know how to get to display like vbcode untill you showed me.

Quote:

---

Originally posted by mikrow
I tried it and it worked .

Now i tried this code an got an error ( type mismatch)

VB Code:

Private Sub cmdExit_Click()
'End the program
    End
    
End Sub
Private Sub cmdOpen_Click()
    Dim fs As New FileSystemObject
    Dim ts As TextStream
     Set ts = fs.OpenTextFile("C:\My Documents\"  _
     & txtSSNum.Text & "\" & txtName.Text & ".Txt")
     MsgBox ts.ReadLine
     ts.Close
     
End Sub
Private Sub cmdSave_Click()
    Dim fs As New FileSystemObject
    Dim ts As TextStream
        Set ts = fs.CreateFolder("C:/My Documents/" _
       & txtSSNum.Text)      ' Here where it points to (type MisMatch)
        MsgBox "Created folder"
        ts.Close
        Set ts = fs.CreateTextFile("C:/My Documents/"  _
        & txtSSNum.Text & "/" & txtName.Text & ".txt")
        MsgBox "created the file" & txtName.Text
        ts.WriteLine "Did this save me"
        MsgBox "Wrote to file"
        ts.Close
End Sub

---

at what line do you get the error ?

I pointed it out in the code where i gor the type mismatch error.

"ts" is a text stream, and so cannot be used to create a folder.

It might be simpler to use the MkDIR standard VB function to create the directory, and then use the FSO for the write functions.

Of course, it might be that you don't need the FSO at all, and standard VB Open, Write/Print, Close functions are enough.

Try this:

Dim fs

Set fs = CreateObject("Scripting.FileSystemObject")
fs.createfolder "C:\My Documents\NewDir"


notice I'm only using fs with createfolder. I also noticed, not sure if this is causing the problem but certainly will cause another one, you are using forward slashes "/", instead of back slashes "\" in your path.

Jordan:
You where right i changed it to MkDir and it worked.

Now i can't get the if statment to work . I keep getting an undefined error.

[Highlight=VB]
Private Sub cmdExit_Click()
'End the program
End
End Sub
Private Sub cmdOpen_Click()
Dim fs As New FileSystemObject
Dim ts As TextStream
'Open the file and get the contents
Set ts = fs.OpenTextFile("C:\My Documents\" & txtSSNum.Text & "\" & txtName.Text & ".Txt")
MsgBox ts.ReadLine
ts.Close
End Sub
Private Sub cmdSave_Click()
Dim fs As New FileSystemObject
Dim ts As TextStream
Dim txtSSNum As Boolean
'Check to see if folder exist
If txtSSNum.Value = True Then End Sub 'What is wrong with this line?
'Make the folder and name it
MkDir ("c:/My Documents/") & txtSSNum.Text
MsgBox "Created the folder"
'Create the file name and put something in it
Set ts = fs.CreateTextFile("C:/My Documents/" & txtSSNum.Text & "/" & txtName.Text & ".txt")
MsgBox "created the file" & txtName.Text
'Put it in the file
ts.WriteLine "Did this save me"
MsgBox "Wrote to file"
ts.Close
End Sub
[vb/code][COLOR=red]

Try using "Exit Sub" instead of "End Sub"

SergioV:

That might work! But i think that my code in the if statement is wrong other than the end/exit Sub statement i think i dimmed txtSSNum twice. And that will give an error.

What i am saying is that i think checking to see if that folder already exists will take more code than i have now and i don't know how to do it!

Sorry, I really didn't read all your code... simply the "End Sub" jumped to my eyes :D

You are checking the value of a variable that I can't understand. You'll need to check by hand if the folder was created or not.

It might not be the best way to do it, but you can use the MkDir and then check it with a ChDir with On error to do whatever you need in any case.

That's the way I've done that, is easy, short and it works :)

Hope that helps enough.

Have a nice weekend !

Thanks for all the help.

To check if a file exists:

VB Code:

Function FileExist(ByVal strPath As String) As Boolean
    FileExist = Len(Dir$(strPath)) <> 0

To check if a Directory exists:

VB Code:

Function DirExist(ByVal DirPath As String) As Boolean
    On Error Resume Next
    'The above line is only required on Win NT4, and 2K. Remove on Win9x
    DirExist = Len(Dir$(DirPath, vbDirectory)) <> 0
End Function

To check to see if strFile is a directory or not:

VB Code:

If (GetAttr(strPath & “\” & strFile) AND vbDirectory) = vbDirectory then
‘ it’s a directory, not a file