Calling a javascript function in a "a href=" statement

Heya, Im a Javascript n00b, just curious as to why this script doesn't work :confused:, i know it's basic...

This is the function in the head section of a HTML file...

VB Code:

<script language="JavaScript">
<!--
    Function callpic(picname)
    { var h = 480;
    var w = 640; 
    var l = (screen.width - w) / 2;
    var t = (screen.height - h) / 2;
    var fullpicname="http://users.bigpond.net.au/maniac/images/"+picname;
    window.open('fullpicname', 'blank', 'width='+w+', height='+h+', top='+t+', left='+l); 
    }
//-->
</script>

And this is a link which I want to call the function :)...

VB Code:

<a href="http://***.***.net.au/***.htm" onClick="callpic('game-nfs1.jpg');">Image 1</a>

any thoughts, opinions or ***'s appreciated :)

function should have a lowercase "F" at the start. Also if I understand what you are trying to do you may want to return false at the end of the onclick bit, so that the href won't be executed.

This should work

Code:

---

<a href="http://***.***.net.au/***.htm" onClick="javascript:callpic('game-nfs1.jpg');">Image 1</a>

---

Yeh thats what I'm trying to do :), thanks, but whats the syntax for returning false? sorry im just doing this by trial and error...

for some reason VBF put a space between "java" and "script"...
there shouldn't be a space there :rolleyes:

Ok thanks ppl already got it working :w00t: :)

suuuuure VBF... ;)

To return false you do this:

<a href="http://***.***.net.au/***.htm" onClick="callpic('game-nfs1.jpg'); return false;">Image 1</a>

or:

<script language="JavaScript">
<!--
function callpic(picname)
{ var h = 480;
var w = 640;
var l = (screen.width - w) / 2;
var t = (screen.height - h) / 2;
var fullpicname="http://users.bigpond.net.au/maniac/images/"+picname;
window.open('fullpicname', 'blank', 'width='+w+', height='+h+', top='+t+', left='+l);
return false;
}
//-->
</script>
<a href="http://***.***.net.au/***.htm" onClick="return callpic('game-nfs1.jpg');">Image 1</a>