My program is not working on Win2K

I started creating this program when I was running Windows 98. I was working fine, but when I run it on Windows 2000 now, it gives me that "illegal operation" error message at the start, and then it terminates.
This program is not done yet because I just worked on it for some time and then just left it away.
If you can run it on windows 98 properly then please post a reply, and if you can't run it on Windows 2000 then also post the reply about that.

I have win2k don't work, sorry.

What about doing a debug run from the start to exactly locate the eror? I don't have Win2k, so I can't do it myself.

Hey dude... in the function SetDialogsSettings() you are doing copying "Yes" into buffer?

well buffer isnt allocated... atleast in the source that you posted...


I dont think it would have been working on Win98 either....

I have XP... so we can make sure this thing works on this too...

Alright...

I think the probably is in your registry functions... You aren't allocating any of your character arrays.

Yep works fine now.

Did you change anything to make in work? I think there might be some problem working with the registry. Win2K may be accessing the registry different way than Windows 98.

yah I did make some changes...


Did you take a look at the SetDialogsSettings() function?

You are using strcpy() with an invalid pointer. That isn't a Win2K thing.

That is the first place it crashes

PHP Code:

---


BOOL SetDialogsSettings()
{
    HKEY regkey;
    char *buffer;
    //------------Option DialogBox Settings--------------------------

    RegCreateKeyEx(HKEY_CURRENT_USER, "software\\Mughal\\EasyRun\\OptionDlg",0, NULL, 0, KEY_WRITE, NULL, &regkey, NULL);
    //Is AutoComplete?
    strcpy(buffer, "Yes");
    RegSetValueEx(regkey, "AUTOCOMPLETE", 0, REG_SZ, (LPBYTE)buffer, strlen(buffer));
    //Is sorting enabled in combobox?
    strcpy(buffer, "Yes");
    RegSetValueEx(regkey, "SORT", 0, REG_SZ, (LPBYTE)buffer, strlen(buffer));
    //Load at startup?
    strcpy(buffer, "No");
    RegSetValueEx(regkey, "LOADATSTARTUP", 0, REG_SZ, (LPBYTE)buffer, strlen(buffer));
    //Make a sound when something is run using "EasyRun"?
    strcpy(buffer, "Yes");
    RegSetValueEx(regkey, "MAKESOUND", 0, REG_SZ, (LPBYTE)buffer, strlen(buffer));
    //Do what when something is opened using "EasyRun"?
    strcpy(buffer, "Nothing");
    RegSetValueEx(regkey, "ONOPEN", 0, REG_SZ, (LPBYTE)buffer, strlen(buffer));
    RegCloseKey(regkey);


    return TRUE;
} 


---

So, do I need to allocate some memory for "buffer"?

Yes

i changed your declaration of buffer to

Code:

---

char buffer[4] = "";

---

You should also get in the habit of initializing all your variables... I noticed a lot of that.

That fixes everything in that function

oh wait... i didn't see the

Code:

---

strcpy ( buffer, "Nothing" );

---

change it to char buffer[8] = "";

Yah, I noticed that and changed it after.

But I am still getting the other error message whenever I run my program.
Here is the code that it gives the error on:

PHP Code:

---

if(MakeFirstReg() == 1)
       {
           SetDialogsSettings();
       }
       else
       {
           MessageBox(NULL, "Second.. time","D",MB_OK);
       } 


---

Go through all your registry functions and make sure you are allocating space for all your buffers

Yah, I'll do it...

I forgot lots of code from this project because I stopped working on it some months ago...that is why, I am having problems with it now.

after i fixed all that stuff it worked fine.

as far as i know that is.

Quote:

---

Originally posted by amac
after i fixed all that stuff it worked fine.

as far as i know that is.

---

Is this code also working for you:

PHP Code:

---

if(MakeFirstReg() == 1)
       {
           SetDialogsSettings();
       }
       else
       {
           MessageBox(NULL, "Second.. time","D",MB_OK);
       } 


---

If yes, then you are probably not running Windows 2000 or later.

Are you trying to tell me I dont know what am running?

And yes it works. And yes I do know what I am running... because I just installed it about 4 or 5 days ago... It's Windows XP.

Quote:

---

Originally posted by amac
Are you trying to tell me I dont know what am running?

---

Sounds rude but I did not mean that.

----

If you can run it properly then I have some problem with my OS or the way my OS accesses the registry for my program.

Quote:

---

Sounds rude but I did not mean that.

---

Dont worry about it.


I dont know what to say... do you have a Win2000 machine?

Are you building on that machine? Because the source code that you posted with the changes I made... works.

It doesnt crash... nothing.

Maybe you could try building on that machine. Or if you can trace threw it on that machine.

Try running this...

this is the exe I built

It is working fine now..
I will check my code again.

let me know when you find out