[RESOLVED] What's wrong with my MessageBox ?

[Poppa Mintin]

Hi, I'm trying to get a return result from a MessageBox like this:

Private Sub Button9_Click(sender As System.Object, e As System.EventArgs) Handles Button9.Click
        Dim ask As String = "Are you sure you want to delete this record ?"
        Dim flag As Boolean = True
 
        MessageBox.Show(ask, "Delete", MessageBoxButtons.YesNo, MessageBoxIcon.Warning)
        flag = CBool(Windows.Forms.DialogResult.No)
 
        If flag Then Exit Sub
 
    End Sub

Clicking either the 'Yes' or 'No' button on the MessageBox always returns flag = True.
I've tried 'Dim flag As Boolean = False' and ran the code but still get 'True', so it's not just bypassing the code, it's actually setting flag to True.

The MsgBox title is 'Delete' as it ought to be, the correct question is being asked and the 'Warning' icon is being displayed.
I originally had ' flag = Windows.Forms.DialogResult.No' (i.e. without the CBool( ... ) but Option Strict insisted !.
Oh... and I've also tried 'flag = CBool(Windows.Forms.DialogResult.Yes)'... still with the same always 'True' result.

Poppa.

[dunfiddlin]

Dim flag = MessageBox.Show(ask, "Delete", MessageBoxButtons.YesNo, MessageBoxIcon.Warning)
If flag = Windows.Forms.DialogResult.No Then

[Static]

you need to catch whats being clicked...

like this

IF msgbox(ask,vbYesNo+vbCritical,"Delete") = vbNo then exit sub

or set it to a variable

Dim Result as Integer = msgbox(ask,vbYesNo+vbCritical,"Delete")

etc

[Poppa Mintin]

@ Static: I shall try that as soon as I've posted this solution:

I've used the following code, slightly amended, for a similar check question before, but I thought the code suggested by 'Home and Learn 2010' was worth a try...

Private Sub Button9_Click(sender As System.Object, e As System.EventArgs) Handles Button9.Click
        Dim flag As Boolean = Ask()
 
        If flag Then Exit Sub
 
    End Sub
 
    Private Function Ask() As Boolean
        Dim Q As String = "Are you sure you want to delete this record ?"
        Dim R As MsgBoxResult
        Dim Sty As MsgBoxStyle = MsgBoxStyle.YesNo
 
        R = MsgBox(Q, Sty, Title:="Delete")
        If R = MsgBoxResult.No Then
            Return True
        Else
            Return False
        End If
 
    End Function

A bit lengthier, but at least it works !
Off to try Static's suggestion now...


Poppa.

[dunfiddlin]

Do you want me to sit in a corner and rust or just fall apart where I'm standing?

[.paul.]

MsgBox returns MsgBoxResult
Messagebox.Show returns DialogResult

[Poppa Mintin]

you need to catch whats being clicked...

like this

IF msgbox(ask,vbYesNo+vbCritical,"Delete") = vbNo then exit sub

or set it to a variable

Dim Result as Integer = msgbox(ask,vbYesNo+vbCritical,"Delete")

etc

Thanks Static, what's much tidier...

Private Sub Button9_Click(sender As System.Object, e As System.EventArgs) Handles Button9.Click
        Dim Ask As String = "Are you sure you want to delete this record ?"
        If MsgBox(Ask, CType(vbYesNo + vbExclamation, MsgBoxStyle), "Delete") = vbNo Then Exit Sub
 
    End Sub

And of course, works both ways.


Poppa.

[Poppa Mintin]

Do you want me to sit in a corner and rust or just fall apart where I'm standing?

I've no idea what this is supposed to mean, but I only asked why the code supplied by a tutorial reputedly up-to-date (2012) 'Home and Learn' wasn't working.

Poppa.

[.paul.]

dunfiddlin showed you how to make your code from 'Home and Learn' work.
an explanation with the code might've been helpful

[dunfiddlin]

Explanations are for wimps!

flag = CBool(Windows.Forms.DialogResult.No)

There is no direct conversion from the dialog result to Boolean so what this amounts to is 'Is Windows.Forms.DialogResult.No Windows.Forms.DialogResult.No?" to which the Boolean answer is always True. Even if that were not the case, there is no reference at any point to what button was actually pressed on the Dialog. In other words you would get exactly the same result if there never actually was a message box.

If this is from Home and Learn verbatim, I suggest you contact the author and put him right!

[Poppa Mintin]

dunfiddlin showed you how to make your code from 'Home and Learn' work.
an explanation with the code might've been helpful

Yeah, I suppose that's right but if you look at the post times you see I was writing the reply to Static's post when Dunfiddlin posted his.

Oh... I was just looking back for exact times and discovered a post I'd not seen. I didn't see your first post Dunfiddlin, my email said I'd had a reply and clicking it took me straight to Static's post, bypassed yours entirely... Sorry.

I must say I was very surprised by Dunfiddlin's uncharacteristically caustic post but I can see his point now.

Poppa.

[dbasnett]

Why fool around with converting???? Don't make things more complicated than they need to be.

        Dim ask As String = "Are you sure you want to delete this record ?"

        Dim flag As DialogResult = MessageBox.Show(ask, "Delete", MessageBoxButtons.YesNo, MessageBoxIcon.Warning)
        If flag = Windows.Forms.DialogResult.No Then
            'no, exit
            Exit Sub
        Else
            'yes
        End If

I find it helpful to explicitly define the data types.

[dunfiddlin]

uncharacteristically caustic

Uncharacteristic? I must be going soft in my old age!!!

[.paul.]

uncharacteristically caustic???

BTW I posted too. didn't notice a rating

[dbasnett]

Uncharacteristic? I must be going soft in my old age!!!

He'll learn

Hopefully poppa will learn to scan the threads when he gets a notification so he doesn't miss one.