[RESOLVED] shell command help

[doberman2002]

works

Private Sub Command7_Click()
shell "cmd /k ""cd C:\Users\leon\Desktop\newfolder&&test.bat"""
End Sub

does not work?

Private Sub Command1_Click()
shell "cmd /k ""cd " & text1.text & """"
End Sub

text1.text C:\Users\leon\Desktop\newfolder&&test.bat

[westconn1]

from the appearance of the code, you are trying to cd to a file rather than a folder, but i am not sure that is really what you want to do, if you want to just call the batch file then as you are supplying a full path you should not need to cd

[SamOscarBrown]

Agree with west....appears you are attempting to change directory to a filename...

The code you say works, I doubt it.

The code you say does not work, should (if text1.text is a valid directory)

If all you want to do is run your batch file (located in the directory as stated in your text1.text), then simply:

Private Sub Command1_Click()
    Text1.Text = "c:\Users\leon\desktop\newfolder\"  'i put this here to show what your text1.text MIGHT look like (not needed in this button click)
    Shell Text1.Text & "\test.bat"
End Sub

[passel]

The first code probably does work, because && is the command separator in DOS, so the line contains two commands, cd and executing the batch file.

The second code may not be passing the command string properly, so the cmd processor isn't interpreting the "&&", i.e. it may be inside quotes so being prevented from parsing. I'll have to try it out to see what's what.

p.s. I tried it out and it worked for me, in both cases. I'm not sure why it didn't work for you. I did use a simpler path though, but that shouldn't have made a difference.

'Textbox1 contained C:\c&&test.bat
Option Explicit

Private Sub Command1_Click()
  Shell "cmd /k ""cd " & Text1.Text & """"
End Sub

The batch file was C:\c\test.bat

The contents of the batch file were

dir >d1.lst
notepad d1.lst

It gave me a list of the C:\c directory in the file, which verified the cd did take effect before the batch file ran.

[doberman2002]

The first code probably does work, because && is the command separator in DOS, so the line contains two commands, cd and executing the batch file.

The second code may not be passing the command string properly, so the cmd processor isn't interpreting the "&&", i.e. it may be inside quotes so being prevented from parsing. I'll have to try it out to see what's what.

p.s. I tried it out and it worked for me, in both cases. I'm not sure why it didn't work for you. I did use a simpler path though, but that shouldn't have made a difference.

'Textbox1 contained C:\c&&test.bat
Option Explicit

Private Sub Command1_Click()
  Shell "cmd /k ""cd " & Text1.Text & """"
End Sub

The batch file was C:\c\test.bat

The contents of the batch file were

dir >d1.lst
notepad d1.lst

It gave me a list of the C:\c directory in the file, which verified the cd did take effect before the batch file ran.

after executing the bat i have inside .bat
del name.bat
exit
so the cmd stays open i need to kill cmd window and kill the bat file because its not needed no more ?

[SamOscarBrown]

WHAT, may I ask, are you trying to do...the ultimate goal?

[SamOscarBrown]

For whatever purpose you are doing this, the Exit command should close the CMD window as long as it is the last thing run in your (many) batch files.

[westconn1]

/k specifies to keep the command window open

[passel]

If you don't want to leave the command window open, then use /c not /k. /k is specifically to keep the command window open after the command is executed. /c will execute the command and the window will close when the command completes.