Results 1 to 7 of 7

Thread: VBA Crashes with basic macro

  1. #1

    Thread Starter
    New Member
    Join Date
    Feb 2018

    VBA Crashes with basic macro


    New to VBA so forgive the ignorance...I have the attached that is supposed to be producing two charts from a number of named ranges. I've commented off chart two so as to isolate the first chart. Both of these charts worked this morning so I'm not sure what happened. Can someone please see the attached and advise on what might be the issue?


    Sub Relative_Calculation()
    Dim BRValue As Name
    Dim BRMomentum As Name
    Dim BRQuality As Name
    Dim BRYield As Name
    Dim PRValue As Name
    Dim PRMomentum As Name
    Dim PRQuality As Name
    Dim PRYield As Name
    ActiveWorkbook.Names.Add Name:="BRValue", RefersTo:="=Test!$D$13:$O$13-Test!$R$13"
    ActiveWorkbook.Names.Add Name:="BRMomentum", RefersTo:="=Test!$D$14:$O$14-Test!$R$14"
    ActiveWorkbook.Names.Add Name:="BRQuality", RefersTo:="=Test!$D$15:$O$15-Test!$R$15"
    ActiveWorkbook.Names.Add Name:="BRYield", RefersTo:="=Test!$D$16:$O$16-Test!$R$16"
    ActiveWorkbook.Names.Add Name:="PRValue", RefersTo:="=Test!$D$13:$O$13-Test!$S$13"
    ActiveWorkbook.Names.Add Name:="PRMomentum", RefersTo:="=Test!$D$14:$O$14-Test!$S$14"
    ActiveWorkbook.Names.Add Name:="PRQuality", RefersTo:="=Test!$D$15:$O$15-Test!$S$15"
    ActiveWorkbook.Names.Add Name:="PRYield", RefersTo:="=Test!$D$16:$O$16-Test!$S$16"
    'Defining Chart Objects for three charts (IR/SR)
    Set IR = ActiveSheet.ChartObjects.Add(Left:=300, Width:=300, Top:=10, Height:=300)
    'Set PortfolioRelative = ActiveSheet.ChartObjects.Add(Left:=900, Width:=300, Top:=10, Height:=300)
    'Defining positioning of SR/IR charts
    With IR
    .Left = 50
    .Width = 600
    .Top = 10
    .Height = 350
    End With
    With SR
    .Left = 300
    .Width = 600
    .Top = 10
    .Height = 350
    End With
    With ActiveChart
    .HasTitle = True
    .ChartTitle.Text = "Benchmark Relative Factor Exposures Across Frontier"
    'Plot Benchmark Relative Value
    .ChartType = xlLine
    .SeriesCollection(1).XValues = "=Test!D1:O1"
    .SeriesCollection(1).Values = "=Test!BRValue"
    .SeriesCollection(1).Name = "=Test!A13"
    'Plot Benchmark Relative Momentum
    .SeriesCollection(2).XValues = "=Test!D1:O1"
    .SeriesCollection(2).Values = "=Test!BRMomentum"
    .SeriesCollection(2).Name = "=Test!A14"
    'Plot Benchmark Relative Quality
    .SeriesCollection(3).XValues = "=Test!D1:O1"
    .SeriesCollection(3).Values = "=Test!BRQuality"
    .SeriesCollection(3).Name = "=Test!A15"
    'Plot Benchmark Relative Yield
    .SeriesCollection(4).XValues = "=Test!D1:O1"
    .SeriesCollection(4).Values = "=Test!BRYield"
    .SeriesCollection(4).Name = "=Test!A16"
    End With
    'With ActiveChart
    '.HasTitle = True
    '.ChartTitle.Text = "Current Portfolio Relative Factor Exposures Across Frontier"
    'Plot Current Portfolio Relative Value
    '.ChartType = xlLine
    '.SeriesCollection(1).XValues = "=Test!D1:O1"
    '.SeriesCollection(1).Values = "=Test!PortfolioRelativeValue"
    '.SeriesCollection(1).Name = "=Test!A13"
    'Plot Current Portfolio Momentum
    '.SeriesCollection(2).XValues = "=Test!D1:O1"
    '.SeriesCollection(2).Values = "=Test!PortfolioRelativeMomentum"
    '.SeriesCollection(2).Name = "=Test!A14"
    'Plot Current Portfolio Quality
    '.SeriesCollection(3).XValues = "=Test!D1:O1"
    '.SeriesCollection(3).Values = "=Test!PortfolioRelativeQuality"
    '.SeriesCollection(3).Name = "=Test!A15"
    'Plot Current Portfolio Yield
    '.SeriesCollection(4).XValues = "=Test!D1:O1"
    '.SeriesCollection(4).Values = "=Test!PortfolioRelativeYield"
    '.SeriesCollection(4).Name = "=Test!A16"
    'End With
    End Sub
    Last edited by si_the_geek; Feb 24th, 2018 at 07:13 AM. Reason: fixed Code tags

  2. #2

    Thread Starter
    New Member
    Join Date
    Feb 2018

    Re: VBA Crashes with basic macro

    also, I was attempting to add code tags to the above. How do I do that?

  3. #3
    Frenzied Member
    Join Date
    Oct 2001
    Idaho Falls, Idaho USA

    Re: VBA Crashes with basic macro

    If you can still edit your post, you can place the tags like this, substituting square brackets for the parentheses:

    ' code goes here

    Or click the "#" symbol above the text editing box.

  4. #4
    Super Moderator si_the_geek's Avatar
    Join Date
    Jul 2002
    Bristol, UK

    Re: VBA Crashes with basic macro

    Welcome to VBForums

    Thread moved from the 'VB.Net' forum to the 'Office Development/VBA' forum.

    I've fixed the code tags... as jdc2000 said, they should be like this: [code] code here [/code]

  5. #5
    Join Date
    Dec 2004

    Re: VBA Crashes with basic macro

    VBA Crashes with basic macro
    does this mean that the macro stops with an error, or excel completely closes or stops and has to be closed?

    have you restarted excel? windows?, has your windows version done an update?

    if you get an error, what is the error number and message?
    if the macro stops with an error and you get a stop /debug message, what line is the macro at when selecting debug?
    if excel totally stops you will need to step through the macro one line at a time to find which line causes the crash
    i do my best to test code works before i post it, but sometimes am unable to do so for some reason, and usually say so if this is the case.
    Note code snippets posted are just that and do not include error handling that is required in real world applications, but avoid On Error Resume Next

    dim all variables as required as often i have done so elsewhere in my code but only posted the relevant part

    come back and mark your original post as resolved if your problem is fixed

  6. #6
    Frenzied Member gibra's Avatar
    Join Date
    Oct 2009

    Re: VBA Crashes with basic macro

    Maybe good if you attach your Excel file for test

  7. #7
    Don't Panic! Ecniv's Avatar
    Join Date
    Nov 2000
    Java (JSP) Hell!

    Re: VBA Crashes with basic macro

    You said it was working this morning..?
    What did you change? Coding? Location of xls? Changed a named range? Or deleted one?

    BOFH Now, BOFH Past, Information on duplicates

    Feeling like a fly on the inside of a closed window (Thunk!)
    If I post a lot, it is because I am bored at work! ;D Or stuck...
    * Anything I post can be only my opinion. Advice etc is up to you to persue...

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts


Click Here to Expand Forum to Full Width