[RESOLVED] Getting error when there is no data in Table.

[VS2013]

The following code is working fine when there is some data available in CustomersTable. But getting an error when there is no data in that table. How to deal with this error.

Public Function cboLoadSelectCity()
        Dim StrSql As String = "Select Distinct City from CustomersTable"
        Dim dt As New DataTable
        If Not DAL.ExecuteSql(dt, StrSql, Msg) Then MsgBox(Msg, MsgBoxStyle.Exclamation, "Error") : Return 0
        Dim ds As New DataSet
        ds.Tables.Add(dt)
        cboCity.ValueMember = "City"
        cboCity.DataSource = ds.Tables(0)
        cboCity.SelectedIndex = 0
        Return True
    End Function

Error:
Additional information: InvalidArgument=Value of '0' is not valid for 'SelectedIndex'.

[kpmc]

try this

if ds.Tables(0).rows.count > 0 then
cboCity.SelectedIndex = 0
End If

[VS2013]

Thanks. It's working fine.

[jmcilhinney]

You're trying to solve the wrong problem. Just get rid of the line that throws the exception because it's completely pointless anyway. All it does is select the first item in the bound list but that happens automatically anyway, so pointless.

Speaking of pointless, why are you creating a DataSet there?

Also, you should probably be setting the DisplayMember rather than the ValueMember.

[kpmc]

You're trying to solve the wrong problem. Just get rid of the line that throws the exception because it's completely pointless anyway. All it does is select the first item in the bound list but that happens automatically anyway, so pointless.

Speaking of pointless, why are you creating a DataSet there?

Also, you should probably be setting the DisplayMember rather than the ValueMember.

True, but then again he didnt ask for your opinion.

[jmcilhinney]

True, but then again he didnt ask for your opinion.

It's clear to me that everyone wants my opinion but they're just too shy to ask sometimes.

[kpmc]

Sorry, JMC, I was only trying to get you goin. Not very nice of me.

[jmcilhinney]

Sorry, JMC, I was only trying to get you goin. Not very nice of me.

Don't worry. I took it as a joke. I'm not that thin-skinned.

[kpmc]

Good deal.

I am actually trying to find work in Alice Springs , not to change the subject...