Saving to SQL issue

[dlhall]

I have a web form that retrieves information from a SQL 2008 database, and some data has percentage symbols in it (%), which throws SQL errors when attempting to save. I am using parameterized queries to save, but the SQL stored Proc will not let me save. Can anybody tell me how to take the literal contents of a drop-down choice, including any characters like %, and write to the database without error?

The parameterized query is like this:

cmd.parameters.AddWithValue("@DBField", DDL1.selectedValue)

The stored proc is an update statement in the usual form
update table set column = @value

[si_the_geek]

What data type is the field in the database, and what is the data type of the value that you are putting into .AddWithValue?

Assuming that the field is VarChar based, either of these should fix it:

cmd.parameters.AddWithValue("@DBField", DDL1.selectedValue.ToString)
cmd.parameters.AddWithValue("@DBField", CStr(DDL1.selectedValue))

[dlhall]

What data type is the field in the database, and what is the data type of the value that you are putting into .AddWithValue?

Assuming that the field is VarChar based, either of these should fix it:

cmd.parameters.AddWithValue("@DBField", DDL1.selectedValue.ToString)
cmd.parameters.AddWithValue("@DBField", CStr(DDL1.selectedValue))

Thanks for that. The CStr did the trick!

[jmcilhinney]

To be specific, AddWithValue infers the type of the parameter from the value that you provide. That means that you need to use a value that is compatible with the way the parameter is used in the SQL code.

It's also worth noting that many people recommend against using AddWithValue for text data especially but other places too. That's because a database like SQL Server has various types that can store text so AddWithValue simply makes a best guess. Sometimes that guess will be correct and other times it won't matter but there may be some occasions where it guesses the wrong type and that makes a difference in the SQL code that causes unexpected behaviour. If that's possible then it's better to call Add, specify the data type explicitly and then set the Value of the parameter.

[dlhall]

To be specific, AddWithValue infers the type of the parameter from the value that you provide. That means that you need to use a value that is compatible with the way the parameter is used in the SQL code.

It's also worth noting that many people recommend against using AddWithValue for text data especially but other places too. That's because a database like SQL Server has various types that can store text so AddWithValue simply makes a best guess. Sometimes that guess will be correct and other times it won't matter but there may be some occasions where it guesses the wrong type and that makes a difference in the SQL code that causes unexpected behaviour. If that's possible then it's better to call Add, specify the data type explicitly and then set the Value of the parameter.

Thanks a lot for the tips..I appreciate it!