A generic error occurred in GDI+.

[Salem141]

Hi All

Iam getting this error while Updating Picture box :

c

iam using stored proc :

ALTER procedure [dbo].[Update_Customer]

	@CustomerID int output,
	@CustomerName nvarchar (50),
	@CustomerPhoto image,
	@CustomerEmail nvarchar(Max),
	@CustomerPhone1 nvarchar(12),
	@CustomerPhone2 nvarchar(12),
	@CustomerAddress nvarchar(Max),
	@CustomerFax nvarchar(12),
	@CustomerStatus bit,
	@CountryID int,
	@CityID int,
	@Notes nvarchar (Max),
	@ModifiedBy nvarchar (30)
	

as

    BEGIN
        update CustomersTbl set 
		    CustomerID=@CustomerID,
		    CustomerName=@CustomerName,
			CustomerPhoto=@CustomerPhoto,
			CustomerEmail=@CustomerEmail,
			CustomerPhone1=@CustomerPhone1,
			CustomerPhone2=@CustomerPhone2,
			CustomerAddress=@CustomerAddress,
			CustomerFax=@CustomerFax,
			CustomerStatus=@CustomerStatus,
			CountryID=@CountryID,
			CityID=@CityID,
			Notes=@Notes,
			ModifiedDate=getdate(),
			ModifiedBy=@ModifiedBy
		where CustomerID=@CustomerID
    END

In VS 2012 I have Two Layers

Data Layer Code :

        Friend Function Update_Customer(ByVal CustomerID As String, ByVal CustomerName As String, ByVal CustomerEmail As String, ByVal CustomerPhone1 As String, ByVal CustomerPhone2 As String, ByVal CustomerAddress As String, ByVal CustomerFax As String, ByVal CustomerStatus As Boolean, ByVal CountryID As Integer, ByVal CityID As Integer, ByVal Notes As String, ByVal ModifiedBy As String) As String
            Dim retval As String
            Dim cmd As New SqlCommand("Update_Customer")
            cmd.Parameters.AddWithValue("@CustomerID", CustomerID)
            cmd.Parameters.AddWithValue("@CustomerName", CustomerName)
            cmd.Parameters.AddWithValue("@CustomerPhoto", SqlDbType.Image).Value = imgToByteArray(FrmManageDetailsCustomers.PictureBox2.Image)
            cmd.Parameters.AddWithValue("@CustomerEmail", CustomerEmail)
            cmd.Parameters.AddWithValue("@CustomerPhone1", CustomerPhone1)
            cmd.Parameters.AddWithValue("@CustomerPhone2", CustomerPhone2)
            cmd.Parameters.AddWithValue("@CustomerAddress", CustomerAddress)
            cmd.Parameters.AddWithValue("@CustomerFax", CustomerFax)
            cmd.Parameters.AddWithValue("@CustomerStatus", CustomerStatus)
            cmd.Parameters.AddWithValue("@CountryID", CountryID)
            cmd.Parameters.AddWithValue("@CityID", CityID)
            cmd.Parameters.AddWithValue("@Notes", Notes)
            cmd.Parameters.AddWithValue("@ModifiedBy", ModifiedBy)
            retval = dm.executeNonQuery(cmd)
            Return retval
        End Function

And Business Layer :

        Public Function Update_Customer(ByVal CustomerID As String, ByVal CustomerName As String, ByVal CustomerEmail As String, ByVal CustomerPhone1 As String, ByVal CustomerPhone2 As String, ByVal CustomerAddress As String, ByVal CustomerFax As String, ByVal CustomerStatus As Boolean, ByVal CountryID As Integer, ByVal CityID As Integer, ByVal Notes As String, ByVal ModifiedBy As String) As String
            Dim retval As String
            retval = p.Update_Customer(CustomerID, CustomerName, CustomerEmail, CustomerPhone1, CustomerPhone2, CustomerAddress, CustomerFax, CustomerStatus, CountryID, CityID, Notes, ModifiedBy)
            Return retval
        End Function

In Module I have this Code :

    Public Function imgToByteArray(ByVal img As Image) As Byte()
        Using mStream As New MemoryStream()
            img.Save(mStream, img.RawFormat)
            Return mStream.ToArray()
        End Using
    End Function

And the Last Code is for Update button :

Dim retval As String = p.Update_Customer(txtCustomerCode.Text, txtCustomerName.Text, txtCustomerEmail.Text, txtCustomerPhone1.Text, txtCustomerPhone2.Text, txtCustomerAddress.Text, txtCustomerFax.Text, CheckBox2.Checked, ComboCustomerCountry.SelectedValue, ComboCustomerCity.SelectedValue, txtCustomernote.Text, FrmMain.LblUserID.Text)

The Error that iam getting is : A generic error occurred in GDI+.

[LuckyLuke82]

Might not be of help to you, but - first of all try your Update_Customer code with Using block. About your error - nothing in your code looks to me that you're dealing with grapchics. do you use your Picturebox for any kind of Painting. If so, then you should examine Paint event of Picturebox. MSDN actually recommends that you should use as less Picturebox as possible, specially when dealing with GDI+, use Label or something else instead.

Also, your stored procedure - that is a snapshot from your DB right ? Stored procedure should be locatted there, you only call It from VB.NET. At least that is how I do in Oracle....

[jmcilhinney]

How EXACTLY do you load the Image in the first place? One reason for this rather unhelpful error message is trying to save an Image that was loaded from a file without closing the file. For instance, the Image.FromFile method and the Bitmap constructor that takes a file path as an argument both keep the specified file open until the object is disposed.

[Salem141]

How EXACTLY do you load the Image in the first place? One reason for this rather unhelpful error message is trying to save an Image that was loaded from a file without closing the file. For instance, the Image.FromFile method and the Bitmap constructor that takes a file path as an argument both keep the specified file open until the object is disposed.

i load it from GridView

FrmManageDetailsCustomers.PictureBox2.Image = byteArrayToImage(MainCustomersGv.Rows(MainCustomersGv.CurrentRow.Index).Cells(2).Value)

[jmcilhinney]

MainCustomersGv.Rows(MainCustomersGv.CurrentRow.Index)

Um, what's the point of getting the current row, then getting its index, then using that index to get the row at that index? Isn't that just going to give you back the row you already had? If you want the current row then just stop at the current row, i.e. use 'MainCustomersGv.CurrentRow'.

[Salem141]

So what code i have to write instead of

MainCustomersGv.Rows(MainCustomersGv.CurrentRow.Index)

any help ??

[techgnome]

isntead of
MainCustomersGv.Rows(MainCustomersGv.CurrentRow.Index).Cells(2).Value

use
MainCustomersGv.CurrentRow.Cells(2).Value

-tg

[jmcilhinney]

So what code i have to write instead of

MainCustomersGv.Rows(MainCustomersGv.CurrentRow.Index)

any help ??

Really?

use 'MainCustomersGv.CurrentRow'.

[Salem141]

The same error iam getting

[jmcilhinney]

That was just a general recommendation on code improvement, not a solution to this issue. The only specific reason for that particular error message that I'm aware of is obviously not in play on this occasion, so I'm at a loss. That said, you haven't shown us your 'byteArrayToImage' method, so maybe there's something in there.

[Salem141]

That was just a general recommendation on code improvement, not a solution to this issue. The only specific reason for that particular error message that I'm aware of is obviously not in play on this occasion, so I'm at a loss. That said, you haven't shown us your 'byteArrayToImage' method, so maybe there's something in there.

This is

    Public Function byteArrayToImage(ByVal byt As Byte()) As Image
        Dim ms As New System.IO.MemoryStream()
        Dim drwimg As Image = Nothing
        Try
            ms.Write(byt, 0, byt.Length)
            drwimg = New Bitmap(ms)
        Finally
            ms.Close()
        End Try
        Return drwimg
    End Function

[Inferrd]

    Public Function byteArrayToImage(ByVal byt As Byte()) As Image
        Dim ms As New System.IO.MemoryStream()
        Dim drwimg As Image = Nothing
        Try
            ms.Write(byt, 0, byt.Length)
            drwimg = New Bitmap(ms)
        Finally
            ms.Close()
        End Try
        Return drwimg
    End Function

That's probably half your problem right there: you are closing the memory stream immediately after you create the image and well before you dispose of the image.

If you look at the documentation for the Bitmap Constructor that takes as Stream as an argument, you'll see that it says You must keep the stream open for the lifetime of the Bitmap.

The solution to that would depend on whether it is important to maintain the original image in the database, or an image that pretty much looks like the original.

[techgnome]

That's probably half your problem right there: you are closing the memory stream immediately after you create the image and well before you dispose of the image.

If you look at the documentation for the Bitmap Constructor that takes as Stream as an argument, you'll see that it says You must keep the stream open for the lifetime of the Bitmap.

The solution to that would depend on whether it is important to maintain the original image in the database, or an image that pretty much looks like the original.

Wow... interesting. So, if you're generating multiple images, you have to keep all of the streams for each one around? Surely there's a way to disconnect the image from the stream.

-tg

[kebo]

So, if you're generating multiple images, you have to keep all of the streams for each one around?

To keep the original image you do, but you can always clone the image then close the stream and return the clone...

Private Function imageFromStream(ms As IO.Stream) As Image
 
        Dim img As Image = New Bitmap(ms)
        Dim noStreamImage As Image = img.Clone
        ms.Close()
        Return noStreamImage
 
    End Function

[Inferrd]

To keep the original image you do, but you can always clone the image then close the stream and return the clone...

Unfortunately, the clone approach has the same problems with regards to the stream.

A while ago I spent several hours researching (Googling) this and ended up more confused than I started. There's a hell of a lot of advice out there, and half of it is wrong or misleading.

I tend to create a new second image from the first and then dispose of the first image and its stream, something like:

 Public Function byteArrayToBitmap(ByVal bytes As Byte()) As Bitmap
     Dim imageOut As Bitmap = Nothing

     Using ms As New System.IO.MemoryStream(bytes)
         Dim imageTemp As Image = Image.FromStream(ms)
         imageOut = New Bitmap(imageTemp)
         imageTemp.Dispose()
     End Using

     Return imageOut
 End Function

The big disadvantage of that approach, however, is that the new image loses any metadata that the original may have had, and typically has a different colour depth and/or horizontal/vertical resolutions. That's why I asked Salem141 whether it was important that the original data stored in his images was to be saved or not.

[Salem141]

I have change it from

FrmManageDetailsCustomers.PictureBox2.Image = byteArrayToImage(MainCustomersGv.Rows(MainCustomersGv.CurrentRow.Index).Cells(2).Value)

To

FrmManageDetailsCustomers.PictureBox2.Image = imageFromStream(MainCustomersGv.Rows(MainCustomersGv.CurrentRow.Index).Cells(2).Value)

I get this error

Unable to cast object of type 'System.Byte[]' to type 'System.IO.Stream'.

[techgnome]

That's probably because
MainCustomersGv.CurrentRow.Cells(2).Value (really? Again with the index when you already have the row?)

returns a byte array not a stream.

-tg

[Salem141]

That's probably because
MainCustomersGv.CurrentRow.Cells(2).Value (really? Again with the index when you already have the row?)

returns a byte array not a stream.

-tg

i change it cuz i got
Value of type '1-dimensional array of Byte' cannot be converted to 'System.Drawing.Image

[techgnome]

Ok, so it told you that you can't change an orange into an apple, so you replaced it with a banana...

the cell contains a bytearray, that's what you're going to want to pass in... inside that you convert the byte array into a stream, a memory stream makes sense to me, then pass that stream to the image ... your original byteArrayToImage did all that... the only problem is that you need to keep the stream around ... the solution to which it seems like there's mixed results...

-tg

[jmcilhinney]

The reason that GDI+ requires a Stream to remain open is that it goes back to that Stream at various points to retrieve additional information. I don't know exactly what information it is but you get that generic GDI+ error when you try to save because GDI+ tries to go back to the Stream from which the Image was created to get information it needs when saving but it fails because that Stream is closed.

Now that we've got to that point, I recall that I encountered the same issue a number of years ago. My solution at that time was to simply keep the Stream open indefinitely and let it be cleaned up by the system at the end. This is not ideal but it is feasible if the number of Streams you create will be small. Perhaps a better option would be to create a Dictionary(Of Image, Stream) to store each open Stream against the Image that was created from it. That way, when you're done with an Image and are ready to dispose it, you can get the corresponding Stream from the Dictionary and dispose that too, then remove that item from the Dictionary, e.g.

Private ReadOnly streamsByImage As New Dictionary(Of Image, Stream)
 
Private Function ToImage(bytes As Byte()) As Image
    Dim strm As New MemoryStream(bytes)
    Dim img = Image.FromStream(strm)
 
    streamsByImage.Add(img, strm)
 
    Return img
End Function
 
Private Sub DisposeImage(img As Image)
    Dim strm As Stream = Nothing
 
    If streamsByImage.TryGetValue(img, strm) Then
        strm.Dispose()
        streamsByImage.Remove(img)
    End If
 
    img.Dispose()
End Sub

[Salem141]

Thank You Very Much

It Works Now 100%