[RESOLVED] Need help Populate (Height or Tall) in combo box

[morbid.ivan]

How do I sort this out?

Example :
4'8"
4'9"
4'10"
4'11"
4'12"
5'1"
5'2"
5'3"
and so on....

Dim iCtr As Integer
Dim iLoop As Integer

For iCtr = 0 To 12

    For iLoop = 4 To 6
        List1.AddItem iLoop & "'" & Format(iCtr, "#0") & """"
    Next iLoop
   
Next

Any Help?

[morbid.ivan]

in combobox or listbox

[DataMiser]

You need to reverse your loops, make iLoop the outter loop and iCtr the inner loop also iCtr should be 0 to 11 so you don't end up with something like 4'12"

So when iLoop=4
iCtr= 0 to 11 and you get
4' 0"
4'1"
...
4'11"

Then iLoop becomes 5 and you get
5'0"
...

[morbid.ivan]

You need to reverse your loops, make iLoop the outter loop and iCtr the inner loop also iCtr should be 0 to 11 so you don't end up with something like 4'12"

So when iLoop=4
iCtr= 0 to 11 and you get
4' 0"
4'1"
...
4'11"

Then iLoop becomes 5 and you get
5'0"
...

Public Sub heightLister(cbo As ComboBox)
Dim iWeight As Integer

cbo.Clear

Dim iCtr As Integer
Dim iLoop As Integer

For iLoop = 4 To 6
    
    If iLoop = 4 Then
    
        For iCtr = 0 To 12
            cbo.AddItem iLoop & "'" & Format(iCtr, "#0") & """"
        Next
        
    ElseIf iLoop = 5 Then
    
        For iCtr = 0 To 12
            cbo.AddItem iLoop & "'" & Format(iCtr, "#0") & """"
        Next
    ElseIf iLoop = 6 Then
    
        For iCtr = 0 To 12
            cbo.AddItem iLoop & "'" & Format(iCtr, "#0") & """"
        Next
           
    End If
    
Next

End Sub

These code solve my problem.

[DataMiser]

You don't need any of those ifs in there. Why did you add those, all you are doing is repeating the code three times.

All you need is

For iLoop = 4 To 6 
        For iCtr = 0 To 12
            cbo.AddItem iLoop & "'" & Format(iCtr, "#0") & """"
        Next     
Next