Unexpected Run-Time Error Type '13' mismatch Error

[sher]

I've inherited an old Excel-VBA model at work. I'm running this program to calculate loss on a portfolio of loans. The program works fine for a loan portfolio up to 500 loan items, but starts throwing up "Run-Time Error Type '13' mismatch" when I load a larger portfolio with more than 500 items.

    Public Sub generateLossDistribution()

    ....

        Dim i As Long, j As Long
        Dim p As portfolio
        ' Creates a new portfolio object and reads it
        **Set p = New portfolio**

The error message crops up in the "**" code line. FYI, "portfolio" is a user defined object/class module. Since the code works for fewer loan items, could this error be due to increased array size (when bigger portfolio gets loaded)? The portfolio has about 30 fields for each loan items. Is there a limit on the array size, which I can expand?

Apologies of being very vague since I'm just a beginner and the model code is too huge to be uploaded to make any sense.

Thanks

[Zvoni]

If it were an array issue you would get an Error 9 - Out of bounds/Out of Range
Error 13 is usually something like assigning a bike-object to a car-object, a string to a long a.s.o.

[sher]

If it were an array issue you would get an Error 9 - Out of bounds/Out of Range
Error 13 is usually something like assigning a bike-object to a car-object, a string to a long a.s.o.

Which is what I don't understand. If the issue was merely type mismatch, why does the code work for fewer loan items in the portfolio (i.e. fewer rows of data) but fails for larger data set?

[sher]

If I (hypothetically speaking) declared all variables as Variant, would that solve the problem?

[Zvoni]

Maybe, but it wouldn't solve the initial problem. It would be a case that your code works in a certain situation, but you can't be sure that it's going to work always. So it's better to find the root of the error

[vbfbryce]

Can you show us the "portfolio" module?

[sher]

Here is the VBA code for "portfolio" module (I have redacted lot of stuff for ease):

Option Explicit

Private emflag As Boolean

'Private numberOfCDOs As Integer
Private numberOfAssets As Integer
Private numberOfObligors As Integer
Private numberOfIndustries As Integer
Private numberOfPools As Integer
Private numberOfRegions As Integer
Private totalDealDays As Double
Private deltaT As Double

Private assetArray() As asset
Private obligorArray() As obligor
Private pools() As pool

'Private assetsInObligor() As Integer

' Weighted average default probability
Private wadp As Double
Private totalNotional As Double

Public reinvmultiplier As Double


'_________________Generic Functions_______________________

Private Sub Class_Initialize()
    Dim state As Integer
    state = Application.Calculation
    Application.Calculation = xlCalculationManual
    Mode = Range("mode").Value
    
    numberOfPeriods = Range("portfolio.num_periods").Value
    numberOfYears = Range("portfolio.num_years").Value
    paymentFrequency = Range("Frequency").Value
    numberOfAssets = Range("portfolio.num_assets").Value
    numberOfObligors = Range("portfolio.num_obligors").Value
    numberOfCurrencies = Range("portfolio.num_currencies")
    numberOfAssetClasses = Range("portfolio.number_asset_classes").Value
    totalDealDays = Range("portfolio.total_deal_days").Value
    If (Range("useDays360").Value = "y") Then
        deltaT = 1 / 360
    Else
        deltaT = 1 / 365.25
    End If
    recoveryLag = Range("portfolio.recovery_delay").Value * paymentFrequency
    emflag = Range("portfolio.emflag").Value
    totalNotional = Range("portfolio.total_collateral_balance").Value
    
    maturityAdjustment = Range("portfolio.maturityAdjustment").Value
    Call getPeriodSizes
    
    ' Read the pool information
    dealType = string2dealType(Range("portfolio.deal_type").Value)
    If (dealType = CDO_1) Then
        maxRevolvPd = Range("Revolv_PD").Value
        numberOfPools = numberOfCurrencies * numberOfAssetClasses
        Call readPoolInformation
        numberOfCDOs = 0
    Else
    ' In case of CDO^2 pool information is specific to CDOs
        numberOfCDOs = Range("cdo_2.number_cdos").Value
    End If
    
    ' Read default prob matrices
    Call updateDefProb(Mode)
    
    ' Read the asset information
    If (Mode = 2) Then
        Call readAssetInformationMoodys
    ElseIf (Mode = 3) Then
        Call readAssetInformationSP
    End If
    
    'Setup the FX and Interest Curves
    Call initalizeFXInterest
    
    Application.Calculation = state
End Sub


Public Sub readPoolInformation()
    Dim i As Integer, j As Integer
    
    
    ReDim pools(0 To numberOfPools - 1) As pool
    
    ' Read the pool information
    For i = 0 To numberOfCurrencies - 1
        For j = 0 To numberOfAssetClasses - 1
            Set pools(i * numberOfAssetClasses + j) = New pool
            Call pools(i * numberOfAssetClasses + j).readPool(i, j)
        Next j
    Next i
    
End Sub

If this doesn't help spot the obvious cause, I can post the full code.

[Zvoni]

After thinking about it, your issue could be some summary, which is saved inside an integer value, but with the "larger" portfolio the sum exceeds the range of an integer so you would need a long *shrugs*

Btw: when posting your code it would be helpful in which line the error occurs