Results 1 to 2 of 2

Thread: How do I call my subs from another sub?

  1. #1
    New Member
    Join Date
    Aug 12
    Posts
    1

    How do I call my subs from another sub?

    I'm being a bit thick here I think. I want to hide some rows in a spreadsheed, select the unhidden ones and email a report. I have the emailing code and I have the hiding/unhiding code but I cannot integrate the two. Any Ideas how I can do this? Please see below:

    Private Sub CommandButton1_Click()
    'Working in 2000-2010
    Dim Source As Range
    Dim Dest As Workbook
    Dim wb As Workbook
    Dim TempFilePath As String
    Dim TempFileName As String
    Dim FileExtStr As String
    Dim FileFormatNum As Long
    Dim OutApp As Object
    Dim OutMail As Object


    Set Source = Nothing
    On Error Resume Next

    '**************I want to call Hideit here************************

    Set Source = Range("A2:x1000").SpecialCells(xlCellTypeVisible)
    On Error GoTo 0


    If Source Is Nothing Then
    MsgBox "The source is not a range or the sheet is protected, " & _
    "please correct and try again.", vbOKOnly
    Exit Sub
    End If

    With Application
    .ScreenUpdating = False
    .EnableEvents = False
    End With

    Set wb = ActiveWorkbook
    Set Dest = Workbooks.Add(xlWBATWorksheet)
    Source.Copy
    With Dest.Sheets(1)
    .Cells(1).PasteSpecial Paste:=8
    .Cells(1).PasteSpecial Paste:=xlPasteValues
    .Cells(1).PasteSpecial Paste:=xlPasteFormats
    .Cells(1).Select
    Application.CutCopyMode = False
    End With

    '**********************I want to call Unhideit here************************

    TempFilePath = Environ$("temp") & "\"
    TempFileName = "Selection of " & wb.Name & " " _
    & Format(Now, "dd-mmm-yy h-mm-ss")

    If Val(Application.Version) < 12 Then
    'You use Excel 2000-2003
    FileExtStr = ".xls": FileFormatNum = -4143
    Else
    'You use Excel 2007-2010
    FileExtStr = ".xlsx": FileFormatNum = 51
    End If

    Set OutApp = CreateObject("Outlook.Application")
    Set OutMail = OutApp.CreateItem(0)

    With Dest
    .SaveAs TempFilePath & TempFileName & FileExtStr, _
    FileFormat:=FileFormatNum
    On Error Resume Next
    With OutMail
    .To = "XXXXX@yyyyyy.gov.uk"
    .CC = ""
    .BCC = ""
    .Subject = "Automated Amber/Red flag primary exclusion"
    .body = "Hi" & vbNewLine & vbNewLine & _
    "This is an automated email." & vbNewLine & _
    "Please note the attached notification of an Amber/Red flagged exclusion in the Primary sector." & vbNewLine & _
    "You are being notified because you are on the notification list on the Exclusions database." & vbNewLine & _
    ""
    .Attachments.Add Dest.FullName


    'You can add other files also like this
    '.Attachments.Add ("C:\test.txt")
    .Send 'or use .Display
    End With
    On Error GoTo 0
    .Close SaveChanges:=False
    End With

    Kill TempFilePath & TempFileName & FileExtStr

    Set OutMail = Nothing
    Set OutApp = Nothing

    With Application
    .ScreenUpdating = True
    .EnableEvents = True
    End With

    End Sub
    Private Sub Hideit(ByVal Target As Excel.Range)
    Select Case Range("y" & Target.Row).Value
    Case Is = ""
    Target.EntireRow.Hidden = True
    End Select

    End Sub
    Private Sub UnHideit(ByVal Target As Excel.Range)
    Select Case Range("y" & Target.Row).Value
    Case Is = "Notify"
    Target.EntireRow.Hidden = False
    End Select

    End Sub

  2. #2
    PowerPoster
    Join Date
    Dec 04
    Posts
    18,520

    Re: How do I call my subs from another sub?

    you just need to specify the procedure and parameters
    in this case a range
    Code:
    hideit range("b6")
    change range to suit

    if hideit is in a different code window it would need to be public, rather than private
    i do my best to test code works before i post it, but sometimes am unable to do so for some reason, and usually say so if this is the case.
    Note code snippets posted are just that and do not include error handling that is required in real world applications, but avoid On Error Resume Next

    dim all variables as required as often i have done so elsewhere in my code but only posted the relevant part

    come back and mark your original post as resolved if your problem is fixed
    pete

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •