to declare a public param for public class form1

[ksuwanto8ksd]

Imports System
Imports System.Threading
Imports System.ComponentModel
Imports System.IO.Ports
Public Class Form1
    Dim SMSEngine As New SMSCOMMS("COM3")
    Dim i As Integer

    Private Sub ConnectButton_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles ConnectButton.Click

        If SMSPort.IsOpen Then
            SMSPort.Close()
        End If

        Try
            'WITH 
            'END WITH
            SMSPort.Open()
            ListBox1.Items.Add("com3" & " connected.")
            ConnectButton.Enabled = False
            'btnDisconnect.Enabled = True 
        Catch ex As Exception
            MsgBox(ex.ToString)
        End Try
    End Sub

    Public Class SMSCOMMS
        Private WithEvents SMSPort As SerialPort
        Private SMSThread As Thread
        Private ReadThread As Thread
        Shared _Continue As Boolean = False
        Shared _ContSMS As Boolean = False
        Private _Wait As Boolean = False
        Shared _ReadPort As Boolean = False
        Public Event Sending(ByVal Done As Boolean)
        Public Event DataReceived(ByVal Message As String)

        Public Sub New(ByRef COMMPORT As String)
            'initialize all values
            SMSPort = New SerialPort ':wave:DECLARE THIS ONE AS PUBLIC
            With SMSPort
                .PortName = COMMPORT
                .BaudRate = 19200
                .Parity = Parity.None
                .DataBits = 8
                .StopBits = StopBits.One
                .Handshake = Handshake.RequestToSend
                .DtrEnable = True
                .RtsEnable = True
                .NewLine = vbCrLf
            End With
        End Sub
end class
end class

i am new to vb.net
any guru can help on how to declare "smsport" on class smscomms as public so that it can be access in class form1 or button1_click event

thanks in advance for any help

[jmcilhinney]

You could just declare it Public instead of Private. The preferred method though is to use a public property, e.g.

Private myField As SomeType
 
Public Property MyProperty() As SomeType
    Get
        Return myField
    End Get
    Set(ByVal value As SomeType)
        myField = value
    End Set
End Property

You can just type 'prop' and then hit Tab twice to insert that as a code snippet, which you can then edit as required.

[ksuwanto8ksd]

hi thanks for replay,
eventhoguh public, i still cant access "smsport" from ConnectButton_Click

Imports System
Imports System.Threading
Imports System.ComponentModel
Imports System.IO.Ports
Public Class Form1
    Dim SMSEngine As New SMSCOMMS("COM3")
    Dim i As Integer

    Private Sub ConnectButton_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles ConnectButton.Click

        If SMSPort.IsOpen Then
            SMSPort.Close()
        End If

        Try
            'WITH 
            'END WITH
            SMSPort.Open()
            ListBox1.Items.Add("com3" & " connected.")
            ConnectButton.Enabled = False
            'btnDisconnect.Enabled = True 
        Catch ex As Exception
            MsgBox(ex.ToString)
        End Try
    End Sub


    Public Class SMSCOMMS
        Public WithEvents SMSPort As SerialPort
        Private SMSThread As Thread
        Private ReadThread As Thread
        Shared _Continue As Boolean = False
        Shared _ContSMS As Boolean = False
        Private _Wait As Boolean = False
        Shared _ReadPort As Boolean = False
        Public Event Sending(ByVal Done As Boolean)
        Public Event DataReceived(ByVal Message As String)

        Public Sub New(ByRef COMMPORT As String)
            'initialize all values
            SMSPort = New SerialPort
            With SMSPort
                .PortName = COMMPORT
                .BaudRate = 19200
                .Parity = Parity.None
                .DataBits = 8
                .StopBits = StopBits.One
                .Handshake = Handshake.RequestToSend
                .DtrEnable = True
                .RtsEnable = True
                .NewLine = vbCrLf
            End With
        End Sub

     End Class

End Class

[jmcilhinney]

I don't see anywhere that you're actually trying to access it. SMSPort is the public field and it's a member of the SMSCOMMS class. SMSEngine is your SMSCOMMS variable but nowhere are you actually using that variable.

[stavris]

Should it be instead:

If SMSEngine.SMSPort.IsOpen Then
            SMSEngine.SMSPort.Close()
End If
' etc

[Shaggy Hiker]

Yes it should.

SMSPort is a member of an instance of the class. The instance is called SMSEngine, and you always have to refer to the instance you want. This should make sense if you think about it a bit. After all, you could easily have two different instances of the SMSCOMMS class, in which case you would have to state which SMSPort you were refering to, so it makes sense that you have to refer to the instance even if you only have one instance.