[RESOLVED] Need Help With Some Code

[yomamathecableguy]

I'm using this program to log in to a site, and then send a message. What am I doing wrong? Any help is appreciated.

Form1:
Private Sub Command1_Click()
newurl = "http://goallineblitz.com/game/new_message.pl?to=" & Text1.Text
WebBrowser1.Navigate (newurl)
End Sub

Private Sub Command2_Click()
Load Form2
Form2.Show
End Sub

Private Sub WebBrowser1_DocumentComplete(ByVal pDisp As Object, URL As Variant)
If (pDisp Is WebBrowser1.Application) Then
If (InStr(URL, "http://goallineblitz.com/game/new_message.pl?to=") <> 0) Then
Dim HTML As HTMLDocument
Set HTML = WebBrowser1.Document
HTML.All.Item("subject").Value = Text2.Text
HTML.All.Item("message").Value = Text3.Text
HTML.All.Item("action").Click
ElseIf URL = "http://goallineblitz.com/game/login.pl" Then
HTML.All.Item("user_name").Value = Label4.Caption
HTML.All.Item("password").Value = Label5.Caption
HTML.All.Item("action").Click
End If
End If
End Sub

Form2:
Private Sub Command1_Click()
Load Form1
Form1.Label4.Caption = Text1.Text
Form1.Label5.Caption = Text2.Text
Form1.WebBrowser1.Navigate ("http://goallineblitz.com/game/login.pl")
Unload Me
End Sub

[jmsrickland]

Maybe you should tell us what it is not doing that you believe it should be doing and state any and all errors that you may be getting.

[yomamathecableguy]

Well the webbrowser is hidden, so that the user doesn't see all the stuff going on (as to not clutter the screen), and I think that for some reason it isn't carrying out any of the actions.

[jmsrickland]

You still need to be more explicit. I don't even know what the contents of your textboxes and labels are and that could make a difference. I can't test it if I dont have all the necessary info. If you don't want to expose this info (maybe it's your userid and password and I understand that) but then is there some way to give me enough info to at least get it going after I make a connection.

[jmsrickland]

Well, you might try changing your _DocumentComplete event to the below code instead of what you have,

Private Sub WebBrowser1_DocumentComplete(ByVal pDisp As Object, URL As Variant)
 If (pDisp Is WebBrowser1.Application) Then
   Dim HTML As HTMLDocument
   Dim HTMLI As HTMLInputElement
     
   Set HTML = WebBrowser1.Document
  
   If (InStr(URL, "http://goallineblitz.com/game/new_message.pl?to=") <> 0) Then
     For Each HTMLI In HTML.getElementsByTagName("input")
       If HTMLI.Name = "subject" Then
         HTMLI.Value = Text2.Text
       ElseIf HTMLI.Name = "message" Then
         HTMLI.Value = Text3.Text
       ElseIf HTMLI.Name = "action" Then
         HTMLI.Click
       End If
     Next
   ElseIf URL = "http://goallineblitz.com/game/login.pl" Then
     For Each HTMLI In HTML.getElementsByTagName("input")
       If HTMLI.Name = "user_name" Then
         HTMLI.Value = Label4.Caption
       ElseIf HTMLI.Name = "password" Then
         HTMLI.Value = Label5.Caption
       ElseIf HTMLI.Name = "action" Then
         HTMLI.Click
       End If
     Next
   End If
 End If
End Sub

[yomamathecableguy]

Sorry for not elaborating very much. XD Here are the controls in my forms:

Form1
Recipient ID (textbox - text1)
Subject (textbox - text2)
Message (textbox - text3)
Login First! (commandbutton - Command2)
Send! (commandbutton - Command1)
Web Browser (webbrowser - webbrowser1)

Form2
Username (textbox - text1)
Password (textbox - text2)
Login (commandbutton - Command1)

Form2 stores the username and password in hidden labels and uses those to fill in the web page.

I've provided my 2 forms as attachments.

[yomamathecableguy]

can anyone help with this?

[jmsrickland]

Are you saying that my post didn't help you with your problem?

[yomamathecableguy]

I tried your code, and it did not solve the problem. Both of our codes looked to be good. I'm not sure why they aren't working.

[jmsrickland]

Maybe it didn't solve your entire problem but it was necessary to solve that part of it because I know the code you had was incorrect and the code I posted corrected it.

[jmsrickland]

I looked at your two Forms and you didn't change it to what I posted and that is one reason why it doesn't work and it never will the way you have it. What I posted is the correct way to do it. You have to add a reference to Microsoft HTML Object Library to you project

[jmsrickland]

BTW: Make your WebBrowser control Visible = True and hide it underneath the textbox. Invisible WebBrowser control does not fire your DocumentComplete event. Put the code I gave you back in your project and add the reference like I said and it should work.

[yomamathecableguy]

The attachments I provided were with my original code. I tried your code also.. I'll try making the webbrowser visible with your code ^_^

[yomamathecableguy]

After a little tweaking I finally got it working. I think the invisible webbrowser was the main thing screwing me up. Thanks jmstrickland! btw, I can upload the working forms if you would like ^_^

[jmsrickland]

I think the invisible webbrowser was the main thing screwing me up.

Not the main thing.

Your DocumentComplete event was totally wrong because you were trying to work with all elements of the same name...

HTML.All.Item("subject").Value = Text2.Text

...and some of them did not support your request.

[yomamathecableguy]

Ah I see. Well thanks so much man ^_^ Helped my project a lot