Winsock, Pain in the...

[DigitalMyth]

ok, i'm trying to make a chat server to get into winsocks programming in C++ coming over from VB6. but i think i 'm missing some key knowlegde when it comes to strings.

I can get

• get the data from the socket one charater at a time
• i can catch a new line
• i can catch a backspace

but what i can't do put it into a string without FOUR 2222 at the end of it all.

image below.

WHYYYYYYYY????

send (Client, "Server V. 0.1\n",13, 0);
    char buffer;
    char flip[255];
    char *flop;
    int pos = 0;
 
    
    while(Alive == 1) {
            
            rCode = recv(Client,&buffer,1,0);
            if(rCode == SOCKET_ERROR) {
                rCode = WSAGetLastError();
                cout << "\nERROR:recv()" << rCode;
                WSACleanup();
                return 1;
            }else if(rCode == 0) {
                cout << "Disconnected";
                Alive = 0;
            }else{
                if (buffer == char(13)) {
                    flop = new char[pos];
                    for (int i = 0; i < pos; i++) {
                        flop[i] = flip[i];
                    }
                    pos = 0;
                    cout << flop;
                } else {
                    flip[pos] = buffer;
                    pos++;
                }
            }
    }

[CornedBee]

You receive the string fine. The problem is when you display it. The display routines assume that the string is NUL-terminated, but the one you received isn't, because you haven't made it so.

flop = new char[pos];
for (int i = 0; i < pos; i++) {
	flop[i] = flip[i];
}
flop[pos] = '\0';
pos = 0;
cout << flop;

Mind you, you have a huge memory leak and a buffer overflow in that code, not to mention quite some unnecessary copy overhead. (The flop buffer is completely unnecessary.)