MySQL .bas Module

I Made a MySQL Module File For People That Need it, So Here it is.

Query Examples

To Run A Mysql Query:

vb6 Code:

MySQLQuery ("SELECT * FROM people WHERE lastname = 'smith'")
 
lastname = rogers
MySQLQuery ("UPDATE people SET lastname = 'smith' WHERE firstname = 'john'")

Quote:

---

Attachments:
Attachment 69394

---

If i were to mark the code you posted, I would give a 1 out of 10. And the 1 is for trying...

No indentation AT ALL !
Functions that don't return anything, make them a SUB
Use Private/Public in general declarations of a module, NOT Dim
Global is obsolete, use Public
You have error labels, but On Error Resume Next :confused: , you should have "On Error GoTo errhandle"
You are accessing a form from a Module ! Always pass Objects through sub/function parameters. What if I did not have the frmMain or Form3 ???
You have 3 functions that do exactly the same thing !
You are using End :eek: , always use "Unload objectname"
The Connect function uses static LogIn, you should pass those values as parameters

Thanks So Much :)

Ok CVMichael, Can you correct and improve it ?

Quote:

---

Originally Posted by CVMichael

If i were to mark the code you posted, I would give a 1 out of 10. And the 1 is for trying...

No indentation AT ALL !
Functions that don't return anything, make them a SUB
Use Private/Public in general declarations of a module, NOT Dim
Global is obsolete, use Public
You have error labels, but On Error Resume Next :confused: , you should have "On Error GoTo errhandle"
You are accessing a form from a Module ! Always pass Objects through sub/function parameters. What if I did not have the frmMain or Form3 ???
You have 3 functions that do exactly the same thing !
You are using End :eek: , always use "Unload objectname"
The Connect function uses static LogIn, you should pass those values as parameters

---

Also, he hasn't included any comments in his code! I reckon it would have been better if he posted a working example rather than just one bas file. Which, on its own doesn't do anything.

Ok, Can you correct and improve it ?

Quote:

---

Originally Posted by alMubarmij

Ok, Can you correct and improve it ?

---

As to the code he posted I am not sure since it has been a while since I've made anything in VB6.0. However, I could add user comments to the code tell tell people how to use the code. That is what I was talking about above.

Based on what CVMichael wrote, it would be a bad idea to use it, even if corrections were applied (which could take a while).

Instead it would be better start again based on the examples in our Database Development FAQs/Tutorials (at the top of the Database Development forum)

Thanks For share .
Really i finding this...