[RESOLVED] Removing controls

[Arve K.]

Hi,

I'm using this code to remove controls from a panel...

For Each c As Control In Me.pnlDevices.Controls
    Me.pnlDevices.Controls.Remove(c)
Next

...but somehow it doesn't remove all the controls at once, I have to run the code 3 times to remove them all
(there is about 20 to 30 of them, mainly labels)...

I don't know if it matters, but the controls where added dynamically at startup...

[jmcilhinney]

I'm surprised that that code actually runs at all. I would have expected it to throw an exception. NEVER enumerate a list using a For each loop and then modify the list inside the loop. If you want to clear a list completely then, if it has one, call its Clear method. Otherwise, use a Do or While loop or else use a For loop and go from end to beginning rather than beginning to end.

[.paul.]

try this instead:

For x As Integer = Me.pnlDevices.Controls.count - 1 To 0 Step -1
    Me.pnlDevices.Controls.RemoveAt(x)
Next

your code modifies Me.pnlDevices.Controls in a for each loop causing the for each to fail.

[Arve K.]

Oh, I never thought of it that way... No wonder it didn't work

Thank you both for you help, problem solved!