[RESOLVED] combo box

[basti42]

hello!
for example i have tblInfo and a field name LETTERS and has values a,b and c
i used below code but it olny add the "a" value on th combo box
not the 3 letters

rs.open " SELECT LETTERS FROM tblInfo", con, adOpenDynamic, adLockOptimistic
If rs.EOF <> True Then
combobox1.AddItem rs.Fields(0)
End If
rs.Close

[RobCrombie]

Dim myStr as string
 
  rs.open " SELECT LETTERS FROM tblInfo", con, adOpenDynamic, adLockOptimistic
  If rs.EOF <> True Then
    mystr= rs.Fields(0) & rs.Fields(1) & rs.Fields(2)
    combobox1.AddItem myStr
  End If
  rs.Close

[basti42]

nope...
i want to add on the combox as dropdown list
and there is only one(1) field that is "LETTERS"=rs.Fields(0)
there are no fields(1) and fields(2)

if you try the first record only will be add to the combo box
but i want is all the records

[RobCrombie]

rs.open " SELECT LETTERS FROM tblInfo", con, adOpenDynamic, adLockOptimistic
If not(rs.EOF) Then
  rs.movefirst
  do while not(rs.EOF)       
    combobox1.AddItem rs.Fields(0)
    rs.movenext        
  loop        
  rs.Close	
end if

That may meet your needs ?
(I have not tested it)

[basti42]

tnx rob the problem was solved...
what's the error here?
because if the rs is not equal to EOF it must add all the values to combo box.

rs.open " SELECT LETTERS FROM tblInfo", con, adOpenDynamic, adLockOptimistic
If rs.EOF <> True Then
combobox1.AddItem rs.Fields(0)
End If
rs.Close

[RobCrombie]

If I understand your question 'why did that code not work ?'

When a rs is in memory, it is like an array, wherein you read the contents of the array by asking for the contents of an element in the array.
However with a rs there is a pointer to one record.
You must move that pointer to read the field values in that record
You only ever get the values of one record at a time.

You must first position the rs at the first record (which by luck it was on your original code)
Then after adding the field contents to your combobox (contents of the field in the current record), you must reposition the pointer in the rs to the next record. That is what the movenext does.
As you move through the rs with movenext, you keep adding the field contents (for the current record) into the combobox

[basti42]

ok tnx for your explanation
i thought it will keep adding to the combobox until it reaches the .EOF
even without loop and moving...

tnx again.