[RESOLVED] [2005] Reading Lines

[IAmThomas]

I have a code and this is how I need it to work.

1. Download page from the internet into a string.
2. Search through lines
3. If a line includes a certain string, add it to a textbox
4. Until the end of the lines.

But mine doesnt work.

Private Sub btnGrab_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnGrab.Click
        Dim externalPage As String = Nothing
        Dim Line As String
        externalPage = WebClient1.DownloadString("http://iat.awardspace.com/text.txt")
        Dim streamr As New IO.StreamReader(externalPage)
        While Not streamr.EndOfStream
            Line = streamr.ReadLine
            If Line.Contains("S") Then
                TextBox1.Text = TextBox1.Text & Line.ToString & vbNewLine
            End If
        End While
    End Sub

Im fairly new to VB.NET and I know I've done something wrong. I think it's something to do with the StreamReader. Its supposed to read streams, but I dont have any. Can anybody help me get this working please?

[stimbo]

Your code looks okay. Maybe try this as the Loop condition:
Do While sr.Peek <> -1


Loop


Alternatively, you could use this and avoid the streamreader code:

Dim myStr() As String
        myStr = IO.File.ReadAllLines(externalPage)
        For Each str As String In myStr
            If str.Contains("text") Then
                Me.TextBox1.Text = TextBox1.Text & str.ToString & vbNewLine
            End If
        Next

[IAmThomas]

Well both the StreamReader and ReadAllLines have to read files on your computer, not strings. Is there anything that could read strings?

[BrendanDavis]

Well both the StreamReader and ReadAllLines have to read files on your computer, not strings. Is there anything that could read strings?

I don't have .Net open but something like this should work:

Dim externalPage() As String = Split(WebClient1.DownloadString("http://iat.awardspace.com/text.txt"), VbCrLf)
 
        For i As Integer = 0 To UBound(externalPage)
            If externamePage(i).Contains("S") Then TextBox1.Text = TextBox1.Text & externamePage(i).ToString & vbNewLine
        Next

[stimbo]

But the string array that gets fed the text file would then be in string format would it not?

[BrendanDavis]

But the string array that gets fed the text file would then be in string format would it not?

Yes it would, but it's not like you couldn't convert it later if need be. Or better yet, convert it to a string to a separate variable so that you have both, and then follow the example I provided. That way, you can parse the string array as needed and you still have the stream.

[IAmThomas]

Im having problems. The code isn't splitting properly. I dont think its the right character that it is being split by.

[BrendanDavis]

Im having problems. The code isn't splitting properly. I dont think its the right character that it is being split by.

It's splitting the file by lines. If your file is multiline, then it should be splitting it just fine. If not, insert a break point somewhere or debug.print in there to see how it is breaking things up and post it here.

[IAmThomas]

This is my file:
http://iat.awardspace.com/text.txt

This is my code:

Private Sub btnGrab_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnGrab.Click
 
        Dim externalPage() = Split(WebClient1.DownloadString("http://iat.awardspace.com/text.txt"), vbCrLf)
 
        For i As Integer = 0 To UBound(externalPage)
            If externalPage(i).Contains("S") Then TextBox1.Text = TextBox1.Text & externalPage(i).ToString & vbNewLine
        Next
 
    End Sub

And this is what happens when I execute it:

[stimbo]

If you had put a messagebox after the split command you would realise that it's not splitting the file by vbCrLf.

It should be this:

Dim externalPage() As String = webClient1.DownloadString("http://iat.awardspace.com/text.txt").Split(Chr(10))

[IAmThomas]

Thanks, I was trying to find which Chr it was but I didnt try 10


Thanks.

[BrendanDavis]

Thanks, I was trying to find which Chr it was but I didnt try 10


Thanks.

You should always know what you're working with. I assumed that each line was split by a standard carriage return, because 9 times out of 10 they are. In any case, the code should work fine now if you replace the VbCrLf with Chr$(10)