You should use [php] tages to post code. Also, it is BAD to echo HTML.
On to your error, your middle part of the for loop contains a condition but one which starts off as false (ie: is $coutner equal to 20). The for loop will execute the loop until the condition evaluates to false. If the condition is false to start it will never execute.
What you need to do and what I think you meant to do is have the loop execute until the vlaue of $counter reaches 20. In this case you need the condition to evaluate to true every iteration prior to that:
PHP Code:
for ($counter=1; $counter<=20; $counter++) {
$_5_price = "update_5_price";
$_5_price.= $counter;
$frame = "frame";
$frame.= $counter;
$style = "style";
$style.= $counter;
$style = $_REQUEST[$style];
$style = preg_replace("/####/", " ", $style);
echo $_5_price;
echo "<br>";
echo $frame;
echo "<br>";
echo $style;
}